The custom Paint API specs is here: https://drafts.css-houdini.org/css-paint-api/#paint-function It will be nice to have input arguments for the custom paint API. The design doc is here: https://docs.google.com/a/google.com/document/d/10yq_okp1-QJ2Qy5S8ZQhwxQcR4T4fgzqxx9FHwrIIeY/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1352c4d7f1deb4196f3498cc76462c45cf325622 commit 1352c4d7f1deb4196f3498cc76462c45cf325622 Author: renjieliu <renjieliu@chromium.org> Date: Mon Jan 09 01:31:05 2017 Add new runtime enabled features CSSPaintAPIArguments BUG= 672647 Review-Url: https://codereview.chromium.org/2550183006 Cr-Commit-Position: refs/heads/master@{#442189} [modify] https://crrev.com/1352c4d7f1deb4196f3498cc76462c45cf325622/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
Owner inactive and this feature is part of CSS Paint, right?
Seems like renjieliu@chromium.org is active on this
Right, I think this feature is part of CSS Paint
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c commit 5d90cabdbd8ea0727b661c2f4d5be5e13151e94c Author: renjieliu <renjieliu@chromium.org> Date: Thu Jan 19 05:39:05 2017 Parse input argument types and store the argument types in CSSPaintDefinition. BUG= 672647 Review-Url: https://codereview.chromium.org/2561773003 Cr-Commit-Position: refs/heads/master@{#444657} [add] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/LayoutTests/csspaint/parse-input-arguments-expected.txt [add] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/LayoutTests/csspaint/parse-input-arguments.html [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/LayoutTests/csspaint/registerPaint-expected.txt [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/LayoutTests/csspaint/registerPaint.html [add] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/LayoutTests/csspaint/resources/test-runner-paint-helper.js [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp [modify] https://crrev.com/5d90cabdbd8ea0727b661c2f4d5be5e13151e94c/third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fd4bea578f28ab1fc10e0c3f2f5591e523020db commit 3fd4bea578f28ab1fc10e0c3f2f5591e523020db Author: renjieliu <renjieliu@chromium.org> Date: Tue Jan 31 02:26:20 2017 Change deprecate assert to DCHECK in CSSVariableData BUG= 672647 Review-Url: https://codereview.chromium.org/2662773002 Cr-Commit-Position: refs/heads/master@{#447168} [modify] https://crrev.com/3fd4bea578f28ab1fc10e0c3f2f5591e523020db/third_party/WebKit/Source/core/css/CSSVariableData.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e3e9494dcbd592e5ca4e1d3f058d797b0343dad commit 9e3e9494dcbd592e5ca4e1d3f058d797b0343dad Author: renjieliu <renjieliu@chromium.org> Date: Tue Jan 31 03:14:56 2017 Expose a method to convert a CSSValue into a CSSStyleValueVector when you don't have a CSSPropertyID BUG= 672647 Review-Url: https://codereview.chromium.org/2649323007 Cr-Commit-Position: refs/heads/master@{#447175} [modify] https://crrev.com/9e3e9494dcbd592e5ca4e1d3f058d797b0343dad/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp [modify] https://crrev.com/9e3e9494dcbd592e5ca4e1d3f058d797b0343dad/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d18dd5bf544f6e8a0ed730588956df9da41db235 commit d18dd5bf544f6e8a0ed730588956df9da41db235 Author: renjieliu <renjieliu@chromium.org> Date: Tue Feb 28 08:59:16 2017 Implement CSSPaintValue and add a layout test. BUG= 672647 Review-Url: https://codereview.chromium.org/2661323002 Cr-Commit-Position: refs/heads/master@{#453546} [add] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/LayoutTests/csspaint/paint-arguments-expected.html [add] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/LayoutTests/csspaint/paint-arguments.html [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/core/css/CSSPaintValue.cpp [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/core/css/CSSPaintValue.h [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/core/css/CSSVariableData.h [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.h [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp [modify] https://crrev.com/d18dd5bf544f6e8a0ed730588956df9da41db235/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d5b46f03cec4b48aa5c6915a82952a600fe550c commit 6d5b46f03cec4b48aa5c6915a82952a600fe550c Author: renjieliu <renjieliu@chromium.org> Date: Wed Mar 01 00:22:20 2017 support function as parameter in custom paint input arguments. Example: paint(myPaintFunc, Calc(1px + 2px), rgb(10, 10, 10)) can be parsed and used. BUG= 672647 Review-Url: https://codereview.chromium.org/2698083003 Cr-Commit-Position: refs/heads/master@{#453767} [add] https://crrev.com/6d5b46f03cec4b48aa5c6915a82952a600fe550c/third_party/WebKit/LayoutTests/csspaint/paint-function-arguments-expected.html [add] https://crrev.com/6d5b46f03cec4b48aa5c6915a82952a600fe550c/third_party/WebKit/LayoutTests/csspaint/paint-function-arguments.html [modify] https://crrev.com/6d5b46f03cec4b48aa5c6915a82952a600fe550c/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp [modify] https://crrev.com/6d5b46f03cec4b48aa5c6915a82952a600fe550c/third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp
Comment 1 by bugdroid1@chromium.org
, Jan 9 2017