New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672645 link

Starred by 1 user
Status: Fixed
Owner:
st...@chromium.org
Closed: Dec 2016
Cc:
chanli@chromium.org
█ andyb...@chromium.org
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Can't edit CL description

Project Member Reported by st...@chromium.org, Dec 8 2016 
I tried to edit the CL description in https://chromium-review.googlesource.com/#/c/417990/

But when I click the "Edit Description" button, it doesn't work for me. And from the DevTools console, I saw following errors:

gerrit_ui-0.js:3487 XHR finished loading: PUT "https://chromium-review.googlesource.com/changes/417990/revisions/e588af8f3c1b0544b15b19539125ad0f28971dee/description".Mbc @ gerrit_ui-0.js:3487Nbc @ gerrit_ui-0.js:1606KHb @ gerrit_ui-0.js:3348GHb @ gerrit_ui-0.js:1362eP @ gerrit_ui-0.js:3071WQ @ gerrit_ui-0.js:3227Xy @ gerrit_ui-0.js:3694UIb @ gerrit_ui-0.js:3695GIb @ gerrit_ui-0.js:3695dbc @ gerrit_ui-0.js:3479Wac @ gerrit_ui-0.js:3187bc @ gerrit_ui-0.js:1015NIb @ gerrit_ui-0.js:3186dc @ gerrit_ui-0.js:2876oc @ gerrit_ui-0.js:3693WTc @ gerrit_ui-0.js:2587EVc @ gerrit_ui-0.js:2351I1b @ gerrit_ui-0.js:1477L1b @ gerrit_ui-0.js:3197(anonymous function) @ gerrit_ui-0.js:2286
gerrit_ui-0.js:3696 Thu Dec 08 15:49:36 GMT-800 2016 Class$840
SEVERE: (TypeError) : Cannot read property 'alert' of null
Class$S215: (TypeError) : Cannot read property 'alert' of null
	at Unknown.gP(gerrit_ui-0.js)
	at Unknown.iP(gerrit_ui-0.js)
	at Unknown.VHb(gerrit_ui-0.js)
	at Unknown.YHb(gerrit_ui-0.js)
	at Unknown.Bbc(gerrit_ui-0.js)
	at Unknown.Vbc(gerrit_ui-0.js)
	at Unknown.eval(gerrit_ui-0.js)
	at Unknown.I1b(gerrit_ui-0.js)
	at Unknown.L1b(gerrit_ui-0.js)
	at Unknown.eval(gerrit_ui-0.js)


Happened to see another error when reloading the page:
XMLHttpRequest cannot load https://gerrit-review.googlesource.com/Documentation/index.html. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://chromium-review.googlesource.com' is therefore not allowed access.

Comment 1 by st...@chromium.org, Dec 8 2016

Labels: Pri-1 Type-Bug
I put P1 to this bug, as I can't find alternative to edit the description. Please feel free to do P2/P3 if there is a workaround.

Comment 2 by aga...@chromium.org, Dec 9 2016

Cc: andyb...@chromium.org
Owner: st...@chromium.org
The fact that there is a '#' in the URL you linked means that you are using old gerrit, not PolyGerrit. Please use PolyGerrit (click the link in the footer of the page) and see if this issue still reproduces. If it does, then assign back to us.

Comment 3 by andyb...@chromium.org, Dec 9 2016

Status: Fixed (was: Assigned)
This has been fixed. It just hasn’t rolled out yet.

Comment 4 by st...@chromium.org, Dec 9 2016 

That works for me.

Originally, the link in the email (https://chromium-review.googlesource.com/417990) always redirects to the old gerrit.
But after I clicked the PolyGerrit link as suggested, it now redirects to PolyGerrit.

Just curious: is that an opt-in by clicking the PolyGerrit link?

Comment 5 by andyb...@chromium.org, Dec 9 2016 

https://bugs.chromium.org/p/gerrit/issues/detail?id=4999 is filed to track the issue you describe.
►

Sign in to add a comment