New issue
Advanced search Search tips

Issue 672636 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 672294
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ForeignFetchRequestHandlerTest.CheckOriginTrialToken_ValidToken" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 8 2016

Issue description

"ForeignFetchRequestHandlerTest.CheckOriginTrialToken_ValidToken" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9Gb3JlaWduRmV0Y2hSZXF1ZXN0SGFuZGxlclRlc3QuQ2hlY2tPcmlnaW5UcmlhbFRva2VuX1ZhbGlkVG9rZW4M.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: mek@chromium.org
Status: Assigned (was: Untriaged)
Assigning to mek@. https://codereview.chromium.org/2554393003 seems to be the most relevant patch.
This can also be a fault of the bot. See  Issue 672382 .

Comment 2 by mek@chromium.org, Dec 9 2016

Cc: iclell...@chromium.org
Yeah, this is pretty much the same issue as #672294
See https://codereview.chromium.org/2555333006/; I'm updating the TrialTokenValidator functions to take a base::Time, which can probably be used in this case as well.

Comment 4 by mek@chromium.org, Jul 10 2017

Components: Internals>OriginTrials
Mergedinto: 672294
Status: Duplicate (was: Assigned)
I'm not really working on this, and since this is really the same bug as 672294 it probably makes more sense to merge it into that bug anyway.

Sign in to add a comment