New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672614 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 677194



Sign in to add a comment

Service Manager: Things be too complicated

Project Member Reported by roc...@chromium.org, Dec 8 2016

Issue description

We have three different code paths used to package services today: content does it, chrome mash_runner does it, and mash_browser_tests does it. Also overlays are bad.

The aggregate complexity here is making developers sad; servicification should make them happy, not sad.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17441e57d06b74f3abea1f07a6a6115fee611f23

commit 17441e57d06b74f3abea1f07a6a6115fee611f23
Author: rockot <rockot@chromium.org>
Date: Wed Dec 14 00:40:13 2016

Flatten mash overlay back into Chrome overlay

Since "mash" is really just a build-time detail of Chrome at
this point, roughly equivalent to "Chrome OS", and we don't maintain
separate manifest metadata for other conditional platform features,
this eliminates one unnecessary layer of overlays by flattening
Mash's additional specs into the Chrome overlay.

BUG= 672614 

Review-Url: https://codereview.chromium.org/2573743003
Cr-Commit-Position: refs/heads/master@{#438365}

[modify] https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23/chrome/app/mash/BUILD.gn
[delete] https://crrev.com/e91a7d707ea7a42d73ae2886bcd73b7adef00429/chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json
[modify] https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23/chrome/app/mash/chrome_mash_manifest.json
[modify] https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23/chrome/app/mash/mash_service_overrides.json
[modify] https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23/chrome/browser/chrome_content_browser_manifest_overlay.json

Comment 2 by roc...@chromium.org, Dec 27 2016

Blockedon: 677194
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07e10fd70e44126d20a19b639fb18deee52cd906

commit 07e10fd70e44126d20a19b639fb18deee52cd906
Author: rockot <rockot@chromium.org>
Date: Sat Jan 07 19:39:09 2017

Service Manager: Miscellaneous catalog cleanup

Simplifies lifetime management of catalog Entry objects, introducing
a hierarchical EntryCache with global lookup.

Also takes care of some other miscellaneous cleanup encountered along
the way.

BUG= 672614 

Review-Url: https://codereview.chromium.org/2611183006
Cr-Commit-Position: refs/heads/master@{#442171}

[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/content/content_resources.grd
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/BUILD.gn
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/catalog.cc
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/catalog.h
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/entry.cc
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/entry.h
[add] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/entry_cache.cc
[add] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/entry_cache.h
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/instance.cc
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/instance.h
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/reader.cc
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/reader.h
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/catalog/store.h
[delete] https://crrev.com/0f762fedb8512772504cd5548b93f2523ec1e3a2/services/catalog/types.h
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/device/manifest.json
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/service_manager/public/interfaces/resolver.mojom
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/service_manager/service_manager.cc
[modify] https://crrev.com/07e10fd70e44126d20a19b639fb18deee52cd906/services/service_manager/service_manager.h

Components: -Internals>Mojo Internals>ServiceManager
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a497cd5ce83519a9c71bd1ef877f85ec022d38

commit f5a497cd5ce83519a9c71bd1ef877f85ec022d38
Author: rockot <rockot@chromium.org>
Date: Tue Jan 24 08:09:04 2017

[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG= 677194 , 672614 
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests, various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2645973006
Cr-Commit-Position: refs/heads/master@{#445678}

[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/ash/mus/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/app/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/app/mash/DEPS
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/browser/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/browser/browser_resources.grd
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/test/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/test/base/mash_browser_tests_main.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chrome/test/base/mojo_test_connector.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/chromecast/browser/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/components/filesystem/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/components/filesystem/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/components/filesystem/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/components/leveldb/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/components/leveldb/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/components/leveldb/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/content_resources.grd
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/public/app/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/test/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/test/DEPS
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/content/test/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/example/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/quick_launch/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/runner/BUILD.gn
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/runner/DEPS
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/runner/main.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/test/DEPS
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/mash/test/mash_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/media/mojo/services/BUILD.gn
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/media/mojo/services/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/media/mojo/services/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/catalog.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/catalog.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/entry.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/entry.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/instance.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/instance.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/public/tools/catalog.gni
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/catalog/public/tools/generate_manifest.py
[delete] https://crrev.com/00349ff6fdc6751b559d5bf89e35f8af7b62c4cb/services/catalog/reader.cc
[delete] https://crrev.com/00349ff6fdc6751b559d5bf89e35f8af7b62c4cb/services/catalog/reader.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/background/background_service_manager.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/background/tests/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/background/tests/background_service_manager_unittest.cc
[delete] https://crrev.com/00349ff6fdc6751b559d5bf89e35f8af7b62c4cb/services/service_manager/public/constants.gni
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/cpp/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/cpp/lib/service_test.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/cpp/service.gni
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/cpp/service_test.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/cpp/standalone_service/main.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/service_manifest.gni
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/public/tools/manifest/manifest_collator.py
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/runner/host/service_process_launcher_unittest.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/service_manager.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/service_manager.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/standalone/context.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/standalone/context.h
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/tests/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/tests/lifecycle/BUILD.gn
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/tests/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/service_manager/tests/shutdown/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/clipboard/BUILD.gn
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/clipboard/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/clipboard/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/demo/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/demo/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/demo/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/ime/BUILD.gn
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/ime/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/ime/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/ws/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/ws/DEPS
[add] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/services/ui/ws/run_all_unittests.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/ui/views/mus/BUILD.gn
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/ui/views/mus/DEPS
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/ui/views/mus/run_all_unittests_mus.cc
[modify] https://crrev.com/f5a497cd5ce83519a9c71bd1ef877f85ec022d38/ui/views/mus/views_mus_test_suite.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/415bd5606cf989923a835e5977c645313d65cc45

commit 415bd5606cf989923a835e5977c645313d65cc45
Author: johnme <johnme@chromium.org>
Date: Tue Jan 24 12:07:55 2017

Revert of [Service Manager] Get rid of dynamic service discovery (patchset #10 id:180001 of https://codereview.chromium.org/2645973006/ )

Reason for revert:
Seems to have broken content_unittests on both
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/39329
and
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/9385

with the following error:

CommandFailedError: Failed to list tests on any device

caused by a crash when listing tests:

[FATAL:catalog.cc(167)] Check failed: result.

Original issue's description:
> [Service Manager] Get rid of dynamic service discovery
>
> Dynamic service discovery introduces complexity and nondeterminism in
> the Service Manager, and its implementation was never quite production-
> ready.
>
> This CL removes all of that support, instead requiring a static
> service catalog configuration to be provided. Support remains for
> dynamic manifest discovery via ManifestProvider in order to satisfy
> content layering requirements.
>
> The interesting and interdependent high-level changes covered here:
>
>   - No more Packages directory; service binaries live in root_out_dir
>   - Catalog no longer touches disk for any metadata
>   - service_manifest and catalog target settings have less redundancy
>   - service_manifest and catalog outputs go in the target_gen_dir now
>   - service_manifest_overlay behavior has been merged into service_manifest
>   - Service Manager may be constructed with a static catalog manifest
>   - BackgroundServiceManager no longer owns EDK init/shutdown
>   - SM::StartEmbedderService -> SM::RegisterService, more generic API
>   - The "service overrides" concept is no longer useful and thus removed
>   - All SM embedders, including test suites, are now configured with
>     their own static catalog manifest at runtime.
>
> BUG= 677194 , 672614 
> TEST=standalone mash_session works, chrome --mash works, mash_browser_tests, various mus and SM-related unit tests all operating normally
> TBR=sky@chromium.org
> TBR=xhwang@chromium.org
>
> Review-Url: https://codereview.chromium.org/2645973006
> Cr-Commit-Position: refs/heads/master@{#445678}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef877f85ec022d38

TBR=ben@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 677194 , 672614 

Review-Url: https://codereview.chromium.org/2651953002
Cr-Commit-Position: refs/heads/master@{#445707}

[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/ash/mus/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/app/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/app/mash/DEPS
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/browser/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/browser/browser_resources.grd
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/test/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/test/base/mash_browser_tests_main.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chrome/test/base/mojo_test_connector.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/chromecast/browser/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/components/filesystem/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/components/filesystem/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/components/filesystem/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/components/leveldb/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/components/leveldb/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/components/leveldb/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/content_resources.grd
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/public/app/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/test/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/test/DEPS
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/content/test/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/example/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/quick_launch/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/runner/BUILD.gn
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/mash/runner/DEPS
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/runner/main.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/test/DEPS
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/mash/test/mash_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/media/mojo/services/BUILD.gn
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/media/mojo/services/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/media/mojo/services/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/catalog.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/catalog.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/entry.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/entry.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/instance.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/instance.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/public/tools/catalog.gni
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/public/tools/generate_manifest.py
[add] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/reader.cc
[add] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/catalog/reader.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/background/background_service_manager.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/background/tests/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/background/tests/background_service_manager_unittest.cc
[add] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/constants.gni
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/cpp/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/cpp/lib/service_test.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/cpp/service.gni
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/cpp/service_test.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/cpp/standalone_service/main.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/service_manifest.gni
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/public/tools/manifest/manifest_collator.py
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/runner/host/service_process_launcher_unittest.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/service_manager.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/service_manager.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/standalone/context.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/standalone/context.h
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/tests/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/tests/lifecycle/BUILD.gn
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/service_manager/tests/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/service_manager/tests/shutdown/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/clipboard/BUILD.gn
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/ui/clipboard/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/ui/clipboard/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/demo/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/demo/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/ui/demo/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/ime/BUILD.gn
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/ui/ime/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/ui/ime/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/ws/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/services/ui/ws/DEPS
[delete] https://crrev.com/c7ee9d5e15a8d98d5f5fe2afcff74bec2f3ae7d6/services/ui/ws/run_all_unittests.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/ui/views/mus/BUILD.gn
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/ui/views/mus/DEPS
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/ui/views/mus/run_all_unittests_mus.cc
[modify] https://crrev.com/415bd5606cf989923a835e5977c645313d65cc45/ui/views/mus/views_mus_test_suite.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a386b5d98de38051e36d314fc43a8a81f913353

commit 0a386b5d98de38051e36d314fc43a8a81f913353
Author: rockot <rockot@chromium.org>
Date: Wed Jan 25 00:14:34 2017

[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG= 677194 , 672614 
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests, various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2645973006
Cr-Original-Commit-Position: refs/heads/master@{#445678}
Committed: https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef877f85ec022d38
Review-Url: https://codereview.chromium.org/2645973006
Cr-Commit-Position: refs/heads/master@{#445870}

[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ash/autoclick/mus/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ash/mus/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ash/touch_hud/mus/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/app/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/app/mash/DEPS
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/browser/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/browser/browser_resources.grd
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/test/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/test/base/mash_browser_tests_main.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chrome/test/base/mojo_test_connector.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/chromecast/browser/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/filesystem/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/filesystem/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/filesystem/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/font_service/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/leveldb/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/leveldb/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/leveldb/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/content_resources.grd
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/public/app/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/test/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/test/DEPS
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/content/test/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/example/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/quick_launch/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/runner/BUILD.gn
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/runner/DEPS
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/runner/main.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/test/DEPS
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/mash/test/mash_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/media/mojo/services/BUILD.gn
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/media/mojo/services/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/media/mojo/services/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/catalog.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/catalog.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/entry.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/entry.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/instance.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/instance.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/public/tools/catalog.gni
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/catalog/public/tools/generate_manifest.py
[delete] https://crrev.com/5f91d1754a7ffa39cff9619db090b91b8d1b4a98/services/catalog/reader.cc
[delete] https://crrev.com/5f91d1754a7ffa39cff9619db090b91b8d1b4a98/services/catalog/reader.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/device/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/file/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/image_decoder/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/background/background_service_manager.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/background/tests/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/background/tests/background_service_manager_unittest.cc
[delete] https://crrev.com/5f91d1754a7ffa39cff9619db090b91b8d1b4a98/services/service_manager/public/constants.gni
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/cpp/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/cpp/lib/service_test.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/cpp/service.gni
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/cpp/service_test.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/cpp/standalone_service/main.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/service_manifest.gni
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/public/tools/manifest/manifest_collator.py
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/runner/host/service_process_launcher_unittest.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/service_manager.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/service_manager.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/standalone/context.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/standalone/context.h
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/tests/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/tests/lifecycle/BUILD.gn
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/tests/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/service_manager/tests/shutdown/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/tracing/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/clipboard/BUILD.gn
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/clipboard/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/clipboard/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/demo/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/demo/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/demo/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ime/BUILD.gn
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ime/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ime/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ime/test_ime_driver/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ws/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ws/DEPS
[add] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/services/ui/ws/run_all_unittests.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ui/views/mus/BUILD.gn
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ui/views/mus/DEPS
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ui/views/mus/run_all_unittests_mus.cc
[modify] https://crrev.com/0a386b5d98de38051e36d314fc43a8a81f913353/ui/views/mus/views_mus_test_suite.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b5760aa847ce3dc92e714a134fb11c5c3548ce

commit 26b5760aa847ce3dc92e714a134fb11c5c3548ce
Author: rockot <rockot@chromium.org>
Date: Wed Jan 25 05:37:32 2017

Add service_test GN template

Adds a new GN template for unittest suites which run instances of
ServiceTest. This integrates static catalog manifest support directly
into the build rule, avoiding the need for individual test suites to
copy an output catalog and define their own one-off test runner to
load it.

BUG= 672614 

Review-Url: https://codereview.chromium.org/2653713004
Cr-Commit-Position: refs/heads/master@{#445961}

[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/components/filesystem/BUILD.gn
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/components/filesystem/DEPS
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/components/filesystem/run_all_unittests.cc
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/components/leveldb/BUILD.gn
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/components/leveldb/DEPS
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/components/leveldb/run_all_unittests.cc
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/media/mojo/services/BUILD.gn
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/media/mojo/services/DEPS
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/media/mojo/services/run_all_unittests.cc
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/catalog/public/tools/catalog.gni
[add] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/catalog/public/tools/sourcify_manifest.py
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/service_manager/public/cpp/test/BUILD.gn
[add] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/service_manager/public/cpp/test/DEPS
[rename] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/service_manager/public/cpp/test/run_all_service_tests_with_catalog.cc
[add] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/service_manager/public/cpp/test/service_test_catalog.h
[add] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/service_manager/public/tools/test/service_test.gni
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/ui/clipboard/BUILD.gn
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/services/ui/clipboard/DEPS
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/services/ui/clipboard/run_all_unittests.cc
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/ui/demo/BUILD.gn
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/ui/demo/DEPS
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/ui/ime/BUILD.gn
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/services/ui/ime/DEPS
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/services/ui/ime/run_all_unittests.cc
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/ui/ws/BUILD.gn
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/services/ui/ws/DEPS
[delete] https://crrev.com/c9a1eda3a93727b9c951c1c573d266c6fcac3145/services/ui/ws/run_all_unittests.cc
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/ui/views/mus/BUILD.gn
[modify] https://crrev.com/26b5760aa847ce3dc92e714a134fb11c5c3548ce/ui/views/mus/views_mus_test_suite.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f7b4ea0709c59fbd53c222603a19055b98cee65

commit 0f7b4ea0709c59fbd53c222603a19055b98cee65
Author: rockot <rockot@chromium.org>
Date: Fri Jan 27 05:05:45 2017

Misc service_manager and service test cleanup

BUG= 672614 
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2658063003
Cr-Commit-Position: refs/heads/master@{#446598}

[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/media/mojo/services/BUILD.gn
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/BUILD.gn
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/navigation/BUILD.gn
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/background/BUILD.gn
[delete] https://crrev.com/272601d1bc83c2e88a9939f98e22dae77a98bdb4/services/service_manager/background/background_service_manager_main.cc
[delete] https://crrev.com/272601d1bc83c2e88a9939f98e22dae77a98bdb4/services/service_manager/background/background_service_manager_main.h
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/public/cpp/test/BUILD.gn
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/public/cpp/test/DEPS
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/public/cpp/test/run_all_service_tests.cc
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/public/tools/test/service_test.gni
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/tests/BUILD.gn
[delete] https://crrev.com/272601d1bc83c2e88a9939f98e22dae77a98bdb4/services/service_manager/tests/run_all_unittests.cc
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/service_manager/tests/shutdown/BUILD.gn
[add] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/test/BUILD.gn
[rename] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/test/run_all_unittests.cc
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/ui/common/BUILD.gn
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/ui/common/run_all_service_tests.cc
[modify] https://crrev.com/0f7b4ea0709c59fbd53c222603a19055b98cee65/services/video_capture/BUILD.gn

rockot@ I believe https://codereview.chromium.org/2645973006 broke chrome --mash --window-manager=simple_wm unintentionally; it fails to start up.

Would you mind to have a look?
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ec036d053570d83cbad754e229b68e4984bed9

commit 98ec036d053570d83cbad754e229b68e4984bed9
Author: rockot <rockot@chromium.org>
Date: Fri Feb 17 01:38:33 2017

Misc. fixes to MashRunner environment

- Adds simple_wm to the chrome --mash catalog

- Allows chrome_mash to connect to anything (to support dynamic window
  manager selection without manifest updates)

- Re-lands change to make MashRunner connect to
  content_packaged_services to launch the browser, rather than
  connecting to content_browser

BUG= 672614 

Review-Url: https://codereview.chromium.org/2692853013
Cr-Commit-Position: refs/heads/master@{#451168}

[modify] https://crrev.com/98ec036d053570d83cbad754e229b68e4984bed9/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/98ec036d053570d83cbad754e229b68e4984bed9/chrome/app/mash/chrome_mash_manifest.json
[modify] https://crrev.com/98ec036d053570d83cbad754e229b68e4984bed9/chrome/app/mash/mash_runner.cc

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cadd4324682783aa817250cdf229c022086666a

commit 6cadd4324682783aa817250cdf229c022086666a
Author: rockot <rockot@chromium.org>
Date: Fri Feb 17 06:47:29 2017

service_manager: More consistent Service lifecycle API

This introduces OnStartFailed() to be invoked in lieu of OnStart()
if the Service pipe breaks before OnStart() can be invoked.

This disambiguates the meaning of OnStop(), ensuring that it will
now only be called in the event that OnStart() happened first.

BUG= 672614 
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2700693004
Cr-Commit-Position: refs/heads/master@{#451252}

[modify] https://crrev.com/6cadd4324682783aa817250cdf229c022086666a/services/service_manager/public/cpp/lib/service.cc
[modify] https://crrev.com/6cadd4324682783aa817250cdf229c022086666a/services/service_manager/public/cpp/lib/service_context.cc
[modify] https://crrev.com/6cadd4324682783aa817250cdf229c022086666a/services/service_manager/public/cpp/service.h
[modify] https://crrev.com/6cadd4324682783aa817250cdf229c022086666a/services/service_manager/public/cpp/service_context.h

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da1a75010d17285002bab1fda9ca510119c69814

commit da1a75010d17285002bab1fda9ca510119c69814
Author: cfroussios <cfroussios@chromium.org>
Date: Fri Feb 17 10:07:00 2017

Revert of service_manager: More consistent Service lifecycle API (patchset #3 id:40001 of https://codereview.chromium.org/2700693004/ )

Reason for revert:
CL is the suspected culprit of breaking ContentBrowserTest.BrowserCrashCallStack

Original issue's description:
> service_manager: More consistent Service lifecycle API
>
> This introduces OnStartFailed() to be invoked in lieu of OnStart()
> if the Service pipe breaks before OnStart() can be invoked.
>
> This disambiguates the meaning of OnStop(), ensuring that it will
> now only be called in the event that OnStart() happened first.
>
> BUG= 672614 
> R=sky@chromium.org
>
> Review-Url: https://codereview.chromium.org/2700693004
> Cr-Commit-Position: refs/heads/master@{#451252}
> Committed: https://chromium.googlesource.com/chromium/src/+/6cadd4324682783aa817250cdf229c022086666a

TBR=sky@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 672614 

Review-Url: https://codereview.chromium.org/2700123002
Cr-Commit-Position: refs/heads/master@{#451274}

[modify] https://crrev.com/da1a75010d17285002bab1fda9ca510119c69814/services/service_manager/public/cpp/lib/service.cc
[modify] https://crrev.com/da1a75010d17285002bab1fda9ca510119c69814/services/service_manager/public/cpp/lib/service_context.cc
[modify] https://crrev.com/da1a75010d17285002bab1fda9ca510119c69814/services/service_manager/public/cpp/service.h
[modify] https://crrev.com/da1a75010d17285002bab1fda9ca510119c69814/services/service_manager/public/cpp/service_context.h

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1033a629e2246612bf9c8b37b3400db53f53133e

commit 1033a629e2246612bf9c8b37b3400db53f53133e
Author: rockot <rockot@chromium.org>
Date: Sat Feb 18 11:03:43 2017

service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG= 672614 
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=xhwang@chromium.org for rename in media

Review-Url: https://codereview.chromium.org/2701883002
Cr-Commit-Position: refs/heads/master@{#451453}

[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/chrome/test/base/mash_browser_tests_main.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/content/common/service_manager/embedded_service_runner.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/content/common/service_manager/service_manager_connection_impl.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/media/mojo/services/media_service.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/media/mojo/services/media_service.h
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/image_decoder/image_decoder_service.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/image_decoder/image_decoder_service.h
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/background/tests/test_service.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/public/cpp/lib/service.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/public/cpp/lib/service_context.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/public/cpp/lib/service_runner.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/public/cpp/service.h
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/public/cpp/service_context.h
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/tests/lifecycle/app_client.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/tests/lifecycle/app_client.h
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/service_manager/tests/service_manager/embedder.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/shape_detection/shape_detection_service.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/shape_detection/shape_detection_service.h
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/tracing/service.cc
[modify] https://crrev.com/1033a629e2246612bf9c8b37b3400db53f53133e/services/tracing/service.h

Components: -Internals>ServiceManager Internals>Services>ServiceManager

Sign in to add a comment