New issue
Advanced search Search tips

Issue 672606 link

Starred by 2 users
Status: Fixed
Owner:
ericrk@chromium.org
Closed: Jan 2017
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Tile deletion should happen immediately

Project Member Reported by ericrk@chromium.org, Dec 8 2016 
Currently, TileManager holds on to tiles that have been released until the next call to PrepareTiles. This was necessary when tiles were responsible for keeping running raster tasks alive. Now that the worker pool owns raster tasks, we can likely simplify the tile cleanup code and release tiles immediately (rather than keeping a pending deletion list around).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5410705426f111d9ea78d121b70cb87ddf38187

commit e5410705426f111d9ea78d121b70cb87ddf38187
Author: ericrk <ericrk@chromium.org>
Date: Tue Jan 10 21:00:07 2017

Clean up tile deletion

Now that raster task lifetime has been cleaned up, we no longer need to
keep tiles alive during raster task execution. This change causes tiles
to be cleaned up immediately upon being released.

R=vmpstr
BUG= 672606 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2612413003
Cr-Commit-Position: refs/heads/master@{#442682}

[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/debug/rasterize_and_record_benchmark_impl.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/layers/picture_layer_impl.h
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/test/fake_picture_layer_tiling_client.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/test/fake_picture_layer_tiling_client.h
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/test/fake_tile_manager.h
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/picture_layer_tiling.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/picture_layer_tiling.h
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/tile.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/tile.h
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/tile_manager.cc
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/tile_manager.h
[modify] https://crrev.com/e5410705426f111d9ea78d121b70cb87ddf38187/cc/tiles/tile_manager_perftest.cc

Comment 2 by ericrk@chromium.org, Jan 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment