mash: Shelf items for panel windows aren't right-aligned. |
||||||||||
Issue descriptionmash: Shelf items for panel windows aren't right-aligned. On ToT @ #437019 having built 'chrome' and 'mash:all': (1) Run chrome --mash (2) Install the attached PanelTest extension; (extract, about:extensions, developer mode, load unpacked) (3) Open a panel window from the app. Expected: The corresponding shelf item is right-aligned. Actual: The corresponding shelf item is intermixed with others on the left.
,
Jan 17 2017
This is blocked on: (1) Issue 679028 (we do not set the ash shelf item type on app [panel] windows) (2) Issue 681233 (ash properties set by chrome are not transported to ash)
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f49f1ae7c8896402177da53ff27d53be29fcca5c commit f49f1ae7c8896402177da53ff27d53be29fcca5c Author: msw <msw@chromium.org> Date: Mon Jan 30 18:08:25 2017 mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes. Revert the ChromeNativeAppWindowViewsAura workaround. Initialize the views::Widget::InitParams::mus_properties for mash. (set the correct container, display id, and shelf item type) Use ChromeNativeAppWindowViews's NonClientFrameView for panels too. (ash::CustomFrameViewAsh and ash::PanelFrameView are still broken in mash) BUG= 679028 , 672599 TEST=chrome --mash panel windows are right-aligned. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2665523002 Cr-Commit-Position: refs/heads/master@{#447014} [modify] https://crrev.com/f49f1ae7c8896402177da53ff27d53be29fcca5c/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc [modify] https://crrev.com/f49f1ae7c8896402177da53ff27d53be29fcca5c/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
,
Jan 30 2017
,
Mar 29 2017
,
Apr 17 2017
,
May 11 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by msw@chromium.org
, Jan 13 2017