Issue metadata
Sign in to add a comment
|
Flaky gn runs with use_goma |
||||||||||||||||||||||||
Issue descriptionTwo independent occurrences of a flaky gn error: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/5872 https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/4734 I reran the build of the first right after it happened and the build turned green. I have no idea how to reproduce this yet. Error: /mnt/data/b/build/slave/V8_Arm_-_debug_builder/build/v8/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at build arg file (use "gn args <out_dir>" to edit):6:12: Build argument has no effect. use_goma = true ^--- The variable "use_goma" was set as a build argument but never appeared in a declare_args() block in any buildfile.
,
Dec 8 2016
I don't know. At least in Chrome it should be impossible to not get goma.gni referenced. But I have no familiarity of how this bot is configured.
,
Dec 8 2016
It's a standard v8 checkout (`fetch v8`), I think, so it's DEPS'ing in //build as you'd expect.
,
Dec 8 2016
goma.gni is included by build/config which everything uses. Something else weird is going on.
,
Dec 8 2016
True, that too. Can you try to figure out what the weird thing going on is?
,
Dec 9 2016
This has certainly low prio for us. Reported it more for bookkeeping. I don't know of any other occurrence than these two. Maybe something purged the file on sync and on the rerun it came back?
,
Jan 3 2017
FYI: Happened here again: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/5071
,
Jan 3 2017
Hmm. Can you confirm that the gn binary being picked up in that config is version 439366 (from `gn --version`)?
,
Jan 4 2017
Would need to log on the bot. Can do that after vacation. Otherwise I can only deduce from the logs. Runhooks says "File v8/buildtools/linux64/gn exists and SHA1 matches." buildtools is version https://chromium.googlesource.com/chromium/buildtools.git/+/0ef801087682b271e9ace93cfa93e9d3dea98079 - which seems up-to-date. Remains to assume that https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/5071/steps/generate_build_files/logs/stdio indeed uses the gn that was downloaded.
,
Jan 4 2017
I assume this is duplicate to issue 674213 which also started to flake again. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dpranke@chromium.org
, Dec 8 2016Labels: -Pri-3 OS-All Pri-2
Owner: brettw@chromium.org
Status: Assigned (was: Untriaged)
Huh. I don't know why you'd get that error. From looking at the logs, the GN args are: arm_float_abi = "hard" goma_dir = "/mnt/data/b/build/slave/cache/cipd/goma" is_component_build = false is_debug = false target_cpu = "arm" use_goma = true v8_test_isolation_mode = "prepare" From this, I'd expect the default toolchain to be //build/toolchain/linux:clang_arm which should import("//build/toolchain/gcc_toolchain.gni") which should import("//build/toolchain/goma.gni") which should contain the declare'd arg. Brett, do you see anything I don't see?