New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672593 link

Starred by 3 users
Status: Fixed
Owner:
jianli@chromium.org
Closed: Dec 2016
Cc:
█ dim...@chromium.org
█ talo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Don't show 'download page later' if page has 'reload'

Project Member Reported by talo@chromium.org, Dec 8 2016 
Chrome Version: 56

Observed behavior: If a user is on an error page where they can reload the page, we still show the 'download page later' option.

Expected result: We should only show the"Download page later" link on error pages where the user doesn't have a prevalent reload action.

Screenshot attached!
Screenshot_20161206-151609.png
116 KB View Download

Comment 1 by talo@chromium.org, Dec 8 2016

Labels: -Pri-3 Pri-1

Comment 2 by dim...@chromium.org, Dec 9 2016

Cc: -jianli@chromium.org dim...@chromium.org
Owner: jianli@chromium.org
Status: Started (was: Untriaged)
jianli@ is working on it.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97430eb75aa5d976e9c02c2cf5ca4caf7d13513d

commit 97430eb75aa5d976e9c02c2cf5ca4caf7d13513d
Author: jianli <jianli@chromium.org>
Date: Sat Dec 10 03:52:47 2016

Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown

BUG= 672593 

Review-Url: https://codereview.chromium.org/2560823005
Cr-Commit-Position: refs/heads/master@{#437743}

[modify] https://crrev.com/97430eb75aa5d976e9c02c2cf5ca4caf7d13513d/components/error_page/common/localized_error.cc

Comment 4 by dim...@chromium.org, Dec 12 2016

Labels: Merge-Request-56

Comment 5 by dimu@chromium.org, Dec 12 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bf308b154f6ea2fb4f234fc4d4654d42738be82

commit 2bf308b154f6ea2fb4f234fc4d4654d42738be82
Author: Jian Li <jianli@chromium.org>
Date: Mon Dec 12 21:59:34 2016

Merge to M56: Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown

BUG= 672593 

Review-Url: https://codereview.chromium.org/2560823005
Cr-Commit-Position: refs/heads/master@{#437743}
(cherry picked from commit 97430eb75aa5d976e9c02c2cf5ca4caf7d13513d)

Review-Url: https://codereview.chromium.org/2574573002 .
Cr-Commit-Position: refs/branch-heads/2924@{#469}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/2bf308b154f6ea2fb4f234fc4d4654d42738be82/components/error_page/common/localized_error.cc

Comment 7 by jianli@chromium.org, Dec 12 2016

Status: Fixed (was: Started)

Comment 8 by jianli@chromium.org, Jan 12 2017 

Issue 667841 has been merged into this issue.
►

Sign in to add a comment