New issue
Advanced search Search tips

Issue 672585 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 641355
issue 681563

Blocking:
issue 548407



Sign in to add a comment

IME for Mus: Implement InputMethodMus

Project Member Reported by moshayedi@chromium.org, Dec 8 2016

Issue description

This is an umbrella bug for missing parts of InputMethodMus.
 
Blocking: 548407
Blockedon: 641355
Blockedon: 637418
Blockedon: 681563

Comment 5 by sky@chromium.org, Jul 24 2017

Owner: e...@chromium.org

Comment 6 by e...@chromium.org, Sep 12 2017

Owner: thanhph@chromium.org
More IME bugs.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27b7317d4d4a457a51d589efcf2f79797071c66

commit c27b7317d4d4a457a51d589efcf2f79797071c66
Author: Jani Hautakangas <jani.hautakangas@lge.com>
Date: Tue Nov 28 07:56:40 2017

IME for Mus: Do not forward calls from unfocused text input client

In some cases calls to IME can come from unfocused client.
MUS IME as has a remote text input client which is set focused
when IME session is started. If a call from unfocused client
comes after IME session has been started then that call on
IME service side is interpreted to originate from currently
focused client which is wrong and can cause unwanted states.

Example use case where things go wrong is
Embedded Search API searchbox on NTP.

1. Open Chrome browser
2. On Chrome's initial google page click searcbox
3. Type something on IME or on keyboard
4. Focus switches to addressbar omnibox and TEXT_INPUT_TYPE_NONE
   is sent to IME from unfocused client.
5. IME running on IME service side interprets this TEXT_INPUT_TYPE_NONE
   to come from currently focused remote text input client.

Bug:  672585 
Change-Id: Ib5f5e6f73594580cb59fe966b52cbe5efb37ea79
Reviewed-on: https://chromium-review.googlesource.com/786232
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519601}
[modify] https://crrev.com/c27b7317d4d4a457a51d589efcf2f79797071c66/ui/aura/mus/input_method_mus.cc
[modify] https://crrev.com/c27b7317d4d4a457a51d589efcf2f79797071c66/ui/aura/mus/input_method_mus_unittest.cc
[modify] https://crrev.com/c27b7317d4d4a457a51d589efcf2f79797071c66/ui/aura/test/mus/input_method_mus_test_api.h

Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Owner: xiy...@chromium.org
Blockedon: -637418
Status: Fixed (was: Assigned)
Issue 637418 is about whether InputMethodMus should handle OnInputLocaleChanged(). OnInputLocaleChanged() not used in chromeos. Thus not relevant to mash, IMO. Removing it as blocker and close this bug.

Sign in to add a comment