New issue
Advanced search Search tips
Starred by 5 users
Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 563816
issue 670975



Sign in to add a comment
createImageBitmap should take OffscreenCanvas as a source
Project Member Reported by xidac...@chromium.org, Dec 8 2016 Back to list
This is speced here:
https://html.spec.whatwg.org/multipage/webappapis.html#imagebitmapsource

ImageBitmapSource contains CanvasImageSource which contains OffscreenCanvas. We should implement this path.
 
Blocking: 670975
Comment 2 by junov@chromium.org, Dec 8 2016
Blocking: 563816
Project Member Comment 3 by bugdroid1@chromium.org, Dec 14 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145

commit fc5d49e3a636ea62c25c512c9ac4295cf0ad5145
Author: junov <junov@chromium.org>
Date: Wed Dec 14 20:52:44 2016

Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG= 672571 
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2570613002
Cr-Commit-Position: refs/heads/master@{#438617}

[add] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-ImageBitmapSource.html
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt
[add] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/LayoutTests/http/tests/security/offscreencanvas-read-blocked-no-crossorigin.html
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/frame/ImageBitmap.h
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h

Comment 4 by junov@chromium.org, Dec 14 2016
Status: Fixed
Sign in to add a comment