New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672570 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 678206



Sign in to add a comment

http/tests/media/autoplay-crossorigin.html failing on Site Isolation Linux FYI bot

Project Member Reported by creis@chromium.org, Dec 8 2016

Issue description

The http/tests/media/autoplay-crossorigin.html layout test added in https://codereview.chromium.org/2496593002 is failing on the Site Isolation Linux FYI bot:

https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/12852

This bot runs the tests with --site-per-process.  zqzhang@, can you take a look?  (Looks like this was for  issue 665456 .)


Example output:

10:46:21.111 3871 worker/0 http/tests/media/autoplay-crossorigin.html started
10:46:27.118 3871 killed pid 4344
10:46:27.119 3871 worker/0 http/tests/media/autoplay-crossorigin.html output stderr lines:
10:46:27.119 3871   [4344:4344:1208/104621.231544:4481036539:WARNING:render_frame_host_impl.cc(2126)] OnDidStopLoading was called twice.
10:46:27.120 3804 [3511/3824] http/tests/media/autoplay-crossorigin.html failed unexpectedly (test timed out)
10:46:27.119 3871 worker/0 killing primary driver
10:46:27.120 3871 worker/0 killing secondary driver
10:46:27.120 3871 worker/0 http/tests/media/autoplay-crossorigin.html failed:
10:46:27.120 3871 worker/0  test timed out
 

Comment 1 by creis@chromium.org, Dec 9 2016

The test was disabled on that bot in r437324, but let's try to get it working there soon.  (This could indicate a bug for out-of-process iframes in general.)  Thanks!
Labels: -Pri-1 Pri-2
mlamouri@ and I witnessed several other autoplay-related issues when site-isolation is on.

On latest Chrome Dev Linux, our manual test page should have all four pages autoplaying when loaded:
http://mounirlamouri.github.io/sandbox/autoplay/test.html

However what I observed is that the fourth video does not play automatically.

There may be some more general issue with media element when site isolation is enabled (maybe some kind of throttling?). Will look into this when we have time.
Some more words:

* Sometimes manually starting the fourth video won't even work, but it might start autoplaying at some time eventually.
* Deleting all other video/iframes in the manual test page can make the fourth video start.

Comment 4 by creis@chromium.org, Dec 9 2016

Cc: creis@chromium.org
Components: Internals>Sandbox>SiteIsolation
Thanks for taking a look!  Do you think those are separate issues from this failing test (and thus we should file another bug for fixing autoplay for OOPIFs), or will fixing that get this test to pass?
Blockedon: 678206
Sorry for the late reply. I think it's a more general issue with site isolation and autoplay. The test failure is probably due to this. I filed another bug for it.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1b91cd87f42a0eff0b0037fd8e65960b6d52866

commit b1b91cd87f42a0eff0b0037fd8e65960b6d52866
Author: alexmos <alexmos@chromium.org>
Date: Thu Jan 12 18:34:16 2017

Disable virtual/mojo-loading/.../autoplay-crossorigin.html on Site Isolation bots.

This variant of the test runs on Site Isolation Win in addition to the
regular test, hence it also needs to be disabled.

BUG= 672570 
NOTRY=true
TBR=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2633513002
Cr-Commit-Position: refs/heads/master@{#443297}

[modify] https://crrev.com/b1b91cd87f42a0eff0b0037fd8e65960b6d52866/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Cc: zqzh...@chromium.org
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
This should be fixed now. I'm sending a CL to re-enable the tests.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f63ffe6124b29e9df06c93b657e71b56a0ef619

commit 3f63ffe6124b29e9df06c93b657e71b56a0ef619
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Feb 07 17:26:51 2017

Site-per-process: re-enable autoplay tests that were broken by loading issue.

The root bug (ie.  bug 678206 ) has been fixed. We should now be able to
re-enable these tests.

BUG= 672570 
R=csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2685603002
Cr-Commit-Position: refs/heads/master@{#448653}

[modify] https://crrev.com/3f63ffe6124b29e9df06c93b657e71b56a0ef619/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Status: Fixed (was: Started)

Sign in to add a comment