New issue
Advanced search Search tips

Issue 672539 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

media-document-with-download-button.html fails on ToT

Project Member Reported by avayvod@chromium.org, Dec 8 2016

Issue description

I'm at the revision 2f33b96e97d5049370f337b25cda6626ad097474
The test fails with the scrubber being better aligned at the beginning of the bar now vs the expectation of it being a bit off (see the diff screenshot and the attached zip file with test results).
Perhaps it's the test expectation that needs to be updated.

The test is here: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/media-document-with-download-button.html
 
layout-test-results.zip
37.0 KB Download
media-document-with-download-button-diff.png
9.2 KB View Download
Cc: -qin...@chromium.org
Owner: qin...@chromium.org
avayvod@, I assume this is new? I'm surprised it wasn't caught by CQ.
qinmin@, can you PTAL?
qinmin@, do you intend to address this?
I think we can remove the test now, also the media download button code. The download button is already integrated with the media controller.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2

commit 9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2
Author: Min Qin <qinmin@chromium.org>
Date: Tue Aug 22 23:13:48 2017

Remove download button on MediaDocument

The media download button is now integrated into the media controller.
There is no need for a standalone button

BUG=672539

Change-Id: I562002197f01d9c75869824f1d1bf1c4c2d0227b
Reviewed-on: https://chromium-review.googlesource.com/611325
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496494}
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/chrome/browser/about_flags.cc
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/content/app/strings/content_strings.grd
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/content/child/blink_platform_impl.cc
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/content/child/runtime_features.cc
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/content/public/common/content_features.cc
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/content/public/common/content_features.h
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/7f0e229fb317da182573209639c32529755dd1f5/third_party/WebKit/LayoutTests/media/media-document-audio-repaint.html
[delete] https://crrev.com/7f0e229fb317da182573209639c32529755dd1f5/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/README.txt
[delete] https://crrev.com/7f0e229fb317da182573209639c32529755dd1f5/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/media-document-with-download-button-expected.html
[delete] https://crrev.com/7f0e229fb317da182573209639c32529755dd1f5/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/media-document-with-download-button.html
[delete] https://crrev.com/7f0e229fb317da182573209639c32529755dd1f5/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/resources/standalone-audio.html
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/Source/core/html/media/MediaDocument.cpp
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/public/platform/WebLocalizedString.h
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/9a9a3dc7cef94d76f4d81bc1158b058f5ada26a2/tools/metrics/histograms/histograms.xml

qinmin@, I assume this is now fixed?
There is a regression.

Steps to reproduce:
- Go to https://storage.googleapis.com/media-session/caminandes/short.mp4
- Video element should be centered vertically and horizontally (Chrome Stable does that)

What happens instead:
Video element is placed at the top left corner of the page.

Please let's fix this!

It looks like it is as simple as simply reverting the <div> element.
And worst, if you go to https://storage.googleapis.com/media-session/sintel/snow-fight.mp3, there's no element displayed anymore ;(
Status: Assigned (was: Available)

Sign in to add a comment