DEPS roller accounts need +2 rights |
||||||||||
Issue descriptionThe following DEPS roller accounts need to be able to codereview +1 and CQ +2 their own changes: skia-deps-roller@chromium.org nacl-deps-roller@chromium.org pdfium-deps-roller@chromium.org catapult-deps-roller@chromium.org
,
Dec 8 2016
,
Dec 8 2016
,
Dec 8 2016
,
Dec 12 2016
,
Dec 19 2016
Friendly ping. I assume this has something to do with permissions not getting carried over from Rietveld?
,
Dec 19 2016
In Skia, you can change this yourself, and Chromium isn't yet ready, so which project(s) do you have in mind?
,
Dec 19 2016
This is for Chromium. I didn't realize that Chromium wasn't ready yet, so I guess this is blocked on that.
,
Dec 19 2016
Eric was getting things ready so that he can flip a switch when Gerrit is supported in Chromium. What is not ready in Chromium right now? I know the CQ does not look at Chromium Gerrit CLs but you can still create a Gerrit CL, is that right? are the ACL issues tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=617952 ?
,
Dec 19 2016
You can create a gerrit CL for chromium if you really want to, but the review labels aren't set up correctly, even if they were the right people won't be able to set them, the submit button doesn't work, and the CQ will ignore the change entirely. This will all be changing in early january. All of these accounts are already listed in committers@chromium.org, so when issue chromium:617952 is resolved, they will automatically have all the appropriate permissions in chromium/src.git.
,
Dec 19 2016
SGTM, thanks.
,
Jan 11 2017
,
Jan 12 2017
,
Jan 17 2017
the "chromium-committers" gerrit group now includes "cria/external/project-chromium-committers", which includes these DEPS roller accounts. This should be resolved; please verify.
,
Jan 24 2017
I'm getting this error uploading a CL as skia-deps-roller@chromium.org locally: gerrit_util.GerritError: Forbidden: Applying label "Commit-Queue": 2 is restricted Since the label is applied after creating the issue, I can link to the issue: https://chromium-review.googlesource.com/c/431736/ Note that in the issue above, the "R=" line used to be "TBR=", but the CL is rejected if I do that, eg. https://paste.googleplex.com/4907100413100032 As far as I can tell, skia-deps-roller@chromium.org still does not have permission to +1 and +2 its own changes.
,
Jan 24 2017
Yes, that is expected. The necessary permissions changes (e.g. granting chromium-committers CR+1 access) haven't been made to chromium/src.git yet, because it is not ready for dogfood yet. I marked this bug as fixed because, when chromium/src is ready, no additional changes will be necessary for those accounts to have codereview/cq/commit/submit permissions. I guess I totally said the wrong thing when I asked you to verify; I meant that someone should verify that the accounts are in the appropriate groups, not that they already have permissions on the chromium/src repo itself. I'll be verifying that when I open it up for dogfood usage.
,
Jan 25 2017
Acknowledged, thanks. Can you please point me to the tracking bug so that I can stay up to date?
,
Jan 25 2017
Yep! Tracking bug for chromium is https://bugs.chromium.org/p/chromium/issues/detail?id=685321 You'll see that bug be updated, as well as big PSAs go out to the lists mentioned in that bug, when I set up all the ACLs. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by rmis...@google.com
, Dec 8 2016