New issue
Advanced search Search tips

Issue 672527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Upcoming Skia ImageFilter change will require pixel test suppression

Project Member Reported by robertphillips@chromium.org, Dec 8 2016

Issue description


https://skia-review.googlesource.com/c/5669/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) has and will once more alter the following GPU pixel test:

Pixel_CSSFilterEffects


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5

commit 2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5
Author: robertphillips <robertphillips@google.com>
Date: Fri Dec 09 14:10:23 2016

Add suppression for GPU Pixel test in preparation for Skia CL

BUG= 672527 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2559213002
Cr-Commit-Position: refs/heads/master@{#437530}

[modify] https://crrev.com/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5

commit 2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5
Author: robertphillips <robertphillips@google.com>
Date: Fri Dec 09 14:10:23 2016

Add suppression for GPU Pixel test in preparation for Skia CL

BUG= 672527 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2559213002
Cr-Commit-Position: refs/heads/master@{#437530}

[modify] https://crrev.com/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d872ec11e50775048976b2d7f146856fc66e3bd6

commit d872ec11e50775048976b2d7f146856fc66e3bd6
Author: robertphillips <robertphillips@google.com>
Date: Fri Dec 16 20:55:36 2016

Suppress Pixel_CSSFilterEffects_NoOverlays pixel test

BUG= 672527 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2583493002
Cr-Commit-Position: refs/heads/master@{#439185}

[modify] https://crrev.com/d872ec11e50775048976b2d7f146856fc66e3bd6/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b437a09592f573bf1268f6627c3057d16150a2b

commit 6b437a09592f573bf1268f6627c3057d16150a2b
Author: robertphillips <robertphillips@google.com>
Date: Mon Dec 19 14:46:04 2016

Bump CSSFilterEffects pixel test revision number to force rebaseline

This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL)

The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016.

BUG= 672527 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573803002
Cr-Commit-Position: refs/heads/master@{#439472}

[modify] https://crrev.com/6b437a09592f573bf1268f6627c3057d16150a2b/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e0ae38ac6701d6936525652606f499d46d86ff

commit 05e0ae38ac6701d6936525652606f499d46d86ff
Author: robertphillips <robertphillips@google.com>
Date: Tue Dec 20 14:15:23 2016

Remove pixel test suppressions now that they've been rebaselined

The rebaseline request was landed in https://codereview.chromium.org/2573803002/ (Bump CSSFilterEffects pixel test revision number to force rebaseline)

BUG= 672527 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588793002
Cr-Commit-Position: refs/heads/master@{#439794}

[modify] https://crrev.com/05e0ae38ac6701d6936525652606f499d46d86ff/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Fixed (was: Assigned)
I think the pixel test rebaselines are complete

Sign in to add a comment