New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672526 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add metrics for autoplay muted in cross-origin iframes

Project Member Reported by zqzh...@chromium.org, Dec 8 2016

Issue description

Moving this bug out from the implementation
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d054c278da7a25db1c4646bd7e61dcb5f051bceb

commit d054c278da7a25db1c4646bd7e61dcb5f051bceb
Author: zqzhang <zqzhang@chromium.org>
Date: Fri Dec 09 23:18:59 2016

Adding Rappor metrics for disabling cross-origin autoplay with sound experiment

This CL adds Rappor metrics to collect data for the cross-origin
autoplay experiment. It records the ETLD+1 of top-level frame and
iframes when a video is allowed to/blocked to autoplay and also
when the user has manually started a blocked video.

BUG= 672526 

Review-Url: https://codereview.chromium.org/2524443002
Cr-Commit-Position: refs/heads/master@{#437682}

[modify] https://crrev.com/d054c278da7a25db1c4646bd7e61dcb5f051bceb/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[modify] https://crrev.com/d054c278da7a25db1c4646bd7e61dcb5f051bceb/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/d054c278da7a25db1c4646bd7e61dcb5f051bceb/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/d054c278da7a25db1c4646bd7e61dcb5f051bceb/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/d054c278da7a25db1c4646bd7e61dcb5f051bceb/tools/metrics/rappor/rappor.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdef306f2a6fbeea064ae552d063e4cee85dc5ec

commit bdef306f2a6fbeea064ae552d063e4cee85dc5ec
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Dec 13 01:21:57 2016

[Autoplay] Add more rappor metrics for autoplay in cross-origin iframes

This CL adds rappor metrics for recording the eTLD+1 of the top-level
frame and cross-origin iframe when the user pauses an autoplaying video.

BUG= 672526 

Review-Url: https://codereview.chromium.org/2563723002
Cr-Commit-Position: refs/heads/master@{#437976}

[modify] https://crrev.com/bdef306f2a6fbeea064ae552d063e4cee85dc5ec/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[modify] https://crrev.com/bdef306f2a6fbeea064ae552d063e4cee85dc5ec/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/bdef306f2a6fbeea064ae552d063e4cee85dc5ec/tools/metrics/rappor/rappor.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f5262dd77fa3e767d9179123ac774dbf0d4d9ac

commit 6f5262dd77fa3e767d9179123ac774dbf0d4d9ac
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Dec 13 18:05:22 2016

[Autoplay] Add histogram metrics for cross-origin autoplay muted experiment

We have already landed rappor metrics for cross-origin autoplay muted
experiment, we should land corresponding histogram metrics as well.

BUG= 672526 

Review-Url: https://codereview.chromium.org/2576463002
Cr-Commit-Position: refs/heads/master@{#438222}

[modify] https://crrev.com/6f5262dd77fa3e767d9179123ac774dbf0d4d9ac/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[modify] https://crrev.com/6f5262dd77fa3e767d9179123ac774dbf0d4d9ac/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/6f5262dd77fa3e767d9179123ac774dbf0d4d9ac/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment