Regression: Omnibox textfield is overlapping the Omnibox Focus Ring on the right side |
|||||||
Issue descriptionChrome Version: Chrome Canary 57.0.2945.3 OS: 10.12.1 What steps will reproduce the problem? (1) Type something into the Omnibox. (2) Take a look at the focus ring on the right side. What is the expected result? What happens instead? The Omnibox textfield is overlapping the Omnibox Focus Ring on the right side. Please use labels and text to provide additional information. A screenshot is attached. Thanks. Mehmet
,
Dec 8 2016
,
Dec 8 2016
,
Dec 9 2016
Hi shrike@: Thanks for looking into this issue. Just only one question: Will your patch also fix issue 596695 , which is similar to this one? Thanks!
,
Dec 9 2016
Hi mehmet@ - yes, it does look like this fix will also take care of Issue 596695 . Thanks for remembering it!
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c commit 55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c Author: shrike <shrike@chromium.org> Date: Fri Dec 09 18:46:57 2016 [Mac] Prevent omnibox text bg from drawing over decoration, focus ring. The AutocompleteTextFieldEditor draws a background, apparently even when you call setDrawsBackground:NO (at least during editing). Because of the 1pt spacing set by UX between the security decoration border and the start of omnibox text, this background started drawing into the decoration's hover rect. On the right edge it drew into the edge of the focus ring. This cl prevents the AutocompleteTetFieldEditor from drawing a background, relying instead on the background drawn by the textfield's cell. It also changes decorations to be drawn after the cell's interior, to prevent the background overlap when not editing. R=avi@chromium.org BUG= 669870 , 672518 Review-Url: https://codereview.chromium.org/2562863002 Cr-Commit-Position: refs/heads/master@{#437596} [modify] https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c commit 55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c Author: shrike <shrike@chromium.org> Date: Fri Dec 09 18:46:57 2016 [Mac] Prevent omnibox text bg from drawing over decoration, focus ring. The AutocompleteTextFieldEditor draws a background, apparently even when you call setDrawsBackground:NO (at least during editing). Because of the 1pt spacing set by UX between the security decoration border and the start of omnibox text, this background started drawing into the decoration's hover rect. On the right edge it drew into the edge of the focus ring. This cl prevents the AutocompleteTetFieldEditor from drawing a background, relying instead on the background drawn by the textfield's cell. It also changes decorations to be drawn after the cell's interior, to prevent the background overlap when not editing. R=avi@chromium.org BUG= 669870 , 672518 Review-Url: https://codereview.chromium.org/2562863002 Cr-Commit-Position: refs/heads/master@{#437596} [modify] https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
,
Dec 9 2016
Great. Thank you :-)
,
Dec 9 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb61cdb18135ca7d69f2431a2af15ccced4b4e1b commit bb61cdb18135ca7d69f2431a2af15ccced4b4e1b Author: Jayson Adams <shrike@chromium.org> Date: Wed Jan 04 00:26:56 2017 [Mac] Prevent omnibox text bg from drawing over decoration, focus ring. The AutocompleteTextFieldEditor draws a background, apparently even when you call setDrawsBackground:NO (at least during editing). Because of the 1pt spacing set by UX between the security decoration border and the start of omnibox text, this background started drawing into the decoration's hover rect. On the right edge it drew into the edge of the focus ring. This cl prevents the AutocompleteTetFieldEditor from drawing a background, relying instead on the background drawn by the textfield's cell. It also changes decorations to be drawn after the cell's interior, to prevent the background overlap when not editing. R=avi@chromium.org BUG= 669870 , 672518 Review-Url: https://codereview.chromium.org/2562863002 Cr-Commit-Position: refs/heads/master@{#437596} (cherry picked from commit 55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c) Review-Url: https://codereview.chromium.org/2610033003 . Cr-Commit-Position: refs/branch-heads/2924@{#662} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/bb61cdb18135ca7d69f2431a2af15ccced4b4e1b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/bb61cdb18135ca7d69f2431a2af15ccced4b4e1b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
,
Jan 4 2017
Tested the issue on Mac 10.12.2 using chrome latest beta #56.0.2924.51 by following steps mentioned in original comment.Observed that omni box right side focus ring is displaying as expected.Hence adding TE-Verified label. Thank you!
,
Jan 4 2017
please find the screen shot for reference.
,
Jan 13 2017
Hi shrike@: I think this issue is also fixed. Do you want to change the status to fixed?
,
Jan 15 2017
Thank you. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shrike@chromium.org
, Dec 8 2016