New issue
Advanced search Search tips

Issue 672515 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 654140
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Javascript can be used to prevent a user to exit fullscreen

Reported by runem...@gmail.com, Dec 8 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

Steps to reproduce the problem:
1. Download the example file attached (or go to a website which uses this trick to scare users, for example: http://qrb37.voluumtrk1ng.com/a195fa41-e127-489f-a439-4c26a1d4/?subid=&pubfeed=70377 )
2. Click anywhere on the page
3. Try to exit fullscreen by pressing esc

What is the expected behavior?

What went wrong?
A webpage can use "document.addEventListener('keyup', event => document.documentElement.webkitRequestFullscreen());" to prevent a user to exit full screen by making the page fullscreen again as soon as they let go of the esc key. The only way to get out of such a page is to hold down esc and close the page at the same time (but maybe that too might be blocked using keydown?).

A solution would be either to block webkitRequestFullscreen from being called from inside an esc key event, or not send any event at all when esc is pressed to exit fullscreen.

Did this work before? N/A 

Chrome version: 54.0.2840.99  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 

Comment 1 by runem...@gmail.com, Dec 8 2016

example.html
409 bytes View Download
Labels: M-57
Cc: jmukthavaram@chromium.org
Components: Blink>Fullscreen
Labels: -Type-Bug -Pri-2 hasbisect-per-rivision Pri-1 Type-Bug-Regression
Owner: foolip@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows Chrome stable -55.0.2883.87.Working fine in latest Canary-57.0.2950.0,beta-56.0.2924.21,Dev-56.0.2924.18.

Seems the issue got fixed on later versions. Worked on reverse bisect (per revision)and below is the information.Issue not seen on Mac & Linux.

Bisect Tool Info:
----------------
first Good build:56.0.2915.0--Revision--431137
last Bad build:56.0.2914.0 --Revision--430837

You are probably looking for a change made after 430938 (known good), but no later than 430939 (first known bad).

CHANGELOG URL:
------------
The script might not always return single CL as suspectas some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/3fbe4d26c6c6920babf2a83b3741b4e94ce689ba..35d322e24f91a372ecdc0b152891e0635187a07e

suspect:
-------
https://chromium.googlesource.com/chromium/src/+/35d322e24f91a372ecdc0b152891e0635187a07e

Review-Url:
------------
 https://codereview.chromium.org/2482853002

foolip@ Please reassign if this is not related to your change.

Thank you.


Comment 4 by foolip@chromium.org, Dec 14 2016

Mergedinto: 654140
Status: Duplicate (was: Assigned)
I can confirm, https://codereview.chromium.org/2482853002 was a fix for precisely this problem.

Sign in to add a comment