New issue
Advanced search Search tips

Issue 672510 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 672503



Sign in to add a comment

Remove includes of property releaser in iOS headers

Project Member Reported by stkhapugin@chromium.org, Dec 8 2016

Issue description

Remove all includes of objc_property_releaser.h from headers so that they can be included from ARC. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1a2ae57448c3acd0d0b1ffe19208f20f4dcf906a

commit 1a2ae57448c3acd0d0b1ffe19208f20f4dcf906a
Author: stkhapugin <stkhapugin@google.com>
Date: Fri Dec 09 13:40:54 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1a2ae57448c3acd0d0b1ffe19208f20f4dcf906a

commit 1a2ae57448c3acd0d0b1ffe19208f20f4dcf906a
Author: stkhapugin <stkhapugin@google.com>
Date: Fri Dec 09 13:40:54 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f24b74e5e89616e42139a4e58d72848659caa1a

commit 6f24b74e5e89616e42139a4e58d72848659caa1a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Dec 09 17:28:19 2016

Moves include of objc_property_releaser out of a header.

Moves include of ojbc_property_releaser to the implementation file to
allow this to be included from ARC code.
Also moves ivars to the implementation file, per style guide.

BUG= 672510 
TEST=None

Review-Url: https://codereview.chromium.org/2561133002
Cr-Commit-Position: refs/heads/master@{#437575}

[modify] https://crrev.com/6f24b74e5e89616e42139a4e58d72848659caa1a/ios/chrome/browser/snapshots/snapshot_cache.h
[modify] https://crrev.com/6f24b74e5e89616e42139a4e58d72848659caa1a/ios/chrome/browser/snapshots/snapshot_cache.mm
[modify] https://crrev.com/6f24b74e5e89616e42139a4e58d72848659caa1a/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm

Status: Verified (was: Assigned)

Sign in to add a comment