New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672508 link

Starred by 10 users
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Feb 2017
Cc:
e...@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Implement CSS `display: flow-root` (modern clearfix)

Reported by mtana...@yandex.ru, Dec 8 2016 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

Steps to reproduce the problem:
`display: flow-root` is a modern way to force a block to be a formatting context that floated elements are contained in (aka clearfix).

From the spec [1]:

> The element generates a block container box, and lays out its contents using flow layout. It always establishes a new block formatting context for its contents.

Tab Atkins and Elika Etemad (fantasai) from CSSWG consider the feature stable enough to be implemented [2].

[1] https://drafts.csswg.org/css-display-3/#valdef-display-flow-root
[2] https://discourse.wicg.io/t/1835/6

What is the expected behavior?

What went wrong?
The feature is not implemented.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

Comment 1 by samli@chromium.org, Dec 11 2016

Labels: -Type-Bug Type-Feature
Status: Untriaged (was: Unconfirmed)

Comment 2 by samli@chromium.org, Dec 11 2016

Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Comment 4 by robhogan@chromium.org, Jan 8 2017

Cc: e...@chromium.org
Owner: robhogan@chromium.org
Status: Assigned (was: Available)
I'll take this.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f

commit 0010b369bbcf9235abd54ba181ef07b0cf6b7d6f
Author: robhogan <robhogan@gmail.com>
Date: Sat Jan 21 02:59:11 2017

Implement display:flow-root

display:flow-root generates a block container box, and lays out its contents using
flow layout. It always establishes a new block formatting context for its contents.

Intent to implement issued at:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/k9WOAVA5Ewc

Test=display-flow-root-001.html taken from the Mozilla test-suite

https://www.chromestatus.com/features/5769454877147136

TBR=pfeldman@chromium.org
BUG= 672508 

Review-Url: https://codereview.chromium.org/2620623002
Cr-Commit-Position: refs/heads/master@{#445258}

[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001-expected.html
[add] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001.html
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/LayoutTests/inspector/sources/autocomplete-css-expected.txt
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b709759f51db1a4d86c0fef25a3301c7a9f4e44e

commit b709759f51db1a4d86c0fef25a3301c7a9f4e44e
Author: rego <rego@igalia.com>
Date: Fri Jan 27 18:40:25 2017

Remove duplicated "display: flow-root" test

The test for "display: flow-root" has been upstreamed
into W3C csswg-test repository.

With the last import of csswg-test in r446595
the test is now duplicated.

This patch removes it from fast/block/float/.

BUG= 672508 

Review-Url: https://codereview.chromium.org/2655223004
Cr-Commit-Position: refs/heads/master@{#446721}

[modify] https://crrev.com/b709759f51db1a4d86c0fef25a3301c7a9f4e44e/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001-expected.html
[delete] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001.html

Comment 8 by r...@igalia.com, Jan 27 2017 

@robhogan I guess we can close this now, or is anything pending?

Comment 9 by nainar@chromium.org, Feb 13 2017

Labels: Update-Quarterly

Comment 10 by robhogan@chromium.org, Feb 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment