Icons for the settings page are fetched from the cache (e.g. chrome://favicon/size/16@1x/origin/https://www.facebook.com/). If there is no icon for the given URL/origin, we show empty icon. 

Bookmarks show icons that we don't. I made some investigation on this. 

I suppose we access to the favicon service in wrong way. This is how we request icons:
chrome://favicon/size/16@1x/origin/https://www.americanexpress.com/

pkotwicz@: 1) Shall we include "origin/" in requests? My experiments showed that we shouldn't. 

2) I found that whether we could fetch an icon depends on the URL ends with "/" or not. The difference between "...americanexpress.com/" and "...americanexpress.com" is not reproducible neither in the omnibox nor in the bookmarks manager. But on the password page (chrome://settings/passwords), do try to remove or add "/" at the end. The icon might appear or disappear (sometimes adding "/" hides the icon, sometimes it shows the icon). Is it intended behavior? 

Perhaps also related to  Issue 608069 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6178699a5a0ba0c505e336e7caf449a32467cba0

commit 6178699a5a0ba0c505e336e7caf449a32467cba0
Author: kolos <kolos@chromium.org>
Date: Wed Dec 14 08:56:39 2016

[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG= 672483 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}

[modify] https://crrev.com/6178699a5a0ba0c505e336e7caf449a32467cba0/chrome/browser/resources/options/password_manager_list.js

I request merge of r438465 into branch 2924 (M56).

This tiny CL fixes icons for chrome://settings/passwords. Now we use the same requests as the bookmarks do. So, it is safe and it's better to provide this change to users ASAP. 

I will be OOO. Please merge it. 

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67dd7addf25940ceb0e0b207ac4c7b4c22a25af6

commit 67dd7addf25940ceb0e0b207ac4c7b4c22a25af6
Author: kolos <kolos@chromium.org>
Date: Fri Dec 23 12:58:40 2016

[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG= 672483 
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)

Review-Url: https://codereview.chromium.org/2600723002
Cr-Commit-Position: refs/branch-heads/2924@{#612}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/67dd7addf25940ceb0e0b207ac4c7b4c22a25af6/chrome/browser/resources/options/password_manager_list.js

Tested the same on win10, mac 10.12.2 and Linux 14.04 using chrome version 56.0.2924.51 - icons display fine as shown in the screenshot

Fix works as expected