New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672467 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO Dec 22 - Jan 8
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 672469



Sign in to add a comment

Refactor AudioManager in preparation for switch to Mojo.

Project Member Reported by olka@chromium.org, Dec 8 2016

Issue description

AudioManager interface and implementation cleanup.
 

Comment 1 by olka@chromium.org, Dec 8 2016

Blocking: 672469

Comment 2 by olka@chromium.org, Dec 8 2016

Summary: Refactor AudioManager in preparation for switch to Mojo. (was: Refactor AudioManager is preparation for switch to Mojo.)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ea051559e9e40b7ee63db1d61fd0679f37d3e2

commit 87ea051559e9e40b7ee63db1d61fd0679f37d3e2
Author: olka <olka@chromium.org>
Date: Fri Dec 16 18:14:21 2016

Replace AudioManager::GetAudio*DeviceNames with AudioManager::GetAudio*DeviceDescriptions

see https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_devices_manager.cc?type=cs&sq=package:chromium&rcl=1481185182&l=68:

MediaDevicesManager now first asks AudioManager for device names, and then goes back to AudioManager for group ID of each device.
Since AudioManager will be moved to a separate process, we want to minimize the number of roundtrips.

BUG= 672467 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563653002
Cr-Commit-Position: refs/heads/master@{#439147}

[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/content/common/media/media_devices.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/content/common/media/media_devices.h
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/android/audio_android_unittest.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/audio_device_description.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/audio_device_description.h
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/audio_manager.h
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/audio_manager_base.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/audio_manager_base.h
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/audio_manager_unittest.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/mock_audio_manager.cc
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/mock_audio_manager.h
[modify] https://crrev.com/87ea051559e9e40b7ee63db1d61fd0679f37d3e2/media/audio/win/audio_low_latency_input_win_unittest.cc

Comment 4 by olka@chromium.org, Jul 11 2017

Status: Fixed (was: Started)

Sign in to add a comment