New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672458 link

Starred by 2 users
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: May 2017
Cc:
gov...@chromium.org
█ amineer@chromium.org
rouslan@chromium.org
est...@chromium.org
sdefresne@chromium.org
█ dimu@chromium.org
rohitrao@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

//third_party/libaddressinput depends on a file in src/chrome/app

Project Member Reported by sdefresne@chromium.org, Dec 8 2016 
Code in src/third_party/ should not depend on src/chrome/, however, //third_party/libaddressinput:strings compile src/chrome/app/address_input_strings.grd.

The file (and address_input_strings.grdp) should be moved out of src/chrome/, most likely to //third_party/libaddressinput to remove this incorrect dependency.

Comment 1 by sdefresne@chromium.org, Dec 8 2016

Cc: rouslan@chromium.org est...@chromium.org
rouslan/estade: would moving the file to src/third_party/libaddressinput be okay?

Comment 2 by rouslan@chromium.org, Dec 8 2016

Cc: amineer@chromium.org
The move would be OK, but be sure to update TPM's translation scripts that upload all *grd files to the translation console.

Comment 3 by sdefresne@chromium.org, Dec 8 2016 

I think the translation script uses tools/gritsettings/translation_expectations.pyl file to locate the grd file and presubmit complains if there is a grd file that is not listed there (but I'll be sure to update them when doing the change).

Comment 4 by amineer@chromium.org, Dec 9 2016

Cc: gov...@chromium.org
+govind@ who runs the translation pipeline now as FYI.

Comment 5 by gov...@chromium.org, Dec 9 2016

Cc: dimu@chromium.org

Comment 6 by mahmadi@chromium.org, May 17 2017

Owner: mahmadi@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12

commit 55d390c3d615ea9ada49a2ee4dcc31acbd50ce12
Author: mahmadi <mahmadi@chromium.org>
Date: Fri May 19 14:42:47 2017

Moves address_input_strings.grdp from chrome to third_party/libaddressinput

BUG= 672458 

Review-Url: https://codereview.chromium.org/2886173002
Cr-Commit-Position: refs/heads/master@{#473183}

[modify] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/BUILD.gn
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/address_input_strings.grd
[add] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/address_input_strings.grdp
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ro.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_te.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
[rename] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
[modify] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/third_party/libaddressinput/chromium/tools/update-strings.py
[modify] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/tools/gritsettings/resource_ids
[modify] https://crrev.com/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12/tools/gritsettings/translation_expectations.pyl
Project Member

Comment 8 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d00a1cc8265350d09f7eb9b434b0640de931ca

commit 27d00a1cc8265350d09f7eb9b434b0640de931ca
Author: mahmadi <mahmadi@chromium.org>
Date: Mon May 22 21:29:12 2017

Deletes chrome/app/address_input_strings.grdp and relevant entries in OWNERS file.

address_input_strings.grd and the translation were moved to
third_party/libaddressinput/chromium/ in:
https://codereview.chromium.org/2886173002/

BUG= 672458 

Review-Url: https://codereview.chromium.org/2894673006
Cr-Commit-Position: refs/heads/master@{#473702}

[modify] https://crrev.com/27d00a1cc8265350d09f7eb9b434b0640de931ca/chrome/app/OWNERS
[delete] https://crrev.com/25fa842cb11198a37ed0ae14a9618e20d2f97a02/chrome/app/address_input_strings.grdp

Comment 9 by mahmadi@chromium.org, May 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment