New issue
Advanced search Search tips

Issue 672436 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Timing of the resize event relative to fullscreenchange cannot be tested under LayoutTests

Project Member Reported by foolip@chromium.org, Dec 8 2016

Issue description

The Fullscreen API when tested under LayoutTests doesn't actually resize the viewport, so no resize event will be fired. This was a problem in a CL testing the timing of fullscreenchange events:
https://codereview.chromium.org/2564543002


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685

commit 9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685
Author: foolip <foolip@chromium.org>
Date: Thu Dec 08 18:07:49 2016

Add tests for fullscreenchange and fullscreenerror event timing

Although HTML does not yet define animation frame tasks as used by
Fullscreen, it does have "run the fullscreen rendering steps". That's
the old hook, making the timing of these events relative to resize and
animation frame callbacks unambiguous:
https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen
https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model

Spec issue: https://github.com/whatwg/html/issues/707

document-exit-fullscreen-timing-manual.html consistently matches
-expected.txt, with (accidentally) correct timing but no resize event.

element-request-fullscreen-timing-manual.html usually matches
-expected.txt, with incorrect timing, but can accidentally get the
timing right and instead fail due to no resize event.

Both are marked as flaky to be safe, and will be enabled in a coming CL.

Note: This CL is also a test for the WPT export process.

Firefox passes both fullscreechange event tests, but fails the
fullscreenerror test. (Implementation preceded spec changes.)

BUG= 402376 , 672436 

Review-Url: https://codereview.chromium.org/2564543002
Cr-Commit-Position: refs/heads/master@{#437283}

[modify] https://crrev.com/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json
[add] https://crrev.com/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-timing-manual-expected.txt
[add] https://crrev.com/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-timing-manual.html
[add] https://crrev.com/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-timing-manual-expected.txt
[add] https://crrev.com/9eef72d72ab21ad9d7513a3bc6a649fd3cc1d685/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-timing-manual.html

Project Member

Comment 2 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by e...@chromium.org, Dec 13 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment