New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672433 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 659205



Sign in to add a comment

Do not fetch RecentTabs if added page is not a recent tab

Project Member Reported by vitaliii@chromium.org, Dec 8 2016

Issue description

Currently we unconditionally fetch all recent tabs on each added offline page, however, there is no point in doing this if the added page is not a recent tab.
 

Comment 1 by fi...@chromium.org, Dec 14 2016

Labels: zine-pm
So you are saying that e.g. a 3 month old tab should not appear in the recent tab section. Right?
Do you know how long we keep open tabs in the cache? Until they get closed (=indefinitely) or is there some TTL attached to each entry in the cache?
Labels: zine-16-12-19
Status: Started (was: Assigned)
> So you are saying that e.g. a 3 month old tab should not appear 
> in the recent tab section. Right?

I am not saying this. I was talking about implementation detail, which I need to change.

> Do you know how long we keep open tabs in the cache?
If you mean when Last1 offline pages are removed, then the aim is to remove them when the tab is closed. Current they are removed once in a while.


Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad80f041ddc7bff1360592184661fd51bdf414e9

commit ad80f041ddc7bff1360592184661fd51bdf414e9
Author: vitaliii <vitaliii@chromium.org>
Date: Wed Dec 21 14:41:08 2016

[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

Currently, all offline pages are fetched when a new offline page is
added (even it if is not a recent tab). However, there is no sense to
refetch if there is no new recent tabs.

This CL changes the logic to fetch only when the added offline page is a
recent tab.

BUG= 672433 

Review-Url: https://codereview.chromium.org/2595873002
Cr-Commit-Position: refs/heads/master@{#440096}

[modify] https://crrev.com/ad80f041ddc7bff1360592184661fd51bdf414e9/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/ad80f041ddc7bff1360592184661fd51bdf414e9/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment