New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672416 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Error message for sync passphrase in chrome://md-settings is not displaying properly.

Project Member Reported by sahitya....@techmahindra.com, Dec 8 2016

Issue description

Chrome Version:56.0.2924.21 beta
OS:Linux (14.04 LTS),Windows

NOte:Font size should be very large in md-setttings.

Steps:
1. Launch chrome and sign into chrome with valid credentials.
2. Navigate to chrome://md-settings/syncSetup.
3. Scroll down to the bottom and Enter the wrong passphrase and click on submit and observe.


Expected: The error message should be properly displayed.
Actual:   The error message is  hidden behind the text.

This is a regression issue broken in 'M-55'.

Manual bisect information:

55.0.2846.0--good
55.0.2847.0--bad
 
Actual Error Passpharse.png
154 KB View Download
Actual Passphrase error.ogv
2.8 MB View Download
Expected passphrase error.png
149 KB View Download

Comment 1 by ajha@chromium.org, Dec 8 2016

Labels: -Type-Bug OS-Mac Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Issue is reproducible on the latest canary(57.0.2944.0) of Mac OS 10.11.6 keeping the Font size 'Very large'
Labels: -M-56 -Needs-Bisect M-55 hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Please find the bisect information as below

Change Log::
===============
https://chromium.googlesource.com/chromium/src/+log/8ad01a3783fd1655ef91b93a62fb854951ba5e16..05b5db68bf23918ab865837f1720525e11f3c72f

Possible suspect::
===================
https://chromium.googlesource.com/chromium/src/+/05b5db68bf23918ab865837f1720525e11f3c72f

dschuyler@ could you please look into this issue if it is related to your change,else please route this to an appropriate owner for this issue.

Thanks,
Just to update the latest behavior of the bug, Issue is still observed on chrome latest canary M57-57.0.2953.0
 dschuyler@ Could you please let us know is there any recent update available on this issue?

Thanks!
Owner: ----
Status: Available (was: Assigned)
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa40908dd04900048559b86f7eeae484e6623e11

commit aa40908dd04900048559b86f7eeae484e6623e11
Author: scottchen <scottchen@chromium.org>
Date: Tue Feb 28 20:14:55 2017

MD Settings: make input label and error font size relative.

Prior to this CL, paper-input's label and error messages have a fixed font-size of 12px, so when the user changes their browser's font-size setting, the input label and error message font size will look very odd.

BUG= 672416 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2715863002
Cr-Commit-Position: refs/heads/master@{#453684}

[modify] https://crrev.com/aa40908dd04900048559b86f7eeae484e6623e11/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/aa40908dd04900048559b86f7eeae484e6623e11/chrome/browser/resources/settings/settings_vars_css.html

Status: Fixed (was: Started)

Sign in to add a comment