VEA unittest hangs if it builds from chromium |
||||
Issue descriptionChrome Version: synced on Nov 22 OS: Chrome OS nyan_big What steps will reproduce the problem? (1) Build video_encode_accelerator_unittest from external chromium. (2) Run the test. ./video_encode_accelerator_unittest --test_stream_data=bear_320x192_40frames.yuv:320:192:1:out1.h264:200000:30:200000:30 What is the expected result? The test fails SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/1 because chromium doesn't have h264 decoder. All other tests should pass. What happens instead? The test hanged and showed the following log. [1123/131253:ERROR:video_encode_accelerator_unittest.cc(670)] Chromium does not support H264 decode. Try Chrome. ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:671: Failure Failed Decoder initialization error
,
Dec 13 2016
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb047232f64eeec5cb234614a30734717520e38 commit 3eb047232f64eeec5cb234614a30734717520e38 Author: hywu <hywu@google.com> Date: Tue Dec 13 11:57:27 2016 VEA unittest: fix TestSimpleEncode crash while decoder fails If VideoFrameQualityValidator cannot get a decoder, the TestSimpleEncode test would abort without destroying the encoder first and thus causes a crash. This change makes the test to fail properly. BUG= 672403 TEST=Run VEA unittest built for external chromium on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2573733002 Cr-Commit-Position: refs/heads/master@{#438133} [modify] https://crrev.com/3eb047232f64eeec5cb234614a30734717520e38/media/gpu/video_encode_accelerator_unittest.cc
,
Dec 14 2016
,
Jan 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wuchengli@chromium.org
, Dec 8 2016