Automatic downloads icon not shown after interacting with permission prompt
Reported by
alshaba...@yandex-team.ru,
Dec 8 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36 Steps to reproduce the problem: 1. Go to https://permission.site 2. Click on Auto Download. Permission prompt will appear. 3. Press either Allow or Block What is the expected behavior? An icon on the right side of location bar is shown. What went wrong? No icon is shown. Did this work before? N/A Chrome version: 54.0.2840.99 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 I'm basing the expected behavior on geolocation content setting. The icon will get shown if you go to the site from another tab and click Auto Download again.
,
Dec 8 2016
,
Dec 9 2016
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3db897f00b693287702dc2b88c5ebe757e2babaf commit 3db897f00b693287702dc2b88c5ebe757e2babaf Author: alshabalin <alshabalin@yandex-team.ru> Date: Thu Mar 02 10:33:43 2017 Handle per-tab AUTOMATIC_DOWNLOADS setting in DownloadRequestLimiter. BUG= 672395 Review-Url: https://codereview.chromium.org/2561673003 Cr-Commit-Position: refs/heads/master@{#454228} [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/content_settings/tab_specific_content_settings.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/content_settings/tab_specific_content_settings.h [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/download/download_request_limiter.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/download/download_request_limiter.h [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/download/download_request_limiter_unittest.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/content_settings/content_setting_bubble_model.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/content_settings/content_setting_bubble_model.h [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/content_settings/content_setting_image_model.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/content_settings/content_setting_image_model_browsertest.cc [modify] https://crrev.com/3db897f00b693287702dc2b88c5ebe757e2babaf/chrome/browser/ui/views/location_bar/content_setting_bubble_dialog_browsertest.cc
,
Mar 8 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 22 2018
Closing this out as it looks like the CL addressed it? Feel free to reopen if not thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by rdsmith@chromium.org
, Dec 8 2016