New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672385 link

Starred by 1 user
Status: Verified
Owner:
hidehiko@chromium.org
Closed: Jan 2017
Cc:
█ lhchavez@chromium.org
hashimoto@chromium.org
hidehiko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Call mojo::edk::test::Shutdown(); in tests using Mojo for ARC.

Project Member Reported by hidehiko@chromium.org, Dec 8 2016 
Chrome Version: ToT
OS: ChromeOS

Currently, if we call it following crash happens, after test runs.

[195545:195545:1208/170504.839635:271299389580:FATAL:embedder.cc(148)] Check failed: internal::g_core.
#0 0x7f64022fc0de base::debug::StackTrace::StackTrace()
#1 0x7f640236217c logging::LogMessage::~LogMessage()
#2 0x7f63f939a4a8 mojo::edk::ShutdownIPCSupport()
#3 0x00000884865d mojo::edk::test::ScopedIPCSupport::~ScopedIPCSupport()
#4 0x00000417ab62 main
#5 0x7f63ea108f45 __libc_start_main
#6 0x0000008b95d5 <unknown>

Comment 1 by hidehiko@chromium.org, Jan 5 2017

Owner: hidehiko@chromium.org
Status: Started (was: Untriaged)
Investigated.

mojo::edk's initialization is handled by unittest framework as follows.

#1 0x7ff277c162b2 mojo::edk::Init()
#2 0x7ff27db435c0 content::(anonymous namespace)::MojoInitializer::MojoInitializer()
#3 0x7ff27db4358a base::DefaultLazyInstanceTraits<>::New()
#4 0x7ff27db43495 base::internal::LeakyLazyInstanceTraits<>::New()
#5 0x7ff27db4344d base::LazyInstance<>::Pointer()
#6 0x7ff27db433e5 base::LazyInstance<>::Get()
#7 0x7ff27db433c4 content::InitializeMojo()
#8 0x0000043d1f10 content::TestBlinkWebUnitTestSupport::TestBlinkWebUnitTestSupport()
#9 0x0000043cfcbb content::UnitTestTestSuite::UnitTestTestSuite()
#10 0x0000043086c4 main
#11 0x7ff268b6cf45 __libc_start_main
#12 0x0000008c5a65 <unknown>

So, what we really need to do is removing mojo::edk::Init() from SetUp().
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e8579476ef117b18cd323a370681deb7e17f00

commit 76e8579476ef117b18cd323a370681deb7e17f00
Author: hidehiko <hidehiko@chromium.org>
Date: Thu Jan 05 14:49:38 2017

Remove mojo::edk::Init() from ARC unittest.

Initialization of Mojo is handled by unittest framework.
This CL removes it from SetUp() for ARC.

BUG= 672385 
TEST=Ran unittest.

Review-Url: https://codereview.chromium.org/2614843003
Cr-Commit-Position: refs/heads/master@{#441654}

[modify] https://crrev.com/76e8579476ef117b18cd323a370681deb7e17f00/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc

Comment 3 by hidehiko@chromium.org, Jan 5 2017

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by sdantul...@chromium.org, Mar 29 2017

Labels: code-change
Status: Verified (was: Fixed)
►

Sign in to add a comment