Flaky webkit_tests failures on linux_chromium_rel_ng |
|||
Issue descriptionThere are some flaky webkit_tests failures on linux_chromium_rel_ng which are causing CLs to be incorrectly kicked out of the CQ. In my try job https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352160 the following tests failed: virtual/mojo-loading/http/tests/navigation/image-load-in-unload-handler.html virtual/android/media/mediadocument/media-document-with-download-button.html The second one looks like a legitimate flaky test with image failures. The first looks like it's flaky in all configurations, not just that virtual test suite. For example, virtual/stable/http/tests/navigation/image-load-in-unload-handler.html flaked a couple of times before passing. There are more examples of webkit_tests failing both with and without the patch on https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng?numbuilds=200 . Sheriffs, could you please triage these failures, file more bugs as necessary about them, and suppress them? They are at best slowing down the CQ, and at worst causing valid CLs to fail the CQ.
,
Dec 8 2016
media-document-with-download-button seems to be particularly flaky; more recent examples: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352407 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352388 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352370 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352355
,
Dec 9 2016
Sheriffs, who will suppress these failures in LayoutTests/TestExpectations?
,
Dec 9 2016
I'll suppress the second one. I'm not so sure about http/tests/navigation/image-load-in-unload-handler.html.
,
Dec 9 2016
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f26da5af712a45c4ee62d79e6da2530a591ce987 commit f26da5af712a45c4ee62d79e6da2530a591ce987 Author: yhirano <yhirano@chromium.org> Date: Fri Dec 09 04:29:44 2016 Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky BUG= 672696 , 672371 NOTRY=true TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org Review-Url: https://codereview.chromium.org/2560033003 Cr-Commit-Position: refs/heads/master@{#437466} [modify] https://crrev.com/f26da5af712a45c4ee62d79e6da2530a591ce987/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 9 2016
I don't see a problem with image-load-in-unload-handler.html during the last day. For media-document-with-download-button there is a separate Issue 672696 .
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa1b1d387e4e6a3ce8856c584b7cf1e712a8bd4 commit 7fa1b1d387e4e6a3ce8856c584b7cf1e712a8bd4 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Dec 09 17:12:12 2016 Revert of Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky (patchset #1 id:1 of https://codereview.chromium.org/2560033003/ ) Reason for revert: The issue had just been fixed by https://codereview.chromium.org/2555373005 before this marking. Original issue's description: > Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky > > BUG= 672696 , 672371 > NOTRY=true > TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org > > Committed: https://crrev.com/f26da5af712a45c4ee62d79e6da2530a591ce987 > Cr-Commit-Position: refs/heads/master@{#437466} TBR=asargent@chromium.org,grt@chromium.org,vasilii@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 672696 , 672371 Review-Url: https://codereview.chromium.org/2564623005 Cr-Commit-Position: refs/heads/master@{#437570} [modify] https://crrev.com/7fa1b1d387e4e6a3ce8856c584b7cf1e712a8bd4/third_party/WebKit/LayoutTests/TestExpectations |
|||
►
Sign in to add a comment |
|||
Comment 1 by kbr@chromium.org
, Dec 8 2016