Some possibilities: CanAddAutogeneratedKeyword() IsPrepopulatedOrCreatedByPolicy() ShowInDefaultList() CanReplace() Likely others.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c4df02e620f303e9e3f65818323bc3dc2dc29aa commit 9c4df02e620f303e9e3f65818323bc3dc2dc29aa Author: jeffschiller <jeffschiller@google.com> Date: Fri Apr 14 00:47:38 2017 Make several methods of TemplateUrlService const BUG= 672364 Review-Url: https://codereview.chromium.org/2811793007 Cr-Commit-Position: refs/heads/master@{#464630} [modify] https://crrev.com/9c4df02e620f303e9e3f65818323bc3dc2dc29aa/components/search_engines/template_url_service.cc [modify] https://crrev.com/9c4df02e620f303e9e3f65818323bc3dc2dc29aa/components/search_engines/template_url_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/612137acaa5360d5f7d2e2ab5dbb20d0704405d7 commit 612137acaa5360d5f7d2e2ab5dbb20d0704405d7 Author: jeffschiller <jeffschiller@google.com> Date: Wed Apr 19 04:34:24 2017 Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID, GetTemplateURLForHost BUG= 672364 Review-Url: https://codereview.chromium.org/2816353002 Cr-Commit-Position: refs/heads/master@{#465491} [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/chrome/browser/android/locale/special_locale_handler.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/chrome/browser/ui/omnibox/chrome_omnibox_client.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/chrome/browser/ui/omnibox/chrome_omnibox_client.h [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/chrome/browser/ui/search_engines/edit_search_engine_controller.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/omnibox/browser/autocomplete_controller.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/omnibox/browser/autocomplete_match.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/omnibox/browser/base_search_provider.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/omnibox/browser/omnibox_client.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/omnibox/browser/omnibox_client.h [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/search_engines/template_url_service.cc [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/components/search_engines/template_url_service.h [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h [modify] https://crrev.com/612137acaa5360d5f7d2e2ab5dbb20d0704405d7/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aa7a4e1cf5bb91918e8692a1909ededca93523b commit 8aa7a4e1cf5bb91918e8692a1909ededca93523b Author: jeffschiller <jeffschiller@google.com> Date: Sun Apr 23 02:22:10 2017 Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version BUG= 672364 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2816383002 Cr-Commit-Position: refs/heads/master@{#466554} [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/android/contextualsearch/contextual_search_delegate.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/android/locale/special_locale_handler.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/android/logo_service.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/profile_resetter/profile_resetter_unittest.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/profile_resetter/resettable_settings_snapshot.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/search/search.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/search_engines/template_url_service_android.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/search_engines/template_url_service_sync_unittest.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/search_engines/template_url_service_unittest.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/ui/search_engines/keyword_editor_controller.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/chrome/browser/ui/search_engines/keyword_editor_controller.h [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/components/omnibox/browser/history_url_provider.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/components/omnibox/browser/history_url_provider.h [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/components/search_engines/template_url.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/components/search_engines/template_url.h [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/components/search_engines/template_url_service.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/components/search_engines/template_url_service.h [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/ios/chrome/browser/google/google_logo_service.mm [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/8aa7a4e1cf5bb91918e8692a1909ededca93523b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
I think this is done. pkasting@ feel free to re-open it if you think it needs more work.
Comment 1 by bugdroid1@chromium.org
, Apr 14 2017