run-webkit-tests doesn't include path_delimiter in json output |
||||
Issue descriptionRun, python third_party/WebKit/Tools/Scripts/run-webkit-tests --json-test-results="out.json" fast/forms The out.json should have a top level valued called 'path_delimiter'. https://www.chromium.org/developers/the-json-test-results-format Optional. We should make this mandatory. The separator string to use in between components of a tests name; normally "." for GTest- and Python-based tests and "/" for layout tests; if not present, you should default to "/" for backwards-compatibility.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26fe3e6f15dd430080d29fe1b7f0e3703e01e88e commit 26fe3e6f15dd430080d29fe1b7f0e3703e01e88e Author: qyearsley <qyearsley@chromium.org> Date: Fri Dec 09 02:03:52 2016 Add path_delimiter = "/" to layout test results JSON. Reason: the path_delimiter is different between gtest results and layout tests; in https://sites.google.com/a/chromium.org/dev/developers/the-json-test-results-format it has been suggested for some time that path_delimiter should be required. BUG=672361 Review-Url: https://codereview.chromium.org/2559983003 Cr-Commit-Position: refs/heads/master@{#437428} [modify] https://crrev.com/26fe3e6f15dd430080d29fe1b7f0e3703e01e88e/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py [modify] https://crrev.com/26fe3e6f15dd430080d29fe1b7f0e3703e01e88e/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/7a505dc5453d0341e170c25809e5a92133d5f851 commit 7a505dc5453d0341e170c25809e5a92133d5f851 Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Dec 09 00:33:15 2016 Support different path delimiters in test_results recipe module. Reason: It might make sense for Results JSON for gtests to use dot (.) as a path delimiter and according to https://www.chromium.org/developers/the-json-test-results-format, path_delimiter should be a required value. This CL shouldn't change behavior. BUG=672361 Change-Id: I3aae33281d2c1f240f93488a8577a84aa124aa3b Reviewed-on: https://chromium-review.googlesource.com/418319 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> [modify] https://crrev.com/7a505dc5453d0341e170c25809e5a92133d5f851/scripts/slave/recipe_modules/test_results/resources/json_results_generator.py [modify] https://crrev.com/7a505dc5453d0341e170c25809e5a92133d5f851/scripts/slave/recipe_modules/test_results/resources/tests/json_results_generator_unittest.py
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/7a505dc5453d0341e170c25809e5a92133d5f851 commit 7a505dc5453d0341e170c25809e5a92133d5f851 Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Dec 09 00:33:15 2016 Support different path delimiters in test_results recipe module. Reason: It might make sense for Results JSON for gtests to use dot (.) as a path delimiter and according to https://www.chromium.org/developers/the-json-test-results-format, path_delimiter should be a required value. This CL shouldn't change behavior. BUG=672361 Change-Id: I3aae33281d2c1f240f93488a8577a84aa124aa3b Reviewed-on: https://chromium-review.googlesource.com/418319 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> [modify] https://crrev.com/7a505dc5453d0341e170c25809e5a92133d5f851/scripts/slave/recipe_modules/test_results/resources/json_results_generator.py [modify] https://crrev.com/7a505dc5453d0341e170c25809e5a92133d5f851/scripts/slave/recipe_modules/test_results/resources/tests/json_results_generator_unittest.py
,
Jun 1 2017
Looking at the test_results recipe module, I think that the behavior there is already correct... so I think there's one more possible task related to this issue, which is to make path_delimiter required in https://cs.chromium.org/chromium/infra/go/src/infra/appengine/test-results/model/full_result.go.
,
Jun 4 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2018
PathDelim is still optional in full_results.go |
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Dec 8 2016