New issue
Advanced search Search tips

Issue 672352 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

media_uniitest fail on arm without OPUS_FIXED_POINT

Project Member Reported by mbjorge@google.com, Dec 8 2016 
[ RUN      ] PipelineIntegrationTest.BasicPlaybackOpusWebmTrimmingHashed
../../media/test/pipeline_integration_test.cc:1106: Failure
Value of: GetAudioHash()
  Actual: "-4.57,-5.66,-6.52,-6.30,-4.37,-3.61,"
Expected: kOpusEndTrimmingHash_1
Which is: "-4.56,-5.65,-6.51,-6.29,-4.36,-3.59,"
../../media/test/pipeline_integration_test.cc:1112: Failure
Value of: GetAudioHash()
  Actual: "-11.91,-11.11,-8.27,-7.13,-7.86,-10.00,"
Expected: kOpusEndTrimmingHash_2
Which is: "-11.89,-11.09,-8.25,-7.11,-7.84,-9.97,"
../../media/test/pipeline_integration_test.cc:1119: Failure
Value of: GetAudioHash()
  Actual: "-13.31,-14.38,-13.70,-11.71,-10.21,-10.49,"
Expected: kOpusEndTrimmingHash_3
Which is: "-13.28,-14.35,-13.67,-11.68,-10.18,-10.46,"
[  FAILED  ] PipelineIntegrationTest.BasicPlaybackOpusWebmTrimmingHashed (742 ms)

The OPUS_FIXED_POINT define from teh opus config is not getting propogated correctly to the media_unittests (as seen by gn desc).
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9bc6779fab8a404ae2a01df4dd3c45ffd3a408e

commit e9bc6779fab8a404ae2a01df4dd3c45ffd3a408e
Author: mbjorge <mbjorge@chromium.org>
Date: Fri Dec 09 20:36:05 2016

Add opus dep to media pipeline_integration_test.

arm devices require the OPUS_FIXED_POINT. This define got lost at some
point. Add a public_dep so the media_unittests gets the necessary
config.

BUG= 672352 
TEST=gn desc out/ //media:media_unittests

Review-Url: https://codereview.chromium.org/2562513003
Cr-Commit-Position: refs/heads/master@{#437628}

[modify] https://crrev.com/e9bc6779fab8a404ae2a01df4dd3c45ffd3a408e/media/BUILD.gn
[modify] https://crrev.com/e9bc6779fab8a404ae2a01df4dd3c45ffd3a408e/media/test/BUILD.gn

Comment 2 by mbjorge@google.com, Dec 12 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment