New issue
Advanced search Search tips

Issue 672348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 632886
issue 779147
issue 785381



Sign in to add a comment

Add provision suite and build stage

Project Member Reported by ayatane@chromium.org, Dec 8 2016

Issue description

Add a provision test suite and build stage to provide the foundation for separating provisioning and actual test jobs.
 
Showing comments 90 - 189 of 189 Older
Project Member

Comment 90 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cec26f75b0697a1ce7c23af8ff91ac38b053fe05

commit cec26f75b0697a1ce7c23af8ff91ac38b053fe05
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 13 22:18:57 2017

[autotest] Extract _ComposedPredicate

BUG= chromium:672348 
TEST=None

Change-Id: I66d40324a27950363cd05a94a7ba271190a72e7f
Reviewed-on: https://chromium-review.googlesource.com/452950
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/cec26f75b0697a1ce7c23af8ff91ac38b053fe05/server/cros/dynamic_suite/suite.py

Project Member

Comment 91 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/76b8f31f872ee837fddf661762cda2033e7f3964

commit 76b8f31f872ee837fddf661762cda2033e7f3964
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:11 2017

[autotest] Move experimental filtering out more

BUG= chromium:672348 
TEST=None

Change-Id: I13651192469c013b15b7fa8c0e97456231087440
Reviewed-on: https://chromium-review.googlesource.com/452674
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/76b8f31f872ee837fddf661762cda2033e7f3964/server/cros/dynamic_suite/suite.py

Project Member

Comment 92 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bb60f4445263248f8dfd55bf8f4bee29cb369202

commit bb60f4445263248f8dfd55bf8f4bee29cb369202
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:12 2017

[autotest] Clean up logging

The logging messages was split between helper functions, making it
hard to tell in what context the logging messages were being emitted,
so move the logging messages to the same level.

BUG= chromium:672348 
TEST=None

Change-Id: Ibe11d1b0da88639d7de1f006e8146007e84cc964
Reviewed-on: https://chromium-review.googlesource.com/452675
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/bb60f4445263248f8dfd55bf8f4bee29cb369202/server/cros/dynamic_suite/suite.py

Project Member

Comment 93 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/574fe4db670c084e23a1ef21be5ebe651fdc01b7

commit 574fe4db670c084e23a1ef21be5ebe651fdc01b7
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:12 2017

[autotest] Make _ControlFileRetriever class

This class will contain all of the logic for getting and parsing
control files.

BUG= chromium:672348 
TEST=None

Change-Id: I24bc89193a271e9e631c7376f47ec06aaee1d2a2
Reviewed-on: https://chromium-review.googlesource.com/452676
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/574fe4db670c084e23a1ef21be5ebe651fdc01b7/server/cros/dynamic_suite/suite.py

Project Member

Comment 94 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d8d1bbdcb2b0209a92dcd7fcbd1a7385ad31c479

commit d8d1bbdcb2b0209a92dcd7fcbd1a7385ad31c479
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:10 2017

[autotest] Remove _cf_getter attribute

Its no longer used on _BaseSuite, so remove it there.  cf_getter is
still used as a parameter in Suite.__init__()

BUG= chromium:672348 
TEST=None

Change-Id: Ica991b8dfdd5e99d57a832ae0b1161c2e9e9df97
Reviewed-on: https://chromium-review.googlesource.com/452951
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/d8d1bbdcb2b0209a92dcd7fcbd1a7385ad31c479/server/cros/dynamic_suite/suite.py

Project Member

Comment 95 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/00bbe5b2efb044f023b5b45893ecc4a22ea87e43

commit 00bbe5b2efb044f023b5b45893ecc4a22ea87e43
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:10 2017

[autotest] Make tests a parameter constructor

Parameters are awesome.  Did they come from math?  I love math.

BUG= chromium:672348 
TEST=None

Change-Id: I0a4cd6388188f363bad7ef7624768db1f15d9ee8
Reviewed-on: https://chromium-review.googlesource.com/452952
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/00bbe5b2efb044f023b5b45893ecc4a22ea87e43/server/cros/dynamic_suite/suite.py

Project Member

Comment 96 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e38d28b12507d7b6895f896e32b4d68953e8f8f6

commit e38d28b12507d7b6895f896e32b4d68953e8f8f6
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:10 2017

[autotest] Move unrelated logic out of try/except

These lines wont raise any parsing exceptions so move them
out (Anything that goes wrong here is a bug in the code, not the test
control data file)

BUG= chromium:672348 
TEST=None

Change-Id: If4add10c9f81aa3f1c6242063ae08515c80b4796
Reviewed-on: https://chromium-review.googlesource.com/452953
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/e38d28b12507d7b6895f896e32b4d68953e8f8f6/server/cros/dynamic_suite/suite.py

Project Member

Comment 97 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/447cb1e3bacfdb656de8e4ea707bd6c8b7fade03

commit 447cb1e3bacfdb656de8e4ea707bd6c8b7fade03
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:11 2017

[autotest] Clean up _batch_get_control_file_texts

BUG= chromium:672348 
TEST=None

Change-Id: I2ee224b22fff205b7a0406665b6c01a1795aa84b
Reviewed-on: https://chromium-review.googlesource.com/452954
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/447cb1e3bacfdb656de8e4ea707bd6c8b7fade03/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/447cb1e3bacfdb656de8e4ea707bd6c8b7fade03/server/cros/dynamic_suite/suite_unittest.py

Project Member

Comment 98 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a92cddbcacba7a607153f6bd2711cc94511c1689

commit a92cddbcacba7a607153f6bd2711cc94511c1689
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:11 2017

[autotest] Move experimental filtering

BUG= chromium:672348 
TEST=None

Change-Id: I14075afeedd3fe5dcd816a8ef2dc91c1a5de6f09
Reviewed-on: https://chromium-review.googlesource.com/452955
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/a92cddbcacba7a607153f6bd2711cc94511c1689/server/cros/dynamic_suite/suite.py

Project Member

Comment 99 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/36746975a7ef96c6165bb7595094314b2a1570ce

commit 36746975a7ef96c6165bb7595094314b2a1570ce
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:13 2017

[autotest] Make cf_getter an instance attribute

BUG= chromium:672348 
TEST=None

Change-Id: I191051ae721dedd066e6a984df8a979608f3a1b1
Reviewed-on: https://chromium-review.googlesource.com/453258
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/36746975a7ef96c6165bb7595094314b2a1570ce/server/cros/dynamic_suite/suite.py

Project Member

Comment 100 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/65258bf29e299dee7feb6eb5aab92d6f16b16eef

commit 65258bf29e299dee7feb6eb5aab92d6f16b16eef
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 18 05:50:13 2017

[autotest] Proxy ControlFileRetriever construction

This will enable us to return a different retriever subclass depending
on the cf_getter.

BUG= chromium:672348 
TEST=None

Change-Id: If135346c3778d8d6e5477f32c4dba927aa26b794
Reviewed-on: https://chromium-review.googlesource.com/453259
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/65258bf29e299dee7feb6eb5aab92d6f16b16eef/server/cros/dynamic_suite/suite.py

Project Member

Comment 101 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/363cdac3307a668cfe96fed393d8d1732b7b8f53

commit 363cdac3307a668cfe96fed393d8d1732b7b8f53
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 22 04:57:52 2017

[autotest] Move control file getting functions onto class

BUG= chromium:672348 
TEST=None

Change-Id: I8c71d8146c589bff26656504007397faffdc7839
Reviewed-on: https://chromium-review.googlesource.com/453260
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/363cdac3307a668cfe96fed393d8d1732b7b8f53/server/cros/dynamic_suite/suite.py

Project Member

Comment 102 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ec99911b20d9e79e6eddd2f1e935d60e5de93d58

commit ec99911b20d9e79e6eddd2f1e935d60e5de93d58
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:59 2017

[autotest] Fix docstrings

BUG= chromium:672348 
TEST=None

Change-Id: I40811f914ed9acaacd35a3718fa66751ffb30882
Reviewed-on: https://chromium-review.googlesource.com/452964
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/ec99911b20d9e79e6eddd2f1e935d60e5de93d58/server/cros/dynamic_suite/suite.py

Project Member

Comment 103 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ec99911b20d9e79e6eddd2f1e935d60e5de93d58

commit ec99911b20d9e79e6eddd2f1e935d60e5de93d58
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:59 2017

[autotest] Fix docstrings

BUG= chromium:672348 
TEST=None

Change-Id: I40811f914ed9acaacd35a3718fa66751ffb30882
Reviewed-on: https://chromium-review.googlesource.com/452964
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/ec99911b20d9e79e6eddd2f1e935d60e5de93d58/server/cros/dynamic_suite/suite.py

Project Member

Comment 104 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c3fac8bb448575e4779d897a1c4f0d55f5c6ff29

commit c3fac8bb448575e4779d897a1c4f0d55f5c6ff29
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:40:00 2017

[autotest] Rename find_test_control_data_for_suite method

BUG= chromium:672348 
TEST=None

Change-Id: Ie1784dc15f8118e9502d317706b23f5ae9db6bab
Reviewed-on: https://chromium-review.googlesource.com/452965
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/c3fac8bb448575e4779d897a1c4f0d55f5c6ff29/server/cros/dynamic_suite/suite.py

Project Member

Comment 105 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/340c39157424ee7612a30be9af4458256cf09b6c

commit 340c39157424ee7612a30be9af4458256cf09b6c
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:56 2017

[autotest] Rename method get_control_file_texts

Free up this name.

BUG= chromium:672348 
TEST=None

Change-Id: Idb029dd30c2fe3348a5c78bab042890166b8a786
Reviewed-on: https://chromium-review.googlesource.com/453261
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/340c39157424ee7612a30be9af4458256cf09b6c/server/cros/dynamic_suite/suite.py

Project Member

Comment 106 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/374c1b67d8dfcb182592f9776e6639bde253e68e

commit 374c1b67d8dfcb182592f9776e6639bde253e68e
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:56 2017

[autotest] Extract _filter_cf_paths method

BUG= chromium:672348 
TEST=None

Change-Id: I0cf1da7c6befe44d42c59edbd6bf3382d9542385
Reviewed-on: https://chromium-review.googlesource.com/453262
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/374c1b67d8dfcb182592f9776e6639bde253e68e/server/cros/dynamic_suite/suite.py

Project Member

Comment 107 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/57de3909a5c6a1bb4d81673afb13072450acc8ed

commit 57de3909a5c6a1bb4d81673afb13072450acc8ed
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:56 2017

[autotest] Merge if statement blocks

BUG= chromium:672348 
TEST=None

Change-Id: I0c8624ad2701cbbd33d29e5ffde8f5b7c6f87f62
Reviewed-on: https://chromium-review.googlesource.com/453263
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/57de3909a5c6a1bb4d81673afb13072450acc8ed/server/cros/dynamic_suite/suite.py

Project Member

Comment 108 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/da62c617270e06215f179a2f22088ffd431fc5c5

commit da62c617270e06215f179a2f22088ffd431fc5c5
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:57 2017

[autotest] Make empty batch retriever subclass

BUG= chromium:672348 
TEST=None

Change-Id: Id5b984f33c29e1784c60db32d361ce7b5dd928f1
Reviewed-on: https://chromium-review.googlesource.com/453264
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/da62c617270e06215f179a2f22088ffd431fc5c5/server/cros/dynamic_suite/suite.py

Project Member

Comment 109 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3466ae8a4cb5c1382ef41e1c9cb19c6598caf71a

commit 3466ae8a4cb5c1382ef41e1c9cb19c6598caf71a
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:58 2017

[autotest] Extract _get_control_file_text_for_suite method

BUG= chromium:672348 
TEST=None

Change-Id: Ie313f9ad5c6d112ab0c9f1d7b03669ced079b106
Reviewed-on: https://chromium-review.googlesource.com/453266
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/3466ae8a4cb5c1382ef41e1c9cb19c6598caf71a/server/cros/dynamic_suite/suite.py

Project Member

Comment 110 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2d7c9561eacbb684113324e33050bfd2255ea6db

commit 2d7c9561eacbb684113324e33050bfd2255ea6db
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:57 2017

[autotest] Conditionally create batch retriever

BUG= chromium:672348 
TEST=None

Change-Id: I1f4ea07a4f712945dc37a5a20b133e34f06bdaa4
Reviewed-on: https://chromium-review.googlesource.com/453265
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/2d7c9561eacbb684113324e33050bfd2255ea6db/server/cros/dynamic_suite/suite.py

Project Member

Comment 111 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1abded59cfdf17ab4781d6440850c3212450818a

commit 1abded59cfdf17ab4781d6440850c3212450818a
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:58 2017

[autotest] Split _get_control_file_text_for_suite method

Refactoring!

BUG= chromium:672348 
TEST=None

Change-Id: I072f0c7ee88dceacc0be5dbb37a7057ae1451d07
Reviewed-on: https://chromium-review.googlesource.com/453267
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/1abded59cfdf17ab4781d6440850c3212450818a/server/cros/dynamic_suite/suite.py

Project Member

Comment 112 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ce93df7c1a2ed4b8ae81b4a23fb68afb58f40005

commit ce93df7c1a2ed4b8ae81b4a23fb68afb58f40005
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:59 2017

[autotest] Move _should_batch_with closer to use site

BUG= chromium:672348 
TEST=None

Change-Id: I3e7a5f9cd4921be9bda6fd7fb5b167f9c2e06040
Reviewed-on: https://chromium-review.googlesource.com/453268
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/ce93df7c1a2ed4b8ae81b4a23fb68afb58f40005/server/cros/dynamic_suite/suite.py

Project Member

Comment 113 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/975c9528084b89f9df60d64cccbe22e0d29786b5

commit 975c9528084b89f9df60d64cccbe22e0d29786b5
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 26 01:39:59 2017

[autotest] Inline helper methods

BUG= chromium:672348 
TEST=None

Change-Id: I3c2457e578edd44a763014936fa70e351fce5924
Reviewed-on: https://chromium-review.googlesource.com/453269
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/975c9528084b89f9df60d64cccbe22e0d29786b5/server/cros/dynamic_suite/suite.py

Project Member

Comment 114 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15e95606649431d64f674e6291fd458b8d2add6e

commit 15e95606649431d64f674e6291fd458b8d2add6e
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:03 2017

[autotest] Move _parse_control_file_texts method

BUG= chromium:672348 
TEST=None

Change-Id: If5e332a06125d2fbd07dc915e33717b840354913
Reviewed-on: https://chromium-review.googlesource.com/452692
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/15e95606649431d64f674e6291fd458b8d2add6e/server/cros/dynamic_suite/suite.py

Project Member

Comment 115 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aed934967f83e9ded121ce270c7fec0790c9f554

commit aed934967f83e9ded121ce270c7fec0790c9f554
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:04 2017

[autotest] Make parsing parameters into instance attributes

BUG= chromium:672348 
TEST=None

Change-Id: I80e03f5c98c2fbc09ae665641b92d9cfe1399894
Reviewed-on: https://chromium-review.googlesource.com/452693
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/aed934967f83e9ded121ce270c7fec0790c9f554/server/cros/dynamic_suite/suite.py

Project Member

Comment 116 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15e95606649431d64f674e6291fd458b8d2add6e

commit 15e95606649431d64f674e6291fd458b8d2add6e
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:03 2017

[autotest] Move _parse_control_file_texts method

BUG= chromium:672348 
TEST=None

Change-Id: If5e332a06125d2fbd07dc915e33717b840354913
Reviewed-on: https://chromium-review.googlesource.com/452692
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/15e95606649431d64f674e6291fd458b8d2add6e/server/cros/dynamic_suite/suite.py

Project Member

Comment 117 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4890529059dbc666f392da50043401b042b09d18

commit 4890529059dbc666f392da50043401b042b09d18
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:04 2017

[autotest] Deduplicate constructor calling

BUG= chromium:672348 
TEST=None

Change-Id: If4b0d23c3fa36ee073af3ec297a5deac65e3ca34
Reviewed-on: https://chromium-review.googlesource.com/452694
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/4890529059dbc666f392da50043401b042b09d18/server/cros/dynamic_suite/suite.py

Project Member

Comment 118 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8646834d453e730dbbf2356df1b72ea637045fe1

commit 8646834d453e730dbbf2356df1b72ea637045fe1
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:05 2017

[autotest] Remove identical default parameter

BUG= chromium:672348 
TEST=None

Change-Id: Ic12b1f4ca5fed29c0a043e168d410841334c817e
Reviewed-on: https://chromium-review.googlesource.com/452695
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/8646834d453e730dbbf2356df1b72ea637045fe1/server/cros/dynamic_suite/suite.py

Project Member

Comment 119 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3adae953b60276cc83ca5779db9f60a1b4afbeae

commit 3adae953b60276cc83ca5779db9f60a1b4afbeae
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:05 2017

[autotest] Make experimental filtering be a predicate

BUG= chromium:672348 
TEST=None

Change-Id: I51fd27e405536255dedb960e1e389a1e41dc387a
Reviewed-on: https://chromium-review.googlesource.com/452696
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/3adae953b60276cc83ca5779db9f60a1b4afbeae/server/cros/dynamic_suite/suite.py

Project Member

Comment 120 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1967df81f97a44581771f7b4be294f3d825ffb95

commit 1967df81f97a44581771f7b4be294f3d825ffb95
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:06 2017

[autotest] Extract get_control_file_path method

BUG= chromium:672348 
TEST=None

Change-Id: Idb2b8d34f59972c55149c558aabb468985467d40
Reviewed-on: https://chromium-review.googlesource.com/453272
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/1967df81f97a44581771f7b4be294f3d825ffb95/server/cros/dynamic_suite/control_file_getter.py

Project Member

Comment 121 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f8b0b70a6e1cddfdb496a40095e20fdcf25bcd34

commit f8b0b70a6e1cddfdb496a40095e20fdcf25bcd34
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:06 2017

[autotest] Extract _parse_control_file_text method

BUG= chromium:672348 
TEST=None

Change-Id: I0b2e2bf1a01941621460a838210176c246e486ac
Reviewed-on: https://chromium-review.googlesource.com/453273
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/f8b0b70a6e1cddfdb496a40095e20fdcf25bcd34/server/cros/dynamic_suite/suite.py

Project Member

Comment 122 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/737021591660ca27cd326f595999e88a27b7ab25

commit 737021591660ca27cd326f595999e88a27b7ab25
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:07 2017

[autotest] Shorten method names

BUG= chromium:672348 
TEST=None

Change-Id: Idc0f61aa31ee5841f3e089848b91da62f44022c3
Reviewed-on: https://chromium-review.googlesource.com/453274
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/737021591660ca27cd326f595999e88a27b7ab25/server/cros/dynamic_suite/suite.py

Project Member

Comment 123 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/df30f4f8f633b73be918b4065e5cbd6c85a2b334

commit df30f4f8f633b73be918b4065e5cbd6c85a2b334
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 27 05:13:05 2017

[autotest] Add abstract methods for documentation

Im not quite fond of the "interface" class (Python uses duck typing),
but if were going to have it, may as well make it work correctly.

BUG= chromium:672348 
TEST=None

Change-Id: Ic6b4bd0927b239efb14bb8fb905655d8a84ce520
Reviewed-on: https://chromium-review.googlesource.com/453298
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/df30f4f8f633b73be918b4065e5cbd6c85a2b334/server/cros/dynamic_suite/control_file_getter.py

Project Member

Comment 124 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b47f59ae809953f944b102bfae3b5b28e075965a

commit b47f59ae809953f944b102bfae3b5b28e075965a
Author: Allen Li <ayatane@chromium.org>
Date: Tue May 02 02:18:21 2017

[autotest] Add retrieve method

BUG= chromium:672348 
TEST=None

Change-Id: I2bf13ac7278ea40b48057cbed2a2c3481022579f
Reviewed-on: https://chromium-review.googlesource.com/453275
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/b47f59ae809953f944b102bfae3b5b28e075965a/server/cros/dynamic_suite/suite.py

Labels: Type-Feature
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 128 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3daffee668c11f11fb2b041d7783185b0c920994

commit 3daffee668c11f11fb2b041d7783185b0c920994
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 07 05:57:39 2017

[autotest] Remove unused variable

BUG= chromium:672348 
TEST=None

Change-Id: I0033c3e76638bd90095ed008252247102fa4c1dd
Reviewed-on: https://chromium-review.googlesource.com/560658
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/3daffee668c11f11fb2b041d7783185b0c920994/site_utils/run_suite.py

Project Member

Comment 129 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5e9c35f5d0bf4f0e42e18d265c790572bfdd802d

commit 5e9c35f5d0bf4f0e42e18d265c790572bfdd802d
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jul 13 18:44:38 2017

[autotest] Clean up main()

BUG= chromium:672348 
TEST=None

Change-Id: I3338de4be49196e3d83ebbdb483d271b6c408cac
Reviewed-on: https://chromium-review.googlesource.com/560660
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/5e9c35f5d0bf4f0e42e18d265c790572bfdd802d/site_utils/run_suite.py

Project Member

Comment 130 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/baecf39441c9d1302cc6e27cc9d9d1e1dfd042b3

commit baecf39441c9d1302cc6e27cc9d9d1e1dfd042b3
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 05:03:31 2017

[autotest] Remove unused var

BUG= chromium:672348 
TEST=None

Change-Id: I5b511749cd09a14b81e6e2f20ba8fa05b043af97
Reviewed-on: https://chromium-review.googlesource.com/560639
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/baecf39441c9d1302cc6e27cc9d9d1e1dfd042b3/scheduler/host_scheduler.py

Project Member

Comment 131 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/175233bd4093ee066f662913bad43ede4ff9ed2b

commit 175233bd4093ee066f662913bad43ede4ff9ed2b
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 05:03:31 2017

[autotest] Make find_hosts_for_jobs a generator

BUG= chromium:672348 
TEST=None

Change-Id: I1e764c41c21dd366cbf5fd89f09a935ed6749498
Reviewed-on: https://chromium-review.googlesource.com/560640
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/175233bd4093ee066f662913bad43ede4ff9ed2b/scheduler/host_scheduler.py

Project Member

Comment 132 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/96c60b989690626f6678497e22678a64a64beb69

commit 96c60b989690626f6678497e22678a64a64beb69
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 05:03:32 2017

[autotest] Print warning about unused suite arguments

BUG= chromium:672348 
TEST=None

Change-Id: I9e75096ab6efc724bfbac98f8919b0433f40ee34
Reviewed-on: https://chromium-review.googlesource.com/562641
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/96c60b989690626f6678497e22678a64a64beb69/server/cros/dynamic_suite/dynamic_suite.py

Project Member

Comment 133 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6f4701094f19a8c32a02ece28697b9a9d0892b77

commit 6f4701094f19a8c32a02ece28697b9a9d0892b77
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 07:02:41 2017

[autotest] Make _SuiteSpec private

This way all of the public members of dynamic_suite.py are suite
functions:

  run_foo_suite(**dargs)

Thus the API is clearly defined.

BUG= chromium:672348 
TEST=None

Change-Id: I1c618a6df1451df2f4011db93d2fe35bf5237811
Reviewed-on: https://chromium-review.googlesource.com/562664
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/6f4701094f19a8c32a02ece28697b9a9d0892b77/server/cros/dynamic_suite/dynamic_suite.py
[modify] https://crrev.com/6f4701094f19a8c32a02ece28697b9a9d0892b77/server/cros/dynamic_suite/dynamic_suite_unittest.py

Project Member

Comment 134 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/344e14f3164d4da8e4a754dc6e6f9a49dae4462e

commit 344e14f3164d4da8e4a754dc6e6f9a49dae4462e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 07:02:42 2017

[autotest] Remove experimental test support

No more experimental tests.

I like how this diff contains more lines removing parameter passing
than removing lines of logic.

BUG= chromium:672348 
TEST=None

Change-Id: Ifb8be5e338db88bfcf6f2bd2b48e11735e083de5
Reviewed-on: https://chromium-review.googlesource.com/564197
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/344e14f3164d4da8e4a754dc6e6f9a49dae4462e/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/344e14f3164d4da8e4a754dc6e6f9a49dae4462e/server/cros/dynamic_suite/dynamic_suite.py

Project Member

Comment 136 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/85ae5df6bcb5309a093fd42db9565ff4b74fabf4

commit 85ae5df6bcb5309a093fd42db9565ff4b74fabf4
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 07:02:44 2017

[autotest] Clean up main() some more

BUG= chromium:672348 
TEST=None

Change-Id: I2407c69a383a9996b6d90d594695ff9b7179b187
Reviewed-on: https://chromium-review.googlesource.com/565895
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/85ae5df6bcb5309a093fd42db9565ff4b74fabf4/site_utils/run_suite.py

Project Member

Comment 137 by bugdroid1@chromium.org, Jul 14 2017

Project Member

Comment 138 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/28be0644681f853acac63654909f67fe6f595697

commit 28be0644681f853acac63654909f67fe6f595697
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jul 18 01:32:38 2017

[autotest] Make buildbot links public

BUG= chromium:672348 
TEST=None

Change-Id: I61b43d3e80dac1192603a7bb6d7fa1ac7f753c64
Reviewed-on: https://chromium-review.googlesource.com/565811
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/28be0644681f853acac63654909f67fe6f595697/site_utils/run_suite.py
[modify] https://crrev.com/28be0644681f853acac63654909f67fe6f595697/site_utils/run_suite_unittest.py

Project Member

Comment 139 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ca96d79728876ae40a360a00f911c5d42f0fc43d

commit ca96d79728876ae40a360a00f911c5d42f0fc43d
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jul 18 07:32:35 2017

[autotest] Remove unused get_bug_link()

BUG= chromium:672348 
TEST=None

Change-Id: If80b7205f66ee2c6ad12a452d26ac5bc8699d284
Reviewed-on: https://chromium-review.googlesource.com/565812
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/ca96d79728876ae40a360a00f911c5d42f0fc43d/site_utils/run_suite.py

Project Member

Comment 140 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1cb3844a3938d7d5f5603829b52340095c15cc8

commit b1cb3844a3938d7d5f5603829b52340095c15cc8
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jul 18 07:32:35 2017

[autotest] Clean up _format_anchor_text()

BUG= chromium:672348 
TEST=None

Change-Id: I7dccf0d9ddc15c4118a1d26e15a2a0af77233bcf
Reviewed-on: https://chromium-review.googlesource.com/566074
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/b1cb3844a3938d7d5f5603829b52340095c15cc8/site_utils/run_suite.py

Project Member

Comment 141 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4e7365eb492f14ccf30cbcac3a09a82e960b4b39

commit 4e7365eb492f14ccf30cbcac3a09a82e960b4b39
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jul 18 07:32:36 2017

[autotest] Split GenerateBuildbotLinks()

BUG= chromium:672348 
TEST=None

Change-Id: I55821cd1d7077edc2487f5d9e23c1a458f8437ca
Reviewed-on: https://chromium-review.googlesource.com/566075
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/4e7365eb492f14ccf30cbcac3a09a82e960b4b39/site_utils/run_suite.py

Project Member

Comment 142 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/133dffdd0fb74d67aace196c490f30c05a7a9f04

commit 133dffdd0fb74d67aace196c490f30c05a7a9f04
Author: Allen Li <ayatane@chromium.org>
Date: Wed Jul 19 21:41:22 2017

[autotest] Factor out job result waiting (re-land)

Re-land due to RPC serialization of set bug

BUG= chromium:672348 
BUG= chromium:743100 
TEST=None

Change-Id: I32eb3782b2d6aa2f74af88e610fbe2865ddb29d6
Reviewed-on: https://chromium-review.googlesource.com/572085
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/133dffdd0fb74d67aace196c490f30c05a7a9f04/server/cros/dynamic_suite/job_status.py
[modify] https://crrev.com/133dffdd0fb74d67aace196c490f30c05a7a9f04/server/cros/dynamic_suite/job_status_unittest.py

Project Member

Comment 143 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cc2054910511c2d1d6894f0fcec8280cd806916e

commit cc2054910511c2d1d6894f0fcec8280cd806916e
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jul 20 07:37:05 2017

[autotest] Add standard return results and merging

BUG= chromium:672348 
TEST=None

Change-Id: I71ac7d3e84e620037700c9ca203843baeb98e776
Reviewed-on: https://chromium-review.googlesource.com/566076
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/cc2054910511c2d1d6894f0fcec8280cd806916e/site_utils/run_suite.py
[modify] https://crrev.com/cc2054910511c2d1d6894f0fcec8280cd806916e/site_utils/run_suite_unittest.py

Project Member

Comment 145 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e406a5eafed5cfedc6b442570a2b99155ac92fd6

commit e406a5eafed5cfedc6b442570a2b99155ac92fd6
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jul 27 20:08:26 2017

[autotest] Split up _record_result()

BUG= chromium:672348 
TEST=None

Change-Id: I960eff3406177bc9afcfe20611f3f9c27a7e00d6
Reviewed-on: https://chromium-review.googlesource.com/565332
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/e406a5eafed5cfedc6b442570a2b99155ac92fd6/server/cros/dynamic_suite/suite.py

Project Member

Comment 147 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c1ce034d8d3814582e2bb34d34ca413e78958323

commit c1ce034d8d3814582e2bb34d34ca413e78958323
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jul 27 20:08:26 2017

[autotest] Move bug-related methods off of Suite

BUG= chromium:672348 
TEST=None

Change-Id: I125156175f012ff1faaee02e895dfb849b750cb7
Reviewed-on: https://chromium-review.googlesource.com/565347
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/c1ce034d8d3814582e2bb34d34ca413e78958323/server/cros/dynamic_suite/suite.py

Project Member

Comment 148 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/91f1ddd486eaf78fbfbd3469091f0023b98609f0

commit 91f1ddd486eaf78fbfbd3469091f0023b98609f0
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jul 27 20:08:27 2017

[autotest] Factor out suite_args evaluation.

The intent is to:

1. Standardize how suite_args is handled (currently it is a special
   snowflake only used by control.suite).  This will be used to pass
   additional arguments to provision suite and potentially other
   suites.
2. Pass suite_args as a dict instead of as a string to be evaluated.
   This is how test_args is passed currently.  This change needs to be
   made also in run_suite.py, but compatibility code needs to be kept
   during the transition.

I feel like channeling Richard and jumping off a bridge.

BUG= chromium:672348 
TEST=None

Change-Id: I85e0bea532d90733a3d391bf328c1d2e09bc79c7
Reviewed-on: https://chromium-review.googlesource.com/567328
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/91f1ddd486eaf78fbfbd3469091f0023b98609f0/test_suites/control.suite_attr_wrapper
[modify] https://crrev.com/91f1ddd486eaf78fbfbd3469091f0023b98609f0/frontend/afe/rpc_interface.py

Project Member

Comment 149 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bf1a4f3ac73cea9eeb3f69275606dae0b545bd8d

commit bf1a4f3ac73cea9eeb3f69275606dae0b545bd8d
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 28 04:39:01 2017

[autotest] Add special provision suite failure handling

BUG= chromium:672348 
TEST=None

Change-Id: I566cd0fb74899e4b1ec987e39750b50c80263072
Reviewed-on: https://chromium-review.googlesource.com/567459
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/bf1a4f3ac73cea9eeb3f69275606dae0b545bd8d/site_utils/run_suite.py

Project Member

Comment 150 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/913e0ffdadd50e1df3d1f774f0cfee4a069c0b19

commit 913e0ffdadd50e1df3d1f774f0cfee4a069c0b19
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 28 04:39:00 2017

[autotest] Pre-evaluate suite_args

See dependent CL.

Also, remove old regression tests.  suite_args has changed and now
takes a dict, so the original regression bug is no longer relevant,
and I do not see a good way to preserve the regression test.

BUG= chromium:672348 
TEST=None
CQ-DEPEND=CL:567328

Change-Id: I4d271c887959285453bc14388a517ff086ef45c9
Reviewed-on: https://chromium-review.googlesource.com/567460
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/913e0ffdadd50e1df3d1f774f0cfee4a069c0b19/site_utils/run_suite.py
[modify] https://crrev.com/913e0ffdadd50e1df3d1f774f0cfee4a069c0b19/site_utils/run_suite_unittest.py

Project Member

Comment 152 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564

commit 9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Jul 28 08:04:31 2017

Revert "[autotest] Factor out suite_args evaluation."

This reverts commit 91f1ddd486eaf78fbfbd3469091f0023b98609f0.

BUG= chromium:749971 ,  chromium:672348 
TEST=None

Change-Id: I02bf08d33e09c9c27422aecefce404d7826728fa
Reviewed-on: https://chromium-review.googlesource.com/590935
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564/test_suites/control.suite_attr_wrapper
[modify] https://crrev.com/9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564/frontend/afe/rpc_interface.py

Project Member

Comment 153 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/968e768cdbe91dba06998210965f190b1dd94c99

commit 968e768cdbe91dba06998210965f190b1dd94c99
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Jul 28 08:13:50 2017

Revert "[autotest] Pre-evaluate suite_args"

This reverts commit 913e0ffdadd50e1df3d1f774f0cfee4a069c0b19.

BUG= chromium:749971 ,  chromium:672348 
TEST=None

Change-Id: I66248a6e8c43c9182ce09b8e0c3b7bd804a05c72
Reviewed-on: https://chromium-review.googlesource.com/590937
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/968e768cdbe91dba06998210965f190b1dd94c99/site_utils/run_suite.py
[modify] https://crrev.com/968e768cdbe91dba06998210965f190b1dd94c99/site_utils/run_suite_unittest.py

Project Member

Comment 154 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bab86262598a207a5187721fc4c5e390780a5169

commit bab86262598a207a5187721fc4c5e390780a5169
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Jul 28 08:14:17 2017

Revert "[autotest] Add special provision suite failure handling"

This reverts commit bf1a4f3ac73cea9eeb3f69275606dae0b545bd8d.

BUG= chromium:749971 ,  chromium:672348 
TEST=None

Change-Id: Ic2b06a524d9c3bd35f0160cf0f9c8ba1ac92226e
Reviewed-on: https://chromium-review.googlesource.com/590938
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/bab86262598a207a5187721fc4c5e390780a5169/site_utils/run_suite.py

Project Member

Comment 155 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/422f24b6692f1e61f124bbae11c779d8cde8dcec

commit 422f24b6692f1e61f124bbae11c779d8cde8dcec
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 29 02:51:20 2017

[autotest] Add special provision suite failure handling (reland)

BUG= chromium:672348 
TEST=None

Change-Id: If508b49484eb80f7d5e6be22f22f24283bdf9db9
Reviewed-on: https://chromium-review.googlesource.com/591883
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/422f24b6692f1e61f124bbae11c779d8cde8dcec/site_utils/run_suite.py

Project Member

Comment 156 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ecdba6c4adf7064c6d041f33bafcbde38e62cd1e

commit ecdba6c4adf7064c6d041f33bafcbde38e62cd1e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 11 05:47:20 2017

[autotest] Pre-evaluate suite_args (reland)

See dependent CL.

Also, remove old regression tests.  suite_args has changed and now
takes a dict, so the original regression bug is no longer relevant,
and I do not see a good way to preserve the regression test.

BUG= chromium:672348 
BUG= chromium:749971 
TEST=None
CQ-DEPEND=CL:567328

Change-Id: Ib268c9a124f9b2242b1f6f1db46e645eb450825a
Reviewed-on: https://chromium-review.googlesource.com/591884
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/ecdba6c4adf7064c6d041f33bafcbde38e62cd1e/site_utils/run_suite.py
[modify] https://crrev.com/ecdba6c4adf7064c6d041f33bafcbde38e62cd1e/site_utils/run_suite_unittest.py

Project Member

Comment 157 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e

commit e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 11 05:47:22 2017

[autotest] Factor out suite_args evaluation (reland)

The intent is to:

1. Standardize how suite_args is handled (currently it is a special
   snowflake only used by control.suite).  This will be used to pass
   additional arguments to provision suite and potentially other
   suites.
2. Pass suite_args as a dict instead of as a string to be evaluated.
   This is how test_args is passed currently.  This change needs to be
   made also in run_suite.py, but compatibility code needs to be kept
   during the transition.

I feel like channeling Richard and jumping off a bridge.

BUG= chromium:672348 
BUG= chromium:749971 
TEST=None

Change-Id: Ic67f21366cc0731e4fd73a7e29135be2bb454229
Reviewed-on: https://chromium-review.googlesource.com/591885
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e/test_suites/control.suite_attr_wrapper
[modify] https://crrev.com/e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e/frontend/afe/rpc_interface.py

Project Member

Comment 158 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/337e124ffb799d96648b356df28b329a9410045e

commit 337e124ffb799d96648b356df28b329a9410045e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 11 05:47:22 2017

[autotest] Add num control to provision suite (reland)

BUG= chromium:672348 
BUG= chromium:749971 
TEST=None

Change-Id: I1934c7172eaaf677f3c3a35e65e2dcb85b26f228
Reviewed-on: https://chromium-review.googlesource.com/591886
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/337e124ffb799d96648b356df28b329a9410045e/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/337e124ffb799d96648b356df28b329a9410045e/server/cros/dynamic_suite/dynamic_suite.py

What's the status of this?
I got bitten by backward compatibility issues plumbing the arguments for the provision suite through test_that, run_suite, AFE RPC, and control files.  I switched gears to the Autotest refactor while I waited for the dust to settle.  It appears to be stable now since I have not heard of any issues since then.

I have lost track of all the bugs, but the main tracking bug for that is https://bugs.chromium.org/p/chromium/issues/detail?id=758427

Now that the plumbing is in place, all that remains is "just" adding a build stage that uses run_suite to run the provision suite.
Status? I believe the next step is to enable this on some paladin builder.
Pending addition of no-op stage that will be used to run provision suite: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/722199
for the record, https://chromium-review.googlesource.com/c/chromiumos/chromite/+/722199 landed but commit message pointed to the wrong bug #

What are the results with auron-paladin?
Apparently auron-paladin does not run HWTests?  I'm moving it to auron_paine-paladin which does run HWTests right now.

https://chromium-review.googlesource.com/c/chromiumos/chromite/+/734018
Project Member

Comment 165 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3c749048aa80deb8194c1ac785858571ad88c96f

commit 3c749048aa80deb8194c1ac785858571ad88c96f
Author: Allen Li <ayatane@chromium.org>
Date: Tue Oct 24 05:39:03 2017

cbuildbot: Move provision suite from auron to auron_paine

Apparently auron does not run HWTest?

BUG= chromium:672348 
TEST=None

Change-Id: I2253ed0d03cc3096aa8227e9ba4bd38378bb704a
Reviewed-on: https://chromium-review.googlesource.com/734018
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/3c749048aa80deb8194c1ac785858571ad88c96f/cbuildbot/config_dump.json
[modify] https://crrev.com/3c749048aa80deb8194c1ac785858571ad88c96f/cbuildbot/chromeos_config.py

https://luci-milo.appspot.com/buildbot/chromeos/auron_paine-paladin/1189

Suite job: FAIL: __init__() got an unexpected keyword argument 'count'
Project Member

Comment 167 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4ae51d3000a7ab9ca7d6f230fb5ddb033f7ffb6c

commit 4ae51d3000a7ab9ca7d6f230fb5ddb033f7ffb6c
Author: Allen Li <ayatane@chromium.org>
Date: Wed Oct 25 05:47:51 2017

[autotest] Remove invalid provision suite argument

count was the old num_required.  I probably overlooked it given the
exciting number of arguments here.

TEST=None
BUG= chromium:672348 

Change-Id: I569181de3217ce31e8b023046631c461668c1129
Reviewed-on: https://chromium-review.googlesource.com/735535
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/4ae51d3000a7ab9ca7d6f230fb5ddb033f7ffb6c/server/cros/dynamic_suite/dynamic_suite.py

Blocking: 779147
Labels: Chase
Cc: ayatane@chromium.org
 Issue 779147  has been merged into this issue.
Suite is running in prod.
Somehow only provisioning some of the required DUTs.

Still keep chasing.
Project Member

Comment 172 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0ef3cc704dfb0dede8ccd53f78e66460440cc7a2

commit 0ef3cc704dfb0dede8ccd53f78e66460440cc7a2
Author: Allen Li <ayatane@chromium.org>
Date: Thu Nov 09 06:21:54 2017

Exclude provision suite from subsystems

BUG= chromium:672348 
TEST=CQ

Change-Id: Iedaa9050c940aca7ef527302c3b9d2d1054d30de
Reviewed-on: https://chromium-review.googlesource.com/756182
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/0ef3cc704dfb0dede8ccd53f78e66460440cc7a2/cbuildbot/commands.py
[modify] https://crrev.com/0ef3cc704dfb0dede8ccd53f78e66460440cc7a2/cbuildbot/stages/test_stages.py

Project Member

Comment 173 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/637683ba15820ed00b34c0ec0cad494de8b5c458

commit 637683ba15820ed00b34c0ec0cad494de8b5c458
Author: Allen Li <ayatane@chromium.org>
Date: Fri Nov 10 22:05:42 2017

[autotest] Link bug in TODO comment

BUG= chromium:672348 
TEST=None

Change-Id: Iad3ddc2e7748292fcb599307203969859a3b2a9e
Reviewed-on: https://chromium-review.googlesource.com/756331
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/637683ba15820ed00b34c0ec0cad494de8b5c458/site_utils/run_suite.py

Project Member

Comment 174 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/977760b97d8da1184548f2d1ca7ffd537930d7c1

commit 977760b97d8da1184548f2d1ca7ffd537930d7c1
Author: Allen Li <ayatane@chromium.org>
Date: Fri Nov 10 22:05:42 2017

[autotest] Add provision suite constant

BUG= chromium:672348 
TEST=None

Change-Id: I811928da9853fc1c03fe40c0ac30af5de398c73a
Reviewed-on: https://chromium-review.googlesource.com/756368
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/977760b97d8da1184548f2d1ca7ffd537930d7c1/site_utils/run_suite.py

Project Member

Comment 175 by bugdroid1@chromium.org, Nov 10 2017

awaiting prod push
Project Member

Comment 177 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/42e511e3484aa9197e864604b156dd33b41772be

commit 42e511e3484aa9197e864604b156dd33b41772be
Author: Allen Li <ayatane@chromium.org>
Date: Wed Nov 15 00:03:21 2017

[autotest] Add logging for provision suite

BUG= chromium:672348 
TEST=CQ

Change-Id: Iadac9c5705cf58fa93d18ac81273ac86fad2bd5f
Reviewed-on: https://chromium-review.googlesource.com/767621
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/42e511e3484aa9197e864604b156dd33b41772be/server/cros/dynamic_suite/suite.py

Project Member

Comment 178 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0c0e77617ff5786ecf9d4f2e1d69c586bf349ea3

commit 0c0e77617ff5786ecf9d4f2e1d69c586bf349ea3
Author: Allen Li <ayatane@chromium.org>
Date: Sat Nov 18 04:18:33 2017

[autotest] Filter out cros_version when finding DUTs to provision

BUG= chromium:672348 
TEST=None

Change-Id: I64ddc78acde41216a8738aa8d9b7fc76ee791a90
Reviewed-on: https://chromium-review.googlesource.com/777605
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/0c0e77617ff5786ecf9d4f2e1d69c586bf349ea3/server/cros/dynamic_suite/suite.py

Waiting for push to prod for DUT detection fix
Rolling out to CQ now...
Project Member

Comment 181 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b4e36d56a3ac2e011d1221be0383ca67d32b0221

commit b4e36d56a3ac2e011d1221be0383ca67d32b0221
Author: Allen Li <ayatane@chromium.org>
Date: Tue Nov 28 06:50:42 2017

Enable provision suite everywhere

BUG= chromium:672348 
TEST=Already running on auron_paine-paladin

Change-Id: I4b1203379354191691ad694fcf83a3d8a23be0cc
Reviewed-on: https://chromium-review.googlesource.com/747811
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/b4e36d56a3ac2e011d1221be0383ca67d32b0221/cbuildbot/config_dump.json
[modify] https://crrev.com/b4e36d56a3ac2e011d1221be0383ca67d32b0221/cbuildbot/chromeos_config.py

Project Member

Comment 182 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bee6d47114de87a19f17433d4882844ec8109b86

commit bee6d47114de87a19f17433d4882844ec8109b86
Author: Allen Li <ayatane@chromium.org>
Date: Thu Nov 30 02:04:48 2017

Assign provision suite in paladin hwtest assignment

I didnt realize that this was actually used to assign HWTests to
paladins.  Its obvious in hindsight of course.

BUG= chromium:672348 
TEST=None

Change-Id: I6f2b2f1ccfa480e663524e1d744e0a594bf5fd4c
Reviewed-on: https://chromium-review.googlesource.com/793893
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/bee6d47114de87a19f17433d4882844ec8109b86/cbuildbot/config_dump.json
[modify] https://crrev.com/bee6d47114de87a19f17433d4882844ec8109b86/cbuildbot/chromeos_config.py

Blocking: 785381
This would help with tryjobs that launch hwtest into pool:suites. They often suffer from poor pool quality.
The way provision suite is implemented won't work for tryjobs/pool:suites (I think).  I'll have to dive again into the host scheduling code, but my instinct is that it would require rewriting the host scheduling code.  The implementation is a hack that only works for jobs that own a pool of DUTs exclusively.
Labels: -Chase
Done for paladins. Needs to be tweaked for tryjobs.
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Components: -Infra>Client>ChromeOS>CI Infra>Client>ChromeOS>Test
Status: Fixed (was: Started)
Showing comments 90 - 189 of 189 Older

Sign in to add a comment