New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672338 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 666097



Sign in to add a comment

[Findit] Convert build number to git hash & commit position

Project Member Reported by lijeffrey@chromium.org, Dec 8 2016

Issue description

Suspected flake build number can map to a git hash that should be easily accessible to the user on flake checker result pages
 

Comment 1 by st...@chromium.org, Dec 8 2016

This is more than just the suspected flake build number. We'd better do this for all the build numbers in the diagram. So later the X axis could be commit position instead of build number, while the Y axis stays the same as pass rate.

Comment 2 by st...@chromium.org, Dec 8 2016

For the mapping, it is build-number -> commit-position & git hash.

commit-position is for UI, while git hash is for further analysis.
Status: Started (was: Assigned)

Comment 4 by st...@chromium.org, Dec 9 2016

Blocking: 666097

Comment 5 by st...@chromium.org, Dec 14 2016

Summary: [Findit] Convert build number to git hash & commit position (was: [Findit] Convert suspected build number to git hash)

Comment 6 by st...@chromium.org, Dec 14 2016

Blocking: 672724
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e2172016df4fce6ce4963d978e36a9bca814b402

commit e2172016df4fce6ce4963d978e36a9bca814b402
Author: lijeffrey <lijeffrey@chromium.org>
Date: Thu Dec 15 22:18:30 2016

[Findit] Flake Checker: Extract commit position and git hash and display to UI for each analyzed build

Each analyzed build's commit position and git hash are now extracted, with links to the commits available in the mouse-over UI in the graph.

Sample UI: https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/check-flake?master_name=chromium.mac&builder_name=Mac10.11%20Tests&build_number=3982&step_name=browser_tests%20on%20Mac-10.11&test_name=ContentVerifierPolicyTest.PolicyCorruptedOnStartup

BUG= 672338 

Review-Url: https://codereview.chromium.org/2563383002

[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/templates/flake/result.html
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/waterfall/build_info.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/waterfall/buildbot.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/waterfall/test/buildbot_test.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/e2172016df4fce6ce4963d978e36a9bca814b402/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

Comment 8 by st...@chromium.org, Dec 15 2016

Status: Fixed (was: Started)
Blocking: -672724
Status: Verified (was: Fixed)

Sign in to add a comment