New issue
Advanced search Search tips

Issue 672334 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 677569
issue 684761
issue 691620
issue 725119



Sign in to add a comment

Experiment with fetching a warm up URL using data reduction proxy

Project Member Reported by tbansal@chromium.org, Dec 8 2016

Issue description

We should experiment with fetching a warm up URL using data reduction proxy. When QUIC is in use, fetching the warm up URL will allow Chrome to get a valid Source Address Token (SKT). So, next time Chrome fetches a user-initiated request via data reduction proxy, it can get 0-RTT using the cached SKT.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc6d7167dc40c488fd948e8601584bcbcec3ce6

commit 3bc6d7167dc40c488fd948e8601584bcbcec3ce6
Author: tbansal <tbansal@chromium.org>
Date: Mon Dec 12 18:42:14 2016

Fetch a warmup URL if data reduction proxy is enabled

Fetch a warmup URL if data reduction proxy (DRP) is enabled. The fetching
of the warm up URL is disabled by default, and enabled only via the
field trial.

BUG= 672334 

Review-Url: https://codereview.chromium.org/2503273002
Cr-Commit-Position: refs/heads/master@{#437905}

[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/3bc6d7167dc40c488fd948e8601584bcbcec3ce6/tools/metrics/histograms/histograms.xml

Blockedon: 677569
Blockedon: 684761
Blockedon: 691620
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aedc88255e58fb8c4db948c47efa11ddea24b43c

commit aedc88255e58fb8c4db948c47efa11ddea24b43c
Author: tbansal <tbansal@chromium.org>
Date: Wed Feb 22 21:03:59 2017

Add json config for field group that fetches warmup URL

BUG= 672334 

Review-Url: https://codereview.chromium.org/2707553003
Cr-Commit-Position: refs/heads/master@{#452196}

[modify] https://crrev.com/aedc88255e58fb8c4db948c47efa11ddea24b43c/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fde4f2a798de7216e6e20057a227f431df761fd

commit 6fde4f2a798de7216e6e20057a227f431df761fd
Author: tbansal <tbansal@chromium.org>
Date: Fri May 19 21:40:21 2017

Add DRPUseQuic param to testing config

For DataReductionProxyUseQuic experiment, add the "enable_warmup" param
to the testing config.

BUG= 672334 

Review-Url: https://codereview.chromium.org/2888283007
Cr-Commit-Position: refs/heads/master@{#473336}

[modify] https://crrev.com/6fde4f2a798de7216e6e20057a227f431df761fd/testing/variations/fieldtrial_testing_config.json

Blockedon: 725119
Labels: -Pri-3 M-62 Pri-2
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8723f3d8e0283c8548d540202bcbb5fc75fb4a96

commit 8723f3d8e0283c8548d540202bcbb5fc75fb4a96
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Sep 15 17:50:28 2017

Enable data reduction proxy (DRP) connection experiments

Enable the experiment to fetch preconnect URL and to
use QUIC for non-core proxies by default.

Bug:  672334 ,720163
Change-Id: I4cf96a2af7dfb42d035dffe7684bde03456df8ac
Reviewed-on: https://chromium-review.googlesource.com/666037
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502298}
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/content/browser/content_resource_type_provider_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
[modify] https://crrev.com/8723f3d8e0283c8548d540202bcbb5fc75fb4a96/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h

Labels: -M-62 M-60
Status: Fixed (was: Started)
This is now enabled for M-60.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8bdebfdc6dca1a6a283a32ba946487053d821de

commit b8bdebfdc6dca1a6a283a32ba946487053d821de
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Oct 31 21:09:37 2017

Remove field trial testing config for DataReductionProxyUseQuic experiment
since the experiment is now enabled by default

Bug: 	 672334 
Change-Id: I900bba6e31a6bdb2d2251e3758a1bba6b6c659b6
Reviewed-on: https://chromium-review.googlesource.com/747561
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512953}
[modify] https://crrev.com/b8bdebfdc6dca1a6a283a32ba946487053d821de/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment