Clicking a decoration a second time should dismiss its dialog |
||||
Issue descriptionCurrently if you click an omnibox decoration and its dialog appears, clicking the decoration a second time does not dismiss the dialog. The Views decoration code should detect if the dialog is currently visible and dismiss it.
,
Dec 11 2016
My fix was only for the page info dialog (lock icon). I didn't have a chance to get to the omnibox decorations. The page info dialog correctly dismisses on a second click when it's opened.
,
Dec 12 2016
Further clarification: my fix was for Cocoa, and I based it on what the views page info dialog implements. I assumed at the time that MacViews would *just work* since it worked in Views already - perhaps it needs some more work to get it there.
,
Apr 12 2017
Marking available, since spqchan@ is working on other stuff right now.
,
Apr 12 2017
I have a fix for it :) This CL will fix the issue https://codereview.chromium.org/2720183002/ It's just taking a while to work on because my Windows laptop died. I just got my replacement so hopefully I can get to it soon
,
May 22 2017
The CL has landed
,
May 30 2017
Thank you for fixing this! There seem to be issues with this with secondary-ui-md enabled. Do you know if there's a bug filed about that?
,
May 30 2017
AFAIK, no |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Dec 11 2016Cc: dominickn@chromium.org