New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672333 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 603386


Show other hotlists

Hotlists containing this issue:
MacViews-Task-Queue


Sign in to add a comment

Clicking a decoration a second time should dismiss its dialog

Project Member Reported by shrike@chromium.org, Dec 8 2016

Issue description

Currently if you click an omnibox decoration and its dialog appears, clicking the decoration a second time does not dismiss the dialog. The Views decoration code should detect if the dialog is currently visible and dismiss it.
 

Comment 1 by tapted@chromium.org, Dec 11 2016

Blocking: 603386
Cc: dominickn@chromium.org
This is very similar to  Issue 59289 . There was a recent ish fix in 

Review-Url: https://codereview.chromium.org/2041723002
Cr-Commit-Position: refs/heads/master@{#398721}
[Mac] Dismiss an open page info dialog when the location icon is clicked.

But it seems to have regressed 
My fix was only for the page info dialog (lock icon). I didn't have a chance to get to the omnibox decorations. The page info dialog correctly dismisses on a second click when it's opened.
Further clarification: my fix was for Cocoa, and I based it on what the views page info dialog implements. I assumed at the time that MacViews would *just work* since it worked in Views already - perhaps it needs some more work to get it there.
Labels: MacViews-Dialogs
Owner: ----
Status: Available (was: Assigned)
Marking available, since spqchan@ is working on other stuff right now.
Owner: spqc...@chromium.org
Status: Started (was: Available)
I have a fix for it :)

This CL will fix the issue https://codereview.chromium.org/2720183002/
It's just taking a while to work on because my Windows laptop died. I just got my replacement so hopefully I can get to it soon
Status: Fixed (was: Started)
The CL has landed

Comment 7 by shrike@chromium.org, May 30 2017

Thank you for fixing this!

There seem to be issues with this with secondary-ui-md enabled. Do you know if there's a bug filed about that?
AFAIK, no

Sign in to add a comment