Doing a "git cl upload" doesn't ask for new patch info |
||||
Issue descriptionAffected Version: What steps will reproduce the problem? 1. Have an open CL 2. Do a "git cl upload" 3. Don't get asked to describe what you are uploading. What is the expected output? You get asked what you are uploading like in Rietveld (so I can say "This patch is still WIP and similar") What do you see instead? It just uploaded..... Please provide any additional information below.
,
Dec 8 2016
,
Dec 8 2016
,
Dec 13 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a5a1eea537ca2d82a0296dd703e038af7eee2fde commit a5a1eea537ca2d82a0296dd703e038af7eee2fde Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Dec 14 14:21:32 2016 Revert "Generate patchset name from commit subject" This reverts commit 947f2ee80883852e73fbe6fb2b624f354cebd800. Reason for revert: unnecessarily sets the title for the first upload, which isn't done for Rietveld. Original change's description: > Generate patchset name from commit subject > > BUG= 672332 > > Change-Id: If9c662f11b217a52cac7c9c47ad9f3d978148c2e > Reviewed-on: https://chromium-review.googlesource.com/419330 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org BUG= 672332 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I9dcec1b02c8f16ceca8338acef4a1fc174aef35c Reviewed-on: https://chromium-review.googlesource.com/419517 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/a5a1eea537ca2d82a0296dd703e038af7eee2fde/git_cl.py [modify] https://crrev.com/a5a1eea537ca2d82a0296dd703e038af7eee2fde/tests/git_cl_test.py
,
Dec 14 2016
Unfortunately the fix also applies for the first ever upload, in which case it's redundant, as I've just been asked to edit description for the CL anyway. I've reverted the fix in https://chromium-review.googlesource.com/c/419517. Sorry, Aaron :(
,
Dec 15 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9b713dd18b0674a362e723d81e3a378d657e54db commit 9b713dd18b0674a362e723d81e3a378d657e54db Author: Aaron Gable <agable@chromium.org> Date: Thu Dec 15 00:04:21 2016 Generate patchset name from commit subject This is a reland of 947f2ee80883852e73fbe6fb2b624f354cebd800, which was reverted in a5a1eea537ca2d82a0296dd703e038af7eee2fde BUG= 672332 Change-Id: If33c54e500fbeac11f60d81a19549880506c63d8 Reviewed-on: https://chromium-review.googlesource.com/419737 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9b713dd18b0674a362e723d81e3a378d657e54db/git_cl.py [modify] https://crrev.com/9b713dd18b0674a362e723d81e3a378d657e54db/tests/git_cl_test.py
,
Dec 15 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by andyb...@chromium.org
, Dec 8 2016