New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672330 link

Starred by 1 user
Status: Fixed
Owner:
█ jwanda@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Keyboard Shortcut strings are not long enough.

Project Member Reported by jwanda@chromium.org, Dec 8 2016 
Chrome Version: 57.0.2975.0
OS: Android

Translators want an increase from the 50 character limit. We're able to increase it to 55 without completely losing the formatting of the Keyboard Shortcut Layout
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf3ad17dd80ab1d8428f62d5024a969823345f5

commit cbf3ad17dd80ab1d8428f62d5024a969823345f5
Author: jwanda <jwanda@chromium.org>
Date: Thu Dec 08 03:55:39 2016

Raising the char limit of KBShortcuts to 55

A few translators asked us to raise the limit. While some of them are
asking for 60 characters, the highest we can go is 55 before it's nearly
guranteed that the shortcuts will start to lose their optimal
formatting.

While working on this bug I also noticed that the zoom in shortcut
didn't appear for some reason. Added a fix for this.

BUG= 672330 

Review-Url: https://codereview.chromium.org/2563503003
Cr-Commit-Position: refs/heads/master@{#437170}

[modify] https://crrev.com/cbf3ad17dd80ab1d8428f62d5024a969823345f5/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
[modify] https://crrev.com/cbf3ad17dd80ab1d8428f62d5024a969823345f5/chrome/android/java/strings/android_chrome_strings.grd

Comment 2 by jwanda@chromium.org, Dec 8 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment