New issue
Advanced search Search tips

Issue 672314 link

Starred by 1 user
Status: Archived
Owner:
benchan@chromium.org
Closed: Dec 2016
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Update CrOS code to use std::unique_ptr instead of the deprecated scoped_ptr

Project Member Reported by benchan@chromium.org, Dec 8 2016 
scoped_ptr in chrome/base has been deprecated and removed ( issue 554298 ). libchrome in CrOS carries a patch (libchrome-395517-CHROMIUMOS-add-scoped-ptr.patch) that simply aliases scoped_ptr to std::unique_ptr for backward compatibility. However, scoped_ptr is still used in various CrOS code base and should be updated to std::unique_ptr.

Comment 1 by benchan@chromium.org, Dec 8 2016

Status: Started (was: Assigned)

Comment 2 by vapier@chromium.org, Dec 8 2016 

we can drop libchrome-395517-CHROMIUMOS-add-scoped-ptr.patch once it finishes!
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8aa2b208e37fb9693ac3af74e2784c43c5a49c05

commit 8aa2b208e37fb9693ac3af74e2784c43c5a49c05
Author: Ben Chan <benchan@chromium.org>
Date: Thu Dec 08 01:12:03 2016

login: remove unnecessary inclusions of base/memory/scoped_ptr.h

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: I0a88d71663e667d08e39ce8f546205e13e7cf9d1
Reviewed-on: https://chromium-review.googlesource.com/417712
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/mock_nss_util.cc
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/chrome_setup.cc
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/mock_process_manager_service.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/child_exit_handler.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/server_backed_state_key_generator_unittest.cc
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/process_manager_service_interface.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/mock_nss_util.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/regen_mitigator.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/system_utils_impl.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/regen_mitigator_unittest.cc
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/nss_util.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/system_utils.h
[modify] https://crrev.com/8aa2b208e37fb9693ac3af74e2784c43c5a49c05/login_manager/policy_key.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f57c19c8f254e00377944d6a6a504d839f4a3e18

commit f57c19c8f254e00377944d6a6a504d839f4a3e18
Author: Ben Chan <benchan@chromium.org>
Date: Thu Dec 08 01:14:49 2016

login: replace scoped_ptr with std::unique_ptr

scoped_ptr has been deprecated and removed from chrome/base in favor of
std::unique_ptr from C++11. libchrome currently maintains a local patch
that simply aliases scoped_ptr as std::unique_ptr. This CL mostly does a
mechanic replacement of scoped_ptr with std::unique_ptr in the
login-manager code, and in some cases, simplifies the code by removing
unnecessary std::unique_ptr constructor calls or using base::MakeUnique.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: If377ce21f8e14f824d9b1ff25b137bb746e666f6
Reviewed-on: https://chromium-review.googlesource.com/417713
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/nss_util.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/liveness_checker_impl_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/key_generator.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/user_policy_service.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/generator_job.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/user_policy_service.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_dbus_adaptor.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/mock_object_proxy.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/keygen.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/stub_upstart_signal_emitter.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_service.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/policy_key.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_service.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/child_job.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_impl.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_process_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/user_policy_service_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_main.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/login_metrics_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/fake_browser_job.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/fake_generator_job.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/user_policy_service_factory.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_impl_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/systemd_unit_starter.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/policy_key_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/systemd_unit_starter.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/init_daemon_controller.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/keygen_worker.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/device_local_account_policy_service.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/login_metrics.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/key_generator_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/generator_job.h
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_impl.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/key_generator.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/fake_generator_job.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/upstart_signal_emitter.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/nss_util_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/session_manager_dbus_adaptor.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/browser_job_unittest.cc
[modify] https://crrev.com/f57c19c8f254e00377944d6a6a504d839f4a3e18/login_manager/upstart_signal_emitter.h
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e2a8602306a5da15e8aeb19e1e2356c1bfa567e7

commit e2a8602306a5da15e8aeb19e1e2356c1bfa567e7
Author: Ben Chan <benchan@chromium.org>
Date: Wed Dec 07 23:21:38 2016

debugd: replace scoped_ptr with std::unique_ptr

scoped_ptr from libchrome has been deprecated in favor of C++11
std::unique_ptr.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: I6d26a9b232a3c8c260004c1621d1beb1f8500fbb
Reviewed-on: https://chromium-review.googlesource.com/417982
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e2a8602306a5da15e8aeb19e1e2356c1bfa567e7/debugd/src/helpers/wimax_status.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/38c94a7132b5844c5836b8ad1e7cfa420b5b3348

commit 38c94a7132b5844c5836b8ad1e7cfa420b5b3348
Author: Ben Chan <benchan@chromium.org>
Date: Wed Dec 07 23:26:39 2016

permission_broker: replace scoped_ptr with std::unique_ptr

scoped_ptr from libchrome has been deprecated in favor of C++11
std::unique_ptr.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: Icde580641043eb9ea346818ec13b553950f15409
Reviewed-on: https://chromium-review.googlesource.com/418002
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/38c94a7132b5844c5836b8ad1e7cfa420b5b3348/permission_broker/deny_claimed_usb_device_rule.cc
[modify] https://crrev.com/38c94a7132b5844c5836b8ad1e7cfa420b5b3348/permission_broker/udev_scopers.h
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c8c4d0c934166fffa16fca6908177e9e9cba2760

commit c8c4d0c934166fffa16fca6908177e9e9cba2760
Author: Ben Chan <benchan@chromium.org>
Date: Thu Dec 08 19:15:20 2016

lorgnette: replace scoped_ptr with std::unique_ptr

scoped_ptr from libchrome has been deprecated in favor of C++11
std::unique_ptr.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: If9e2082aa39296dd1e1d12ed6225340281258815
Reviewed-on: https://chromium-review.googlesource.com/418012
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c8c4d0c934166fffa16fca6908177e9e9cba2760/lorgnette/manager_unittest.cc
[modify] https://crrev.com/c8c4d0c934166fffa16fca6908177e9e9cba2760/lorgnette/firewall_manager.h
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ddb82d57c60632fb519798fed31d8f33d85512cb

commit ddb82d57c60632fb519798fed31d8f33d85512cb
Author: Ben Chan <benchan@chromium.org>
Date: Thu Dec 08 19:07:43 2016

gobi-cromo-plugin: replace scoped_ptr with std::unique_ptr

scoped_ptr from libchrome has been deprecated in favor of C++11
std::unique_ptr.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: If4022473a7959fba95f202c3f6becb0d52dee0d2
Reviewed-on: https://chromium-review.googlesource.com/418029
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ddb82d57c60632fb519798fed31d8f33d85512cb/gobi-cromo-plugin/gobi_sdk_wrapper.h
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/589efaf4ebc56028f6c4b5ef067517b825b877a2

commit 589efaf4ebc56028f6c4b5ef067517b825b877a2
Author: Ben Chan <benchan@chromium.org>
Date: Thu Dec 08 19:04:09 2016

crash: remove unnecessary inclusion of base/memory/scoped_ptr.h

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: I0b5d95999826ccc9cde5760f0bbd04be81985584
Reviewed-on: https://chromium-review.googlesource.com/418055
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/589efaf4ebc56028f6c4b5ef067517b825b877a2/crash-reporter/crash_collector.h
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f019be1fe3689179071c4e861b8e8c11543b4aa4

commit f019be1fe3689179071c4e861b8e8c11543b4aa4
Author: Ben Chan <benchan@chromium.org>
Date: Thu Dec 08 19:12:37 2016

app_shell_launcher: replace scoped_ptr with std::unique_ptr

scoped_ptr from libchrome has been deprecated in favor of C++11
std::unique_ptr.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: Ieb4496ffcafc1eb9ffd0eba6e9b367f7bcc21e92
Reviewed-on: https://chromium-review.googlesource.com/418056
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/f019be1fe3689179071c4e861b8e8c11543b4aa4/app_shell_launcher/app_shell_launcher.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0

commit c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0
Author: Ben Chan <benchan@chromium.org>
Date: Fri Dec 09 05:21:16 2016

glbench: replace scoped_ptr with std::unique_ptr

scoped_ptr from libchrome has been deprecated in favor of C++11
std::unique_ptr.

BUG= chromium:672314 
TEST=Run unit tests.

Change-Id: I0f71641e2be379c2a0efe80e1b4e7b303610bf20
Reviewed-on: https://chromium-review.googlesource.com/418397
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/texturetest.h
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/readpixeltest.cc
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/glinterface.h
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/png_helper.cc
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/waffle_stuff.cc
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/glx_stuff.cc
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/testbase.cc
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/yuvtest.cc
[modify] https://crrev.com/c9faddb4a9c94f7ec477fea7f32ce9c4fa34c8d0/client/deps/glbench/src/egl_stuff.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/easy-unlock-crypto/+/3e725932344eeb1cae8b4139666f538d12bcf4ff

commit 3e725932344eeb1cae8b4139666f538d12bcf4ff
Author: Ben Chan <benchan@chromium.org>
Date: Fri Dec 09 04:58:29 2016
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/thermald/+/7a22c8afd07eaddb5851a6cfb7fbade5626f2fd1

commit 7a22c8afd07eaddb5851a6cfb7fbade5626f2fd1
Author: Ben Chan <benchan@chromium.org>
Date: Fri Dec 09 04:47:47 2016
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/609cb79ecaa27ab1b09bc41034501d048614d4e2

commit 609cb79ecaa27ab1b09bc41034501d048614d4e2
Author: Ben Chan <benchan@chromium.org>
Date: Tue Dec 13 05:35:58 2016

Remove remaining references to scoped_ptr.

The last uprev of libchrome to r395517 missed some of the "scoped_ptr to
std::unique_ptr" changes done in http://crrev.com/386228.

BUG= chromium:672314 
TEST=Trybot run on paladin and release builders.

Change-Id: Ieb0d6a59e0f122e63d4a986756f2764b5465018b
Reviewed-on: https://chromium-review.googlesource.com/419143
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/609cb79ecaa27ab1b09bc41034501d048614d4e2/crypto/rsa_private_key.cc
[modify] https://crrev.com/609cb79ecaa27ab1b09bc41034501d048614d4e2/crypto/signature_creator_nss.cc
[modify] https://crrev.com/609cb79ecaa27ab1b09bc41034501d048614d4e2/crypto/hmac_nss.cc
[modify] https://crrev.com/609cb79ecaa27ab1b09bc41034501d048614d4e2/crypto/rsa_private_key_nss.cc
[modify] https://crrev.com/609cb79ecaa27ab1b09bc41034501d048614d4e2/crypto/hmac.cc

Comment 16 by benchan@chromium.org, Dec 15 2016 

References to scoped_ptr are removed from Chrome OS code, but unfortunately libweave is still referencing older libchrome code. Until libweave is fixed, we still need to maintain the scoped_ptr patch in libchrome.

Filed  issue 674331  to track the issue with libweave.

Comment 17 by benchan@chromium.org, Dec 15 2016

Status: Fixed (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/7145441056c048c519a39e17627f7707fde3f194

commit 7145441056c048c519a39e17627f7707fde3f194
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Wed Jan 04 20:23:06 2017

attestation: use std::unique_ptr instead of scoped_ptr

scoped_ptr is gone in newer versions of libchrome, and right now
we patch in the old file to allow stuff like this to continue to
compile.

BUG= chromium:672314 
TEST=emerge

Change-Id: Iedcbaeb03a4cb44dac79c4a2a9c260a98f5fcd8d
Reviewed-on: https://chromium-review.googlesource.com/424997
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/7145441056c048c519a39e17627f7707fde3f194/attestation/common/tpm_utility_v1.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/462423d9294910663bf02a853355e76f1debdf1b

commit 462423d9294910663bf02a853355e76f1debdf1b
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Thu Mar 02 02:42:17 2017

libchrome: remove scoped_ptr epatch

We've removed all uses of scoped_ptr in libweave, and the feedback
uprev removes the inclusion of the scoped_ptr header there as well.
This means there are no more uses of scoped_ptr in our repo and
we can finally remove this epatch.

CQ-DEPEND=CL:*331176
CQ-DEPEND=CL:*331097
BUG= chromium:672314 
TEST=./build_packages --board={cave,arkham,whirlwind}

Change-Id: I848dbf1848bccc4869fc6aec46bbdd225829f97e
Reviewed-on: https://chromium-review.googlesource.com/446399
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/462423d9294910663bf02a853355e76f1debdf1b/chromeos-base/libchrome/libchrome-395517.ebuild
[rename] https://crrev.com/462423d9294910663bf02a853355e76f1debdf1b/chromeos-base/libchrome/libchrome-395517-r7.ebuild
[delete] https://crrev.com/695929b7eb46c56e57cf2b9663dfac8f66173a3a/chromeos-base/libchrome/files/patches/libchrome-395517-CHROMIUMOS-add-scoped-ptr.patch

Comment 22 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 23 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 24 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 25 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 26 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment