New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672312 link

Starred by 1 user
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
r...@chromium.org
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

AppWindowWaiter doesn't need to be scoped to chromeos

Project Member Reported by warx@chromium.org, Dec 8 2016 
plan to move chrome/browser/chromeos/login/test/app_window_waiter.h(cc) to a common place for all platforms

and merge the implementation of this: https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/tabs/tabs_test.cc?type=cs&q=tabs_test&sq=package:chromium&pv=1&l=821
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554

commit dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554
Author: warx <warx@chromium.org>
Date: Mon Dec 19 04:18:43 2016

Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG= 672312 
TEST=automated tests.

Review-Url: https://codereview.chromium.org/2576353002
Cr-Commit-Position: refs/heads/master@{#439406}

[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/apps/BUILD.gn
[rename] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/apps/test/app_window_waiter.cc
[rename] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/apps/test/app_window_waiter.h
[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc
[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/chrome/browser/chromeos/login/ui/login_feedback_browsertest.cc
[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554/chrome/test/BUILD.gn

Comment 2 by warx@chromium.org, Dec 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment