New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672297 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
cwp



Sign in to add a comment

Suppress unsupported event warnings in quipper

Project Member Reported by sque@chromium.org, Dec 8 2016

Issue description

From tipp:

We've started getting this warning.  It's harmless, but log spew is annoying.  I'd like to see the type supported, or just suppress the warning.

[perf_reader.cc:1890] Event type 82 is not yet supported!

Look like this is:
        PERF_RECORD_HEADER_PMU_MAPPINGS         = 82,

 

Comment 1 by gmx@chromium.org, Dec 8 2016

This should already be fixed by change: https://chromium-review.googlesource.com/#/c/413715/

We just need to sync the google3/third_party version.

Comment 2 by gmx@chromium.org, Dec 8 2016

By fixed, I mean the error message is suppressed, not that it's handled.

Comment 3 by sque@chromium.org, Dec 8 2016

You had fixed it in perf_serializer.cc. I'm fixing it in perf_reader.cc.

Comment 4 by gmx@chromium.org, Dec 8 2016

Right, I noticed the difference when you sent the CL for review :)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d795a8e19a9a0ffac9a62901eee181238175d028

commit d795a8e19a9a0ffac9a62901eee181238175d028
Author: Simon Que <sque@google.com>
Date: Thu Dec 08 00:23:50 2016

quipper: Suppress warning for unsupported but known event types

e.g PERF_RECORD_HEADER_PMU_MAPPINGS

BUG= chromium:672297 
TEST=build successfully

Change-Id: I530c485d715d6f8aee389e83c6b78e9a93d48e94
Reviewed-on: https://chromium-review.googlesource.com/417198
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Chong Jiang <chongjiang@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>

[modify] https://crrev.com/d795a8e19a9a0ffac9a62901eee181238175d028/chromiumos-wide-profiling/perf_reader.cc

Comment 6 by sque@chromium.org, Dec 9 2016

Status: Fixed (was: Started)

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment