New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672291 link

Starred by 1 user
Status: Assigned
Owner:
chcunningham@chromium.org
Cc:
█ sbc@chromium.org
posciak@chromium.org
rohi...@chromium.org
█ wuchengli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Media unittests lack presubmit coverage for ARM

Project Member Reported by chcunningham@chromium.org, Dec 8 2016 
Patch set 3 of this [0] change used test expectations that should have failed media_unittests on arm/arm64 systems. I expected us to have coverage via chromeOS, but found it missing. 

We could instead add coverage for android arm, but most media tests don't run there due to Issue 570762

[0] https://codereview.chromium.org/2171133002/

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by chcunningham@chromium.org, Dec 8 2016 

Rohitbm@, can you help me track down which cros bot/bot maintainer would ideally run these tests?

Comment 4 by chcunningham@chromium.org, Dec 8 2016

Cc: rohi...@chromium.org

Comment 5 by rohi...@chromium.org, Dec 8 2016

Cc: wuchengli@chromium.org posciak@chromium.org
Components: OS>Kernel>Video
+cros video eng might have more insight on unit test side coverage

Comment 6 by wuchengli@chromium.org, Dec 12 2016 

Are we talking about chromium or chroimum OS bots? Internal or external?

Comment 7 by chcunningham@chromium.org, Dec 12 2016 

> chromium or chromiumOS

Either - I'll take ARM coverage however I can get it. 

> Internal or external?

Ideally these tests would run as part of regular chromium code review presubmit. I _think_ such bots are considered external?

Comment 8 by mbjorge@google.com, Dec 16 2016 

Chromecasts are arm based, and we've had breakages due to the missing arm coverage. For example, the Opus tests break for us every now and then when the audio ashes don't get updated properly. We would definitely appreciate it if there was some arm coverage :)

Comment 9 by chcunningham@chromium.org, Jan 4 2017

Labels: -Pri-3 Pri-2
wuchengli@, any pointers?

Comment 10 by wuchengli@chromium.org, Jan 4 2017 

Sorry. I'm OOO this week.

Comment 11 by chcunningham@chromium.org, Jan 24 2017 

Hi wuchengli@, are you back? Can you advise?

Comment 12 by wuchengli@chromium.org, Jan 25 2017 

Pawel dug up the bug about adding an ARM builder. See discussion in  http://crbug.com/384104 .

Comment 13 by wuchengli@chromium.org, Feb 11 2017

Cc: sbc@chromium.org
sbc@ FYI.
►

Sign in to add a comment