Issue metadata
Sign in to add a comment
|
Regression in memory.top_10_mobile in GPU 425416 - 425604 |
||||||||||||||||||||||
Issue description
,
Dec 8 2016
=== PERF REGRESSION === === Auto-CCing suspected CL author eae@chromium.org === Hi eae@chromium.org, the bisect results pointed to your CL, please take a look at the results. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Remove unsafe getFontMetrics methods Author : eae Commit description: Remove the ComputedStyle::getFontMetrics and Font::getFontMetrics helper methods as they both assume that the primaryFont method always returns a valid SimpleFontDataObject. That assumption is both incorrect and unsafe as it can return nullptr in case fallback to the last-resort-font fails. By replacing the convince calls with explicit calls and null checks that type of problems becomes more apparent and can be handled appropriately. R=wkorman@chromium.org BUG=655815 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2416033003 Cr-Commit-Position: refs/heads/master@{#425437} Commit : fdcbab80bc37108f6e03d6906f27831228690350 Date : Fri Oct 14 19:51:13 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@425416 33358609 10267650 18 good chromium@425428 33052112 10081443 12 good chromium@425434 33074190 10105479 12 good chromium@425436 31345187 13115329 8 good chromium@425437 37431566 28849.2 5 bad <-- chromium@425440 35590883 13183964 8 bad chromium@425463 35682689 13157001 8 bad chromium@425510 32032784 34902626 27 unknown chromium@425511 35079899 18211781 12 bad chromium@425604 35064220 22263854 18 bad Bisect job ran on: android_nexus5_perf_bisect Bug ID: 672281 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile Test Metric: memory:chrome:gpu_process:reported_by_chrome:effective_size_avg/foreground/http_m_youtube_com_results_q_science Relative Change: 5.05% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4423 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8993891263129627040 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=6058799012511744 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Dec 19 2016
,
Feb 3 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 7 2016