Quickly pause and resume Chrome while presenting WebVR page will enter ChromeVR onResume |
|||||||
Issue description1. pair with a Cardboard 2. go to https://webvr.info/samples/03-vr-presentation.html 3. press present button 4. press task switcher button to pause current WebVr page 5. quickly select Chrome from task stack to resume browser (within 1 second) expected: WebVR in magic window mode actually: WebVR in magic window mode BUT displayed in a quad in ChromeVR. I am not sure how common someone may quickly pause/resume Chrome. So label it as M57 for now. We could try merge back to M56 if this is more common than I think.
,
Dec 8 2016
Shouldn't be an issue for M56, as ChromeVR (VR Shell) won't be enabled. You should stay in 2D as expected. Should be a relatively easy fix for M57 though.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c759a4044aa42e34c8ab4a0d1bffe60d0a58eda6 commit c759a4044aa42e34c8ab4a0d1bffe60d0a58eda6 Author: bshe <bshe@chromium.org> Date: Thu Dec 08 19:28:45 2016 Don't try to enter VR onResume for Cardboard mode BUG= 672273 Review-Url: https://codereview.chromium.org/2560843003 Cr-Commit-Position: refs/heads/master@{#437306} [modify] https://crrev.com/c759a4044aa42e34c8ab4a0d1bffe60d0a58eda6/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/c759a4044aa42e34c8ab4a0d1bffe60d0a58eda6/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/c759a4044aa42e34c8ab4a0d1bffe60d0a58eda6/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
,
Dec 9 2016
It is an issue for M56 too. Vr Shell is enabled as part of WebVR and we enter ChromeVR due to a wrong mode setting. The fix is now landed at TOT. I think it is safe to merge. Although it might be rare that user hit this issue, but since we are not suppose to expose ChromeVR in M56 and the fix is pretty trivial, let's still try to merge.
,
Dec 9 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f760a6661e89565a01535da34420d5e53b30795d commit f760a6661e89565a01535da34420d5e53b30795d Author: bshe <bshe@chromium.org> Date: Mon Dec 12 16:59:15 2016 Don't try to enter VR onResume for Cardboard mode This is the CL that merge the fix in https://codereview.chromium.org/2560843003/ to M56. The CL that landed in TOT has a small refactor which cause conflicts. So this CL only merge the relevent fix to M56 (stripped out the small refactor). BUG= 672273 R=mthiesse@chromium.org Review-Url: https://codereview.chromium.org/2564413003 . Cr-Commit-Position: refs/branch-heads/2924@{#457} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/f760a6661e89565a01535da34420d5e53b30795d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Dec 12 2016
,
Dec 16 2016
,
Jul 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sko...@chromium.org
, Dec 8 2016