AVDA should not queue an EOS if the codec is empty |
||
Issue descriptionReported here http://b/33304416 Some MediaCodecs don't like to get an EOS as the first input, so we should skip the drain if the decoder is empty and we have no pending inputs.
,
Dec 8 2016
CL here if you want to patch it in and verify it tsunghung@? https://codereview.chromium.org/2563533002
,
Dec 8 2016
I just verified the CL, and it worked fine. Thanks a lot for your help.
,
Dec 8 2016
Perfect, thanks for checking!
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89afd26f42c7a417841e1657499f5216262906d2 commit 89afd26f42c7a417841e1657499f5216262906d2 Author: watk <watk@chromium.org> Date: Fri Dec 09 02:22:30 2016 media: AVDA now doesn't queue EOS for a flush if the codec is empty Apparently some MediaCodecs consider it an error to receive an EOS buffer as their first input. So now we skip queueing the EOS if there are no pending buffers in the decoder and no pending inputs. BUG= 672268 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2563533002 Cr-Commit-Position: refs/heads/master@{#437436} [modify] https://crrev.com/89afd26f42c7a417841e1657499f5216262906d2/media/gpu/android_video_decode_accelerator.cc [modify] https://crrev.com/89afd26f42c7a417841e1657499f5216262906d2/media/gpu/android_video_decode_accelerator.h
,
Dec 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by sanfin@chromium.org
, Dec 7 2016