New issue
Advanced search Search tips

Issue 672265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

The "master <x> scheduled for a restart at <time>" doesn't show internal masters

Project Member Reported by aga...@chromium.org, Dec 7 2016

Issue description

I handled three tickets to restart masters, one for chromium.android, one for client.boringssl, and one for chromeos.branch. After filing the three CLs, a nice purple box showed up on the top of /trooper saying that the masters would be restarted. Awesome!

Except it didn't have a line saying that chromeos.branch would be restarted. It only showed the two external masters. This makes me sad.
 
Labels: Milestone-Workflow
Thanks for the feedback! This sounds like a good change to make. 

Adding a milestone to this. 
Status: Started (was: Untriaged)
Cc: -seanmccullough@chromium.org
Owner: seanmccullough@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3439f40e09fc8ca5291e21a22fc22d05a947b9dd

commit 3439f40e09fc8ca5291e21a22fc22d05a947b9dd
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri Dec 09 23:00:56 2016

[som] Show internal master restarts on /trooper page

Also refactores some gitiles access stuff to add easy caching.

BUG= 672265 

Change-Id: Id4eed70fe646d8bf1f11c87da9c5a8bd24c597e4
Reviewed-on: https://chromium-review.googlesource.com/418475
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/3439f40e09fc8ca5291e21a22fc22d05a947b9dd/go/src/infra/appengine/sheriff-o-matic/som/alerts.go
[modify] https://crrev.com/3439f40e09fc8ca5291e21a22fc22d05a947b9dd/go/src/infra/appengine/sheriff-o-matic/som/gitiles.go
[modify] https://crrev.com/3439f40e09fc8ca5291e21a22fc22d05a947b9dd/go/src/infra/appengine/sheriff-o-matic/som/pubsub.go

Status: Fixed (was: Started)
Fix should go out with the next release

Sign in to add a comment