Issue metadata
Sign in to add a comment
|
MacOS Fullscreen: Menubar / Toolbar animation is very slow and sluggish |
||||||||||||||||||||||
Issue descriptionChrome Version: Latest Canary 57.0.2944.0 OS: Mac OS 10.12.1 What steps will reproduce the problem? (1) Open a Chrome window in Fullscreen. (2) Move the mouse cursor to the top and away again, so that the Menubar appears and disappears. What is the expected result? What happens instead? On 10.12.1 the animation is very slow and sluggish. Please use labels and text to provide additional information. A screencast is attached.
,
Apr 16 2017
I am also having this problem. The main thing is that the entire content window freezes while the animation is playing, including fullscreen youtube video.
,
Apr 16 2017
Any chance to fix this for M59 since this worked fine in 10.11.x and is now broken in 10.12.x? Thank you.
,
Apr 16 2017
Working on it
,
Apr 16 2017
Great, thank you very much.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34fe593135e5c15e0660fca8a86b5dbd960e3255 commit 34fe593135e5c15e0660fca8a86b5dbd960e3255 Author: spqchan <spqchan@chromium.org> Date: Wed Apr 26 17:47:08 2017 [Mac] Fullscreen Toolbar Janky Animation Fix The browser UI doesn't update when the menubar is being revealed in 10.12+ which makes the toolbar janky. To smooth things out, we should animate the toolbar in and out. BUG= 672254 Review-Url: https://codereview.chromium.org/2827383004 Cr-Commit-Position: refs/heads/master@{#467368} [modify] https://crrev.com/34fe593135e5c15e0660fca8a86b5dbd960e3255/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
,
Jul 12 2017
spqchan@: The hide in/out animation of the Menubar in Fullscreen Mode looks and feels smooth again in macOS 10.12.5 with latest Canary Version 61.0.3155.0. I think has been fixed by your comment 7 in issue 732952 . Thanks :-)
,
Jul 12 2017
It's still kind of out of sync with the menu bar for me, and there's no animation when the toolbar is hidden. Attaching a screen recording in case it's different from what you see.
,
Jul 12 2017
Not an easy thing to fix because the browser UI doesn't draw when the menu bar animates
,
Jul 12 2017
sdy@: Yes, you're right. Comparing Stable with Canary you'll notice that is a bit better now in Canary. Here are two screencast Stable vs Canary.
,
Jul 24 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c0dbb478638cebb3606d74a69696e63d62529bd commit 2c0dbb478638cebb3606d74a69696e63d62529bd Author: Sidney San MartÃn <sdy@chromium.org> Date: Tue Jul 25 17:46:09 2017 Call +[CATransaction flush] for the toolbar to move with the menu bar. Bug: 672254 Change-Id: I1f6a8a6e0cc5437a67703650732b3ed12c785351 Reviewed-on: https://chromium-review.googlesource.com/581859 Commit-Queue: Sidney San Martin <sdy@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#489358} [modify] https://crrev.com/2c0dbb478638cebb3606d74a69696e63d62529bd/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
,
Jul 26 2017
Thanks sdy@. Looks good in Chrome Canary Version 62.0.3167.0 on macOS 10.12.6. (Removing OS=Chrome label. This issue is macOS-only.)
,
Aug 22 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Dec 9 2016Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)