Analyze doesn't properly handle changes to Mac sandbox .sb files |
||||
Issue descriptionOn https://codereview.chromium.org/2531163007, I modified a .sb file, which contains Mac sandbox policy data. However the mac_chromium_rel_ng bot analyzed this as having no effect and did nothing: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/344643 ... except this change could have huge effect. All the blink_*mac bots did the same thing, which isn't good for running layout tests.
,
Dec 8 2016
As you note the .sb files make it into the .pak, so how should this be added to //content:resources? The fix for bug 639328 seems like it'd work too (and maybe fix other instances of this occurring).
,
Dec 8 2016
I believe you'd change the resources target to:
grit("resources") {
...
inputs = [ "renderer/renderer.sb" ]
...
}
Yes, bug 639328 should be fixed regardless.
,
Dec 9 2016
Is there an eta for bug 639328 ? If not, I can update this for all the .sb files, but I'm pretty sure that won't be an exhaustive list of inputs to the grit steps.
,
Dec 9 2016
I will try to get to it early next week, but I probably won't get to it before then. Yes, asking you to figure out the exhaustive list of inputs to every grit call manually would be silly.
,
Jul 10 2017
Dirk: if you're busy, can you reassign this to someone else?
,
Jul 10 2017
I think the thing to do is to fix 639328; I'll try to get to that today (as I noted on the other bug).
,
Jul 11 2017
,
Sep 1 2017
This should be working now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Dec 7 2016Status: Available (was: Untriaged)