New issue
Advanced search Search tips

Issue 672244 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocked on:
issue 639328



Sign in to add a comment

Analyze doesn't properly handle changes to Mac sandbox .sb files

Project Member Reported by rsesek@chromium.org, Dec 7 2016

Issue description

On https://codereview.chromium.org/2531163007, I modified a .sb file, which contains Mac sandbox policy data. However the mac_chromium_rel_ng bot analyzed this as having no effect and did nothing: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/344643 ... except this change could have huge effect. All the blink_*mac bots did the same thing, which isn't good for running layout tests.
 
Components: -Infra Build
Status: Available (was: Untriaged)
The problem here is that GN knows nothing about //content/renderer/renderer.sb. It should be listed as an input to //content:resources. Do you feel like adding that?

There's also  bug 639328  which, I believe, is supposed to eliminate this class of problems by making grit tell GN what the dependencies are, that I haven't gotten around to fixing. We should still manually add the dependencies where possible, because the fix in 639328 is slower and is only optionally enabled as a result.


As you note the .sb files make it into the .pak, so how should this be added to //content:resources? The fix for  bug 639328  seems like it'd work too (and maybe fix other instances of this occurring).
I believe you'd change the resources target to:

grit("resources") {
  ...
  inputs = [ "renderer/renderer.sb" ]
  ...
}

Yes,  bug 639328  should be fixed regardless.
Is there an eta for  bug 639328 ? If not, I can update this for all the .sb files, but I'm pretty sure that won't be an exhaustive list of inputs to the grit steps.
I will try to get to it early next week, but I probably won't get to it before then.

Yes, asking you to figure out the exhaustive list of inputs to every grit call manually would be silly.

Comment 6 by jam@chromium.org, Jul 10 2017

Dirk: if you're busy, can you reassign this to someone else?
Blockedon: 639328
Owner: dpranke@chromium.org
Status: Started (was: Available)
I think the thing to do is to fix 639328; I'll try to get to that today (as I noted on the other bug).
Labels: -Pri-2 Pri-1
Status: Fixed (was: Started)
This should be working now.

Sign in to add a comment