New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672243 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Bandwidth throttling does not persist across reboots

Project Member Reported by kirtika@google.com, Dec 7 2016

Issue description

OS: 8992.0.0 or higher

The shill code for bandwidth throttling was checked in before the chrome code that supports the policy. As a result, it is missing updates to the placeholder where it should read and apply the policy on boot-up:

void Manager::ApplyPolicies() {
  if (!policy_provider_.get())
    policy_provider_.reset(new policy::PolicyProvider());
  policy_provider_->Reload();
  SLOG(this, 2) << "Reloaded policies";

  if (policy_provider_->device_policy_is_loaded()) {
    // TODO(kirtika): Blocked on Chrome providing throttling policy.
    // crbug.com/634529
    // Read from the policy here instead of using dummy values
    // network_throttling_enabled_ = true;
    // download_rate_kbits_ = 1000;
    // upload_rate_kbits_ = 1000;
  }
}


@Test team: Please confirm that if you set a throttling policy and then reboot the device, it does NOT get applied.

 
Yes, I did notice this. But, if the enrolled devices are rebooted, the policies are pushed to the device through c-panel after reboot. Should we still consider this a bug?

Comment 2 by kirtika@google.com, Dec 7 2016

If throttling persists across a reboot, that is great.
The next thing to check is if it persists with "restart shill".
Owner: kirtika@chromium.org
Sure. "restart shill" tests shall be added to the test cases list.
Ran quick tests with "chrome sign builder" app to check if the values persist after "restart shill" and "restart ui" and confirm the values persisted even after the shill is restarted.

kkanchi@kkanchi0:~$ ssh root@100.96.49.31

localhost ~ # restart shill
shill start/running, process 5708
localhost ~ # restart shill
shill start/running, process 5853

localhost ~ # restart ui
ui start/running, process 6022


Comment 5 by kirtika@google.com, Jan 26 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment