Bandwidth throttling does not persist across reboots |
|||
Issue description
OS: 8992.0.0 or higher
The shill code for bandwidth throttling was checked in before the chrome code that supports the policy. As a result, it is missing updates to the placeholder where it should read and apply the policy on boot-up:
void Manager::ApplyPolicies() {
if (!policy_provider_.get())
policy_provider_.reset(new policy::PolicyProvider());
policy_provider_->Reload();
SLOG(this, 2) << "Reloaded policies";
if (policy_provider_->device_policy_is_loaded()) {
// TODO(kirtika): Blocked on Chrome providing throttling policy.
// crbug.com/634529
// Read from the policy here instead of using dummy values
// network_throttling_enabled_ = true;
// download_rate_kbits_ = 1000;
// upload_rate_kbits_ = 1000;
}
}
@Test team: Please confirm that if you set a throttling policy and then reboot the device, it does NOT get applied.
,
Dec 7 2016
If throttling persists across a reboot, that is great. The next thing to check is if it persists with "restart shill".
,
Dec 7 2016
Sure. "restart shill" tests shall be added to the test cases list.
,
Dec 7 2016
Ran quick tests with "chrome sign builder" app to check if the values persist after "restart shill" and "restart ui" and confirm the values persisted even after the shill is restarted. kkanchi@kkanchi0:~$ ssh root@100.96.49.31 localhost ~ # restart shill shill start/running, process 5708 localhost ~ # restart shill shill start/running, process 5853 localhost ~ # restart ui ui start/running, process 6022
,
Jan 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kkan...@chromium.org
, Dec 7 2016