New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672227 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

android: native media controls not shown

Reported by pdk...@gmail.com, Dec 7 2016

Issue description

Example URL:

Steps to reproduce the problem:
1. Go to website with embedded YT video.
2. Play video.

What is the expected behavior?
Video controls are shown, such as play, seek and volume.

What went wrong?
The bar is shown at the bottom, but without controls (icons).

Did this work before? Yes 54

Is it a problem with Flash or HTML5? HTML5

Does this work in other browsers? Yes

Chrome version: 56.0.2924.18  Channel: dev
OS Version: 
Flash Version: 

(I haven't tried M55.)
 
Status: Untriaged (was: Unconfirmed)
I just ran into this as well.  Repros on current dev, but works ok on beta.
Components: Blink>Media>Controls
What Android version do you have? What website did you reproduce it on?
Cc: ppergame@chromium.org avayvod@chromium.org liber...@chromium.org
Components: -Internals>Media
Labels: M-56
Doesn't YouTube use custom controls on Android? pdknsk, is there a reason you used "native" in the summary?

Beta is currently M55 and dev is currently M56, so this is a regression in M56.
Cc: -liber...@chromium.org mlamouri@chromium.org
Labels: Needs-Feedback
This is likely a regression from the controls cutting feature. Though, it would be good to have a page to reproduce the bug on.
This repros on https://developers.google.com/youtube/youtube_player_demo.  I am reproing on Android N.
Owner: billorr@chromium.org
Taking this since it's semi-blocking something I'm trying to test.
Labels: ReleaseBlock-Stable
Marking RBS to ensure this gets a merge back to m56.
this is likely same as crbug/672019
Cc: amineer@chromium.org
Cc: -mlamouri@chromium.org billorr@chromium.org
Labels: hasbisect-per-revision
Owner: mlamouri@chromium.org
Status: Assigned (was: Untriaged)
Cc: -billorr@chromium.org mlamouri@chromium.org
Owner: billorr@chromium.org
Whoops, sorry, switching back the owner as per comment#6.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d8e2478297992731014b1dc6661a420aaa3f1e9

commit 1d8e2478297992731014b1dc6661a420aaa3f1e9
Author: billorr <billorr@chromium.org>
Date: Fri Dec 09 02:23:53 2016

Ensure LayoutMedia notifies MediaControls of panel width

Some pages weren't showing native media controls on Android.  This was easiest to repro when using an iframe to embed youtube content.

LayoutMedia notifies MediaControls of the panel width so MediaControls can decide what controls will fit.  LayoutMedia calculates the size during layout, and only notifies the MediaControls if the size changes.

In the case of the bug, LayoutMedia never notifies MediaControls of the correct size.  The first time layout occurs, there is no child MediaControls.  During subsequent layouts, notifications aren't sent because the size hasn't changed.

The fix is to ensure we send the panel width to MediaControls if the size change or if we haven't yet sent the width.

BUG= 672227 

Review-Url: https://codereview.chromium.org/2561823003
Cr-Commit-Position: refs/heads/master@{#437437}

[modify] https://crrev.com/1d8e2478297992731014b1dc6661a420aaa3f1e9/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
[modify] https://crrev.com/1d8e2478297992731014b1dc6661a420aaa3f1e9/third_party/WebKit/Source/core/layout/LayoutMedia.h

Comment 14 by pdk...@gmail.com, Dec 9 2016

​> pdknsk, is there a reason you used "native" in the summary?

My comment is obsolete now, but the reason is that the class name of the
bar is yt-native-controls or similar.​
Issue 672765 has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 9 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1047c8486f046b5ec795cef3c0af640ced0ee5f5

commit 1047c8486f046b5ec795cef3c0af640ced0ee5f5
Author: Alex Mineer <amineer@chromium.org>
Date: Fri Dec 09 17:48:09 2016

Ensure LayoutMedia notifies MediaControls of panel width

Some pages weren't showing native media controls on Android.  This was easiest to repro when using an iframe to embed youtube content.

LayoutMedia notifies MediaControls of the panel width so MediaControls can decide what controls will fit.  LayoutMedia calculates the size during layout, and only notifies the MediaControls if the size changes.

In the case of the bug, LayoutMedia never notifies MediaControls of the correct size.  The first time layout occurs, there is no child MediaControls.  During subsequent layouts, notifications aren't sent because the size hasn't changed.

The fix is to ensure we send the panel width to MediaControls if the size change or if we haven't yet sent the width.

BUG= 672227 

(cherry picked from commit 1d8e2478297992731014b1dc6661a420aaa3f1e9)

Review-Url: https://codereview.chromium.org/2561823003
Cr-Original-Commit-Position: refs/heads/master@{#437437}
Cr-Commit-Position: refs/branch-heads/2924@{#431}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1047c8486f046b5ec795cef3c0af640ced0ee5f5/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
[modify] https://crrev.com/1047c8486f046b5ec795cef3c0af640ced0ee5f5/third_party/WebKit/Source/core/layout/LayoutMedia.h

Labels: -ReleaseBlock-Stable ReleaseBlock-Beta
Status: Fixed (was: Assigned)
This should now be fixed with the CP back to M56.  Marking as such, please reopen if further work required.
Cc: k...@chromium.org
 Issue 672966  has been merged into this issue.
Issue 672019 has been merged into this issue.
Thanks billorr@ :)
Checked on Pixel XL / NMF26S vs 56.0.2924.23 and Nexus 5 / MOB31H vs 56.0.2924.23 
video controls were fixed, but when you click on the CNN link from Facebook and try to watch video, it will get stuck in spinning mode 
And when I tried to watch video on EuroBD News through Facebook, I see video and control are working fine, but video is cut in half 

please see screenshots and logs -> http://go/chrome-androidlogs1/6/672019 
Status: Assigned (was: Fixed)
Reopening until we understand what might be causing this.
Status: Fixed (was: Assigned)
Sorry, #c21 is not related to this bug. Please, file a new bug for investigation.
"Chrome for Android" ->Verified in M56-56.0.2924.23  build

Comment 25 by pdk...@gmail.com, Dec 11 2016

​Confirmed.​
 Issue 673187  has been merged into this issue.
"Chrome for Android" ->Verified in M57-57.0.2950.3  build

Sign in to add a comment