Issue metadata
Sign in to add a comment
|
android: native media controls not shown
Reported by
pdk...@gmail.com,
Dec 7 2016
|
||||||||||||||||||||||
Issue descriptionExample URL: Steps to reproduce the problem: 1. Go to website with embedded YT video. 2. Play video. What is the expected behavior? Video controls are shown, such as play, seek and volume. What went wrong? The bar is shown at the bottom, but without controls (icons). Did this work before? Yes 54 Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? Yes Chrome version: 56.0.2924.18 Channel: dev OS Version: Flash Version: (I haven't tried M55.)
,
Dec 8 2016
What Android version do you have? What website did you reproduce it on?
,
Dec 8 2016
Doesn't YouTube use custom controls on Android? pdknsk, is there a reason you used "native" in the summary? Beta is currently M55 and dev is currently M56, so this is a regression in M56.
,
Dec 8 2016
This is likely a regression from the controls cutting feature. Though, it would be good to have a page to reproduce the bug on.
,
Dec 8 2016
This repros on https://developers.google.com/youtube/youtube_player_demo. I am reproing on Android N.
,
Dec 8 2016
Taking this since it's semi-blocking something I'm trying to test.
,
Dec 9 2016
Marking RBS to ensure this gets a merge back to m56.
,
Dec 9 2016
this is likely same as crbug/672019
,
Dec 9 2016
,
Dec 9 2016
Bisect script pointed to this CL as the cause - https://chromium.googlesource.com/chromium/src/+/3347bb8ad251e778ed35c433c0246e0659f2402d I was using this test page - https://www.buzzfeed.com/mercedessandoval/mini-twice-baked-potatoes
,
Dec 9 2016
,
Dec 9 2016
Whoops, sorry, switching back the owner as per comment#6.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d8e2478297992731014b1dc6661a420aaa3f1e9 commit 1d8e2478297992731014b1dc6661a420aaa3f1e9 Author: billorr <billorr@chromium.org> Date: Fri Dec 09 02:23:53 2016 Ensure LayoutMedia notifies MediaControls of panel width Some pages weren't showing native media controls on Android. This was easiest to repro when using an iframe to embed youtube content. LayoutMedia notifies MediaControls of the panel width so MediaControls can decide what controls will fit. LayoutMedia calculates the size during layout, and only notifies the MediaControls if the size changes. In the case of the bug, LayoutMedia never notifies MediaControls of the correct size. The first time layout occurs, there is no child MediaControls. During subsequent layouts, notifications aren't sent because the size hasn't changed. The fix is to ensure we send the panel width to MediaControls if the size change or if we haven't yet sent the width. BUG= 672227 Review-Url: https://codereview.chromium.org/2561823003 Cr-Commit-Position: refs/heads/master@{#437437} [modify] https://crrev.com/1d8e2478297992731014b1dc6661a420aaa3f1e9/third_party/WebKit/Source/core/layout/LayoutMedia.cpp [modify] https://crrev.com/1d8e2478297992731014b1dc6661a420aaa3f1e9/third_party/WebKit/Source/core/layout/LayoutMedia.h
,
Dec 9 2016
> pdknsk, is there a reason you used "native" in the summary? My comment is obsolete now, but the reason is that the class name of the bar is yt-native-controls or similar.
,
Dec 9 2016
Issue 672765 has been merged into this issue.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1047c8486f046b5ec795cef3c0af640ced0ee5f5 commit 1047c8486f046b5ec795cef3c0af640ced0ee5f5 Author: Alex Mineer <amineer@chromium.org> Date: Fri Dec 09 17:48:09 2016 Ensure LayoutMedia notifies MediaControls of panel width Some pages weren't showing native media controls on Android. This was easiest to repro when using an iframe to embed youtube content. LayoutMedia notifies MediaControls of the panel width so MediaControls can decide what controls will fit. LayoutMedia calculates the size during layout, and only notifies the MediaControls if the size changes. In the case of the bug, LayoutMedia never notifies MediaControls of the correct size. The first time layout occurs, there is no child MediaControls. During subsequent layouts, notifications aren't sent because the size hasn't changed. The fix is to ensure we send the panel width to MediaControls if the size change or if we haven't yet sent the width. BUG= 672227 (cherry picked from commit 1d8e2478297992731014b1dc6661a420aaa3f1e9) Review-Url: https://codereview.chromium.org/2561823003 Cr-Original-Commit-Position: refs/heads/master@{#437437} Cr-Commit-Position: refs/branch-heads/2924@{#431} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/1047c8486f046b5ec795cef3c0af640ced0ee5f5/third_party/WebKit/Source/core/layout/LayoutMedia.cpp [modify] https://crrev.com/1047c8486f046b5ec795cef3c0af640ced0ee5f5/third_party/WebKit/Source/core/layout/LayoutMedia.h
,
Dec 9 2016
This should now be fixed with the CP back to M56. Marking as such, please reopen if further work required.
,
Dec 9 2016
,
Dec 9 2016
Issue 672019 has been merged into this issue.
,
Dec 9 2016
Thanks billorr@ :)
,
Dec 9 2016
Checked on Pixel XL / NMF26S vs 56.0.2924.23 and Nexus 5 / MOB31H vs 56.0.2924.23 video controls were fixed, but when you click on the CNN link from Facebook and try to watch video, it will get stuck in spinning mode And when I tried to watch video on EuroBD News through Facebook, I see video and control are working fine, but video is cut in half please see screenshots and logs -> http://go/chrome-androidlogs1/6/672019
,
Dec 9 2016
Reopening until we understand what might be causing this.
,
Dec 9 2016
Sorry, #c21 is not related to this bug. Please, file a new bug for investigation.
,
Dec 10 2016
"Chrome for Android" ->Verified in M56-56.0.2924.23 build
,
Dec 11 2016
Confirmed.
,
Dec 12 2016
Issue 673187 has been merged into this issue.
,
Dec 13 2016
"Chrome for Android" ->Verified in M57-57.0.2950.3 build |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by billorr@chromium.org
, Dec 8 2016